Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33020

ComputedFolder shows BuildAuthorizationToken configuration but does not actually support it

    Details

    • Similar Issues:

      Description

      It's not possible to enable Trigger builds remotely. The setting will not be persisted even if the option can be set. (The other Build Triggers can be set and are honored)

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            BTW an alternate misinterpretation of the checkbox which should not be here is to set a build token on each branch project inside the folder, i.e. to schedule actually project builds rather than indexing. This is not currently possible; one bullet point in JENKINS-30519 proposes a possible implementation, but really BuildAuthorizationToken is a deprecated system that is fundamentally insecure, and probably ultimately better solved by allowing users to create limited-access tokens.

            Show
            jglick Jesse Glick added a comment - BTW an alternate misinterpretation of the checkbox which should not be here is to set a build token on each branch project inside the folder, i.e. to schedule actually project builds rather than indexing. This is not currently possible; one bullet point in JENKINS-30519 proposes a possible implementation, but really BuildAuthorizationToken is a deprecated system that is fundamentally insecure, and probably ultimately better solved by allowing users to create limited-access tokens.
            Hide
            dawi Daniel Wilmer added a comment - - edited

            Jesse Glick Thanks for clarification.

            I just wanted to verify that /notifyCommit works fine.
            Jenkins Users, just be sure to use exactly the same repository urls in the job configuration and notification url.

            Show
            dawi Daniel Wilmer added a comment - - edited Jesse Glick Thanks for clarification. I just wanted to verify that /notifyCommit works fine. Jenkins Users, just be sure to use exactly the same repository urls in the job configuration and notification url. works: Multibranch pipeline repository url: git@gitlab:some/project.git Multibranch pipeline notification url: https://jenkins/git/notifyCommit?url=git@gitlab:some/project.git works: Multibranch pipeline repository url: git@gitlab.intranet:some/project.git Multibranch pipeline notification url: https://jenkins/git/notifyCommit?url=git@gitlab.intranet:some/project.git does not work (misconfiguration): Multibranch pipeline repository url: git@gitlab.intranet:some/project.git Multibranch pipeline notification url: https://jenkins/git/notifyCommit?url=git@gitlab:some/project.git
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            src/main/resources/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder/configure-details.jelly
            src/main/resources/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder/configure-details.properties
            src/main/resources/com/cloudbees/hudson/plugins/folder/computed/Messages.properties
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/9c378bea8901a0fddd0bdcea0783b98dae7d1078
            Log:
            [FIXED JENKINS-40921][FIXED JENKINS-33020] Only display triggers that make sense for a folder computation

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java src/main/resources/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder/configure-details.jelly src/main/resources/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder/configure-details.properties src/main/resources/com/cloudbees/hudson/plugins/folder/computed/Messages.properties http://jenkins-ci.org/commit/cloudbees-folder-plugin/9c378bea8901a0fddd0bdcea0783b98dae7d1078 Log: [FIXED JENKINS-40921] [FIXED JENKINS-33020] Only display triggers that make sense for a folder computation
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            src/main/resources/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder/configure-details.jelly
            src/main/resources/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder/configure-details.properties
            src/main/resources/com/cloudbees/hudson/plugins/folder/computed/Messages.properties
            src/test/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolderTest.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/0d35973205f9bf79eee02ba36dc380f02b6ecc0a
            Log:
            Merge pull request #89 from stephenc/jenkins-40921

            [FIXED JENKINS-40921][FIXED JENKINS-33020] Only display triggers that make sense for a folder computation

            Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/ea44cb643427...0d35973205f9

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java src/main/resources/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder/configure-details.jelly src/main/resources/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder/configure-details.properties src/main/resources/com/cloudbees/hudson/plugins/folder/computed/Messages.properties src/test/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolderTest.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/0d35973205f9bf79eee02ba36dc380f02b6ecc0a Log: Merge pull request #89 from stephenc/jenkins-40921 [FIXED JENKINS-40921] [FIXED JENKINS-33020] Only display triggers that make sense for a folder computation Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/ea44cb643427...0d35973205f9
            Hide
            stephenconnolly Stephen Connolly added a comment -

            cloudbees-folders 6.0.0

            Show
            stephenconnolly Stephen Connolly added a comment - cloudbees-folders 6.0.0

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                reinhapa Patrick Reinhart
              • Votes:
                19 Vote for this issue
                Watchers:
                26 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: