Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33078

The "Claim it" link does not work when apostrophe used in any failure cause

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: claim-plugin
    • Labels:
      None
    • Environment:
      Jenkins version : 1.642.1
      claim-plugin version : 2.8
      OS : CentOS 6.5
      Container: OS package from Jenkins repo
      JDK: jdk1.8.0_45
      Browser: Chrome 48.0.2564.116 and Firefox 44.0.2
    • Similar Issues:

      Description

      We just upgraded our Jenkins today and the claim plugin was not working afterwards

      Clicking the claim link was not causing the claim dialogue to appear.

      Run the Chrome Console I see this error message

      "Uncaught SyntaxError: Unexpected identifier" and the error underline starting at the first apostrophe character (U+0027).

      When I click on the "Claim it" link I see "Uncaught ReferenceError: ShowPopup is not defined" in the console.

      I think the issue is related to the build failure analyzer integration as we also have the Build Failure Analyzer plugin installed and if I remove all the apostrophe characters in my "failure-cause-management" list then 2.8 works.

      I also found that downgrading the claim plugin to 2.7 fixed the problem which I guess makes sense if it does not have the build failure integration.

        Attachments

          Activity

          Hide
          postman Per Östman added a comment -

          I can confirm that we see the same issue.
          Please fix.

          Show
          postman Per Östman added a comment - I can confirm that we see the same issue. Please fix.
          Hide
          drekbour Marc Carter added a comment -

          Ditto. Jenkins 1.622, Claim 2.8, BFA 1.13.0

          Show
          drekbour Marc Carter added a comment - Ditto. Jenkins 1.622, Claim 2.8, BFA 1.13.0
          Hide
          tenwit Paul Hicks added a comment -

          Me too. Though removing BFA apostrophes didn't help. Maybe I missed one.

          Show
          tenwit Paul Hicks added a comment - Me too. Though removing BFA apostrophes didn't help. Maybe I missed one.
          Hide
          wolfs Stefan Wolf added a comment -

          Opened a pull-request to fix the problem: https://github.com/jenkinsci/claim-plugin/pull/20

          Show
          wolfs Stefan Wolf added a comment - Opened a pull-request to fix the problem: https://github.com/jenkinsci/claim-plugin/pull/20
          Hide
          wolfs Stefan Wolf added a comment -

          Paul Hicks: Newlines also cause the same problem

          Show
          wolfs Stefan Wolf added a comment - Paul Hicks : Newlines also cause the same problem
          Hide
          lhe L H added a comment - - edited

          I am currently evaluating BFA (1.15.0) and Claim (2.8) addon on Jenkins 1.609.3 to see if we can use it. I also saw the apostrophe and newline issue. They show up in the web console. The pull request by Stefan Wolf hasn't yet gone through, so I don't know if that works.

          Removing the apostrophes and the new lines allowed the claim plugin to automatically populate the description field when a BFA reason is selected from the drop down list. (which it wasn't able to do when running into the apostrophe and new line bug).

          Show
          lhe L H added a comment - - edited I am currently evaluating BFA (1.15.0) and Claim (2.8) addon on Jenkins 1.609.3 to see if we can use it. I also saw the apostrophe and newline issue. They show up in the web console. The pull request by Stefan Wolf hasn't yet gone through, so I don't know if that works. Removing the apostrophes and the new lines allowed the claim plugin to automatically populate the description field when a BFA reason is selected from the drop down list. (which it wasn't able to do when running into the apostrophe and new line bug).
          Hide
          greybird Arnaud TAMAILLON added a comment -

          Fixed in 2.9

          Show
          greybird Arnaud TAMAILLON added a comment - Fixed in 2.9

            People

            • Assignee:
              ki82 Christian Bremer
              Reporter:
              kevinhcross Kevin Cross
            • Votes:
              7 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: