Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33109

Log window appear at top of the page

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      When executing a pipeline and you get the pipeline stage view matrix, you might want to see the logs, if you push on logs button of an stage, the log windows are rendered at top of the page which might be not visible, so all the windows become dark but you don't see anything and you need to scroll up. Users might think that the pop up has not been shown.

        Attachments

          Activity

          Hide
          mrose Michael Rose added a comment -

          The first time this happen to me, I thought the browser had frozen.

          Show
          mrose Michael Rose added a comment - The first time this happen to me, I thought the browser had frozen.
          Hide
          svanoort Sam Van Oort added a comment - - edited

          After investigating this to try to resolve it this weekend, it looks like this is due to the CSS placement being overridden during onshow or applyPlacement: I can manually set the placement:right option in view/stage-logs.js or override the css value for 'top' with onElement.offset().top in the dialog: but when I hit view/widgets/dialog/index.js (IIRC) line 70, the DOM element's explicit inline CSS style for 'top' reverts.

          It makes me wonder if the onElement is somehow getting bound to an element other than the stage cell. But in any case, after several hours trying to explain/resolve the behavior, will have to come back to this one.

          Probable culprit: https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/js/view/widgets/popover/index.js#L315-L358

          Show
          svanoort Sam Van Oort added a comment - - edited After investigating this to try to resolve it this weekend, it looks like this is due to the CSS placement being overridden during onshow or applyPlacement: I can manually set the placement:right option in view/stage-logs.js or override the css value for 'top' with onElement.offset().top in the dialog: but when I hit view/widgets/dialog/index.js (IIRC) line 70, the DOM element's explicit inline CSS style for 'top' reverts. It makes me wonder if the onElement is somehow getting bound to an element other than the stage cell. But in any case, after several hours trying to explain/resolve the behavior, will have to come back to this one. Probable culprit: https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/js/view/widgets/popover/index.js#L315-L358
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          ui/src/main/js/view/stage-logs.js
          ui/src/main/js/view/widgets/dialog/index.js
          http://jenkins-ci.org/commit/pipeline-stage-view-plugin/040d395bac8aed3787cfe531514b10045b314321
          Log:
          Fix JENKINS-33109 by placing logs window to the right of element

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: ui/src/main/js/view/stage-logs.js ui/src/main/js/view/widgets/dialog/index.js http://jenkins-ci.org/commit/pipeline-stage-view-plugin/040d395bac8aed3787cfe531514b10045b314321 Log: Fix JENKINS-33109 by placing logs window to the right of element
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          ui/src/main/js/view/stage-logs.js
          ui/src/main/js/view/widgets/dialog/index.js
          ui/src/main/js/view/widgets/popover/index.js
          ui/src/test/js/util/formatters-spec.js
          http://jenkins-ci.org/commit/pipeline-stage-view-plugin/18898e7fd7be4be19df7ff18c0067c6db5940fcb
          Log:
          Merge pull request #12 from jenkinsci/fix-log-placement

          Fix log popup placement JENKINS-33109

          Compare: https://github.com/jenkinsci/pipeline-stage-view-plugin/compare/c5c9c333bd4b...18898e7fd7be

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: ui/src/main/js/view/stage-logs.js ui/src/main/js/view/widgets/dialog/index.js ui/src/main/js/view/widgets/popover/index.js ui/src/test/js/util/formatters-spec.js http://jenkins-ci.org/commit/pipeline-stage-view-plugin/18898e7fd7be4be19df7ff18c0067c6db5940fcb Log: Merge pull request #12 from jenkinsci/fix-log-placement Fix log popup placement JENKINS-33109 Compare: https://github.com/jenkinsci/pipeline-stage-view-plugin/compare/c5c9c333bd4b...18898e7fd7be
          Hide
          svanoort Sam Van Oort added a comment -

          Verified and merged: the log window now appears centered at the top of the visible area.

          Show
          svanoort Sam Van Oort added a comment - Verified and merged: the log window now appears centered at the top of the visible area.
          Hide
          svanoort Sam Van Oort added a comment -

          Released with v 1.4

          Show
          svanoort Sam Van Oort added a comment - Released with v 1.4

            People

            • Assignee:
              svanoort Sam Van Oort
              Reporter:
              asotobueno Alex Soto
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: