Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33188

Clean up pipeline-stage-view-poms

    Details

    • Similar Issues:

      Description

      • Switch to use 2.x parent pom (root `pom.xml` should contain no dependencies after)
      • For example, see https://github.com/jenkinsci/github-branch-source-plugin/pull/16
      • Remove `workflow-aggregator` dependency, at least in `compile` scope. For `test` scope, could keep it, or replace with a more selective list.
      • Remove the common deps, have the needful in the REST API, and then rely on that that to supply libraries for the UI
      • Declare `workflow-job` dep in `pipeline-rest-api` POM; optionally declare it in `pipeline-stage-view` POM
      • <description> fields need to be provided for the separate plugins, so the wiki is not used as a source for the description (since REST API and stage view share hosting and wiki)

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          pom.xml
          rest-api/pom.xml
          rest-api/src/main/resources/index.jelly
          ui/pom.xml
          http://jenkins-ci.org/commit/pipeline-stage-view-plugin/8a69569e0d6f6689bf8e2bb0fd3cd8d6e072003b
          Log:
          Most of the changes for JENKINS-33188

          Specifically fix plugin descriptions, use new parent pom, fix deps, fix versioning
          UI tests still fail due to httpclient version confict in dependencies

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: pom.xml rest-api/pom.xml rest-api/src/main/resources/index.jelly ui/pom.xml http://jenkins-ci.org/commit/pipeline-stage-view-plugin/8a69569e0d6f6689bf8e2bb0fd3cd8d6e072003b Log: Most of the changes for JENKINS-33188 Specifically fix plugin descriptions, use new parent pom, fix deps, fix versioning UI tests still fail due to httpclient version confict in dependencies
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          pom.xml
          rest-api/pom.xml
          rest-api/src/main/resources/index.jelly
          ui/pom.xml
          http://jenkins-ci.org/commit/pipeline-stage-view-plugin/37e3c1c4541b21a267b8172cc243f81e3538fc87
          Log:
          Merge pull request #1 from jenkinsci/pom-fixes

          Pom fixes for JENKINS-33188

          Compare: https://github.com/jenkinsci/pipeline-stage-view-plugin/compare/a9f6b62d5574...37e3c1c4541b

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: pom.xml rest-api/pom.xml rest-api/src/main/resources/index.jelly ui/pom.xml http://jenkins-ci.org/commit/pipeline-stage-view-plugin/37e3c1c4541b21a267b8172cc243f81e3538fc87 Log: Merge pull request #1 from jenkinsci/pom-fixes Pom fixes for JENKINS-33188 Compare: https://github.com/jenkinsci/pipeline-stage-view-plugin/compare/a9f6b62d5574...37e3c1c4541b
          Hide
          svanoort Sam Van Oort added a comment -
          Show
          svanoort Sam Van Oort added a comment - Reviewed and merged in https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/1
          Hide
          svanoort Sam Van Oort added a comment -

          Verified.

          Show
          svanoort Sam Van Oort added a comment - Verified.

            People

            • Assignee:
              svanoort Sam Van Oort
              Reporter:
              svanoort Sam Van Oort
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: