Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33246

It is unclear that the items with ** are dependencies during plugin install on 2.0

    Details

    • Similar Issues:

      Description

      When the plugin installed wizard is installing plugins, it shows a plugin in black and then it can have other plugins with ** in front that are grey. It is unclear that these grey plugins are the dependencies. There is also a lot of wasted whitespace area during this time as well. The whole area to the left of the installing list is just blank. More information could be provided in that space during install. Perhaps some tips on using Jenkins.

        Attachments

          Issue Links

            Activity

            slide_o_mix Alex Earl created issue -
            Hide
            danielbeck Daniel Beck added a comment -

            The absolute minimum here would be a tooltip on hover. It's not clear why dependencies, which are plugins after all, don't get a full "box" – would allow for a better progress indicator as well.

            Show
            danielbeck Daniel Beck added a comment - The absolute minimum here would be a tooltip on hover. It's not clear why dependencies, which are plugins after all, don't get a full "box" – would allow for a better progress indicator as well.
            danielbeck Daniel Beck made changes -
            Field Original Value New Value
            Labels 2.0 2.0 2.0-feedback
            danielbeck Daniel Beck made changes -
            Labels 2.0 2.0-feedback 2.0
            Hide
            hrmpw Patrick Wolf added a comment -

            I might be biased because of this ticket and seeing it before but I thought you could tell they were dependencies. Would that list overwhelm new users, Daniel Beck? That would create quite a few boxes.

            Although, the Mailer Plugin does have it's own box and when you view it on the Plugin Manager page it is shown as a dependency of several other plugins. This seems inconsistent.

            Show
            hrmpw Patrick Wolf added a comment - I might be biased because of this ticket and seeing it before but I thought you could tell they were dependencies. Would that list overwhelm new users, Daniel Beck ? That would create quite a few boxes. Although, the Mailer Plugin does have it's own box and when you view it on the Plugin Manager page it is shown as a dependency of several other plugins. This seems inconsistent.
            Hide
            danielbeck Daniel Beck added a comment -

            Well, they do get installed, and even shown on the side panel. If it were explicit about "Installing Foo plugin which is a dependency of Bar plugin, Baz plugin" that should be fine I think. We're showing dependencies on the selection list anyway.

            Although, the Mailer Plugin does have it's own box and when you view it on the Plugin Manager page it is shown as a dependency of several other plugins. This seems inconsistent.

            Not sure what you mean. A plugin can be both available for selection on the list at the beginning, and also be a dependency. What the list currently does not do is indicate which plugins in the list already get automatically installed because they're dependencies of another plugin that is checked – another minor RFE?

            Show
            danielbeck Daniel Beck added a comment - Well, they do get installed, and even shown on the side panel. If it were explicit about "Installing Foo plugin which is a dependency of Bar plugin, Baz plugin" that should be fine I think. We're showing dependencies on the selection list anyway. Although, the Mailer Plugin does have it's own box and when you view it on the Plugin Manager page it is shown as a dependency of several other plugins. This seems inconsistent. Not sure what you mean. A plugin can be both available for selection on the list at the beginning, and also be a dependency. What the list currently does not do is indicate which plugins in the list already get automatically installed because they're dependencies of another plugin that is checked – another minor RFE?
            Hide
            drulli Ulli Hafner added a comment -

            I would rather not show the dependencies in the new dialog: the dialog is especially for new users, they might get confused if there are now a lot of additional things that are going to be installed. (It's ok in the old dialog).

            I also would recommend to remove the dependencies tooltip in the selection dialog (or use an explicit action to show the dependencies).

            Show
            drulli Ulli Hafner added a comment - I would rather not show the dependencies in the new dialog: the dialog is especially for new users, they might get confused if there are now a lot of additional things that are going to be installed. (It's ok in the old dialog). I also would recommend to remove the dependencies tooltip in the selection dialog (or use an explicit action to show the dependencies).
            Hide
            orrc Christopher Orr added a comment - - edited

            I agree — I certainly found the dependency tooltop to be unnecessary.

            Show
            orrc Christopher Orr added a comment - - edited I agree — I certainly found the dependency tooltop to be unnecessary.
            Hide
            danielbeck Daniel Beck added a comment -

            FWIW dependency presentation is going to be changed a bit in a PR (https://github.com/jenkinsci/jenkins/pull/2009).

            Show
            danielbeck Daniel Beck added a comment - FWIW dependency presentation is going to be changed a bit in a PR ( https://github.com/jenkinsci/jenkins/pull/2009 ).
            Hide
            danielbeck Daniel Beck added a comment -

            Also, enjoy all the additional dependencies from JENKINS-33296. May be bad enough that we need to require fairly recent core dependencies for plugins in this dialog, otherwise they'd have giant dependency lists.

            Show
            danielbeck Daniel Beck added a comment - Also, enjoy all the additional dependencies from JENKINS-33296 . May be bad enough that we need to require fairly recent core dependencies for plugins in this dialog, otherwise they'd have giant dependency lists.
            Hide
            danielbeck Daniel Beck added a comment -

            I think alpha 3 changes the presentation of these dependencies a bit. Is it better now?

            Show
            danielbeck Daniel Beck added a comment - I think alpha 3 changes the presentation of these dependencies a bit. Is it better now?
            Hide
            slide_o_mix Alex Earl added a comment -

            The **'s during install are still there. See attachment for what I am describing.

            Show
            slide_o_mix Alex Earl added a comment - The **'s during install are still there. See attachment for what I am describing.
            slide_o_mix Alex Earl made changes -
            Attachment 2016-03-14 12_22_39-Jenkins.png [ 32165 ]
            Hide
            danielbeck Daniel Beck added a comment -

            Alex Earl (Somewhat unrelated) Are there no boxes in the grey area to the left of it at all? There should be one box per plugin you selected to be installed…

            Show
            danielbeck Daniel Beck added a comment - Alex Earl (Somewhat unrelated) Are there no boxes in the grey area to the left of it at all? There should be one box per plugin you selected to be installed…
            Hide
            slide_o_mix Alex Earl added a comment -

            There is NOTHING in the gray area to the left as is shown in the screenshot.

            Show
            slide_o_mix Alex Earl added a comment - There is NOTHING in the gray area to the left as is shown in the screenshot.
            danielbeck Daniel Beck made changes -
            Assignee Daniel Beck [ danielbeck ]
            danielbeck Daniel Beck made changes -
            Labels 2.0 2.0 2.0-planned
            danielbeck Daniel Beck made changes -
            Assignee Keith Zantow [ kzantow ]
            Hide
            danielbeck Daniel Beck added a comment -

            Keith Zantow I imagine it wouldn't be particularly difficult to add a message below the progress bar that explains that selected plugins and their dependencies are being installed, with a minor change to presentation in the list. WDYT?

            Show
            danielbeck Daniel Beck added a comment - Keith Zantow I imagine it wouldn't be particularly difficult to add a message below the progress bar that explains that selected plugins and their dependencies are being installed, with a minor change to presentation in the list. WDYT?
            Hide
            swashbuck1r Spike Washburn added a comment -

            Expectation: Describe what the indicator ** means. It should be clear what are dependencies of the user's selection.

            Planned approach to resolution:

            • Text description in console or somewhere around the console

            Not in scope:

            • Displaying the plugins that caused the install
            Show
            swashbuck1r Spike Washburn added a comment - Expectation: Describe what the indicator ** means. It should be clear what are dependencies of the user's selection. Planned approach to resolution: Text description in console or somewhere around the console Not in scope: Displaying the plugins that caused the install
            kzantow Keith Zantow made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            kzantow Keith Zantow made changes -
            Remote Link This issue links to "PR 2159 (Web Link)" [ 14102 ]
            Hide
            kzantow Keith Zantow added a comment -

            Daniel Beck I've added a sort of footnote section to the console log, please check the screenshot and PR https://github.com/jenkinsci/jenkins/pull/2159 to determine if this is sufficient. I believe the text should be around the console log (rather than elsewhere), as that's where the indicator is actually being used.

            Show
            kzantow Keith Zantow added a comment - Daniel Beck I've added a sort of footnote section to the console log, please check the screenshot and PR https://github.com/jenkinsci/jenkins/pull/2159 to determine if this is sufficient. I believe the text should be around the console log (rather than elsewhere), as that's where the indicator is actually being used.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: kzantow
            Path:
            core/src/main/resources/jenkins/install/pluginSetupWizard.properties
            war/src/main/js/pluginSetupWizardGui.js
            war/src/main/js/templates/progressPanel.hbs
            war/src/main/less/pluginSetupWizard.less
            http://jenkins-ci.org/commit/jenkins/9fbd7aa5170745f0e724031c4736d8da7a57b55e
            Log:
            JENKINS-33246 - add a footnote about required dependencies installing
            during setup wizard

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: kzantow Path: core/src/main/resources/jenkins/install/pluginSetupWizard.properties war/src/main/js/pluginSetupWizardGui.js war/src/main/js/templates/progressPanel.hbs war/src/main/less/pluginSetupWizard.less http://jenkins-ci.org/commit/jenkins/9fbd7aa5170745f0e724031c4736d8da7a57b55e Log: JENKINS-33246 - add a footnote about required dependencies installing during setup wizard
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/resources/jenkins/install/pluginSetupWizard.properties
            war/src/main/js/pluginSetupWizardGui.js
            war/src/main/js/templates/progressPanel.hbs
            war/src/main/less/pluginSetupWizard.less
            http://jenkins-ci.org/commit/jenkins/547f304b0b26a3627fe04d023cdad1a63475e5ed
            Log:
            Merge pull request #2159 from kzantow/JENKINS-33246-show-install-dependency-legend

            [FIX JENKINS-33246] Add a footnote about ** in setup wizard

            Compare: https://github.com/jenkinsci/jenkins/compare/5a9ac399d2f1...547f304b0b26

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/jenkins/install/pluginSetupWizard.properties war/src/main/js/pluginSetupWizardGui.js war/src/main/js/templates/progressPanel.hbs war/src/main/less/pluginSetupWizard.less http://jenkins-ci.org/commit/jenkins/547f304b0b26a3627fe04d023cdad1a63475e5ed Log: Merge pull request #2159 from kzantow/ JENKINS-33246 -show-install-dependency-legend [FIX JENKINS-33246] Add a footnote about ** in setup wizard Compare: https://github.com/jenkinsci/jenkins/compare/5a9ac399d2f1...547f304b0b26
            scm_issue_link SCM/JIRA link daemon made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 169133 ] JNJira + In-Review [ 198544 ]
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal OSS-643 (Web Link)" [ 18851 ]

              People

              • Assignee:
                kzantow Keith Zantow
                Reporter:
                slide_o_mix Alex Earl
              • Votes:
                0 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: