Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33384

PluginServletFilters should be let clean up before the Jenkins singleton is cleared

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The simple contract for plugins is that the Jenkins singleton should always be available on the master on any execution path that is available to code in a plugin's classloader.

      Arguably this is not needed as the plugins should be removing their filters, but where filters are registered via the @Extension mechanism this could not be guaranteed

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            core/src/main/java/hudson/util/PluginServletFilter.java
            core/src/main/java/jenkins/model/Jenkins.java
            http://jenkins-ci.org/commit/jenkins/abf9fd36582ce6277dec929e89f078678e587209
            Log:
            [FIXED JENKINS-33384] clean up the PluginServletFilter instances on Jenkins.cleanUp()

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/util/PluginServletFilter.java core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/abf9fd36582ce6277dec929e89f078678e587209 Log: [FIXED JENKINS-33384] clean up the PluginServletFilter instances on Jenkins.cleanUp()
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/hudson/util/PluginServletFilter.java
            core/src/main/java/jenkins/model/Jenkins.java
            http://jenkins-ci.org/commit/jenkins/bf9f68ce050a2a2a3996b488efadc00f0aca1d93
            Log:
            Merge pull request #2093 from stephenc/jenkins-33384

            [FIXED JENKINS-33384] clean up the PluginServletFilter instances on Jenkins.cleanUp()

            Compare: https://github.com/jenkinsci/jenkins/compare/d1dfbd2bafd4...bf9f68ce050a

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/util/PluginServletFilter.java core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/bf9f68ce050a2a2a3996b488efadc00f0aca1d93 Log: Merge pull request #2093 from stephenc/jenkins-33384 [FIXED JENKINS-33384] clean up the PluginServletFilter instances on Jenkins.cleanUp() Compare: https://github.com/jenkinsci/jenkins/compare/d1dfbd2bafd4...bf9f68ce050a
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4492
            [FIXED JENKINS-33384] clean up the PluginServletFilter instances on (Revision abf9fd36582ce6277dec929e89f078678e587209)

            Result = SUCCESS
            stephen connolly : abf9fd36582ce6277dec929e89f078678e587209
            Files :

            • core/src/main/java/jenkins/model/Jenkins.java
            • core/src/main/java/hudson/util/PluginServletFilter.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4492 [FIXED JENKINS-33384] clean up the PluginServletFilter instances on (Revision abf9fd36582ce6277dec929e89f078678e587209) Result = SUCCESS stephen connolly : abf9fd36582ce6277dec929e89f078678e587209 Files : core/src/main/java/jenkins/model/Jenkins.java core/src/main/java/hudson/util/PluginServletFilter.java
            Hide
            acoulton Andrew Coulton added a comment -

            Hi,

            It looks like the fix for this has introduced a bug that prevents Jenkins from restarting itself - see https://issues.jenkins-ci.org/browse/JENKINS-33681.

            Could you have a look?

            Show
            acoulton Andrew Coulton added a comment - Hi, It looks like the fix for this has introduced a bug that prevents Jenkins from restarting itself - see https://issues.jenkins-ci.org/browse/JENKINS-33681 . Could you have a look?
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            core/src/main/java/hudson/util/PluginServletFilter.java
            core/src/main/java/jenkins/model/Jenkins.java
            http://jenkins-ci.org/commit/jenkins/d72076c47e09c7e7b4f813ac603bb07bdb476283
            Log:
            [FIXED JENKINS-33384] clean up the PluginServletFilter instances on Jenkins.cleanUp()

            (cherry picked from commit abf9fd36582ce6277dec929e89f078678e587209)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/util/PluginServletFilter.java core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/d72076c47e09c7e7b4f813ac603bb07bdb476283 Log: [FIXED JENKINS-33384] clean up the PluginServletFilter instances on Jenkins.cleanUp() (cherry picked from commit abf9fd36582ce6277dec929e89f078678e587209)

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                stephenconnolly Stephen Connolly
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: