Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33445

GitScmSource does not return tags via retrieve method

    Details

    • Similar Issues:

      Description

      Currently the GitScmSource class does not expose tags in the list of branches that are returned via the retrieve method.

      This means that plugins which make use of this class are unable to build against specific tags, for example the multi-branch-plugin[1].

      [1] https://wiki.jenkins-ci.org/display/JENKINS/Multi-Branch+Project+Plugin

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
            src/main/java/jenkins/plugins/git/GitSCMSource.java
            src/main/java/jenkins/plugins/git/GitSCMSourceContext.java
            src/main/java/jenkins/plugins/git/GitSCMSourceRequest.java
            src/main/java/jenkins/plugins/git/traits/BranchDiscoveryTrait.java
            src/main/resources/jenkins/plugins/git/traits/BranchDiscoveryTrait/config.jelly
            src/main/resources/jenkins/plugins/git/traits/BranchDiscoveryTrait/help.html
            src/main/resources/jenkins/plugins/git/traits/Messages.properties
            src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java
            src/test/java/jenkins/plugins/git/GitSCMSourceTraitsTest.java
            src/test/resources/jenkins/plugins/git/GitSCMSourceTraitsTest/modern.xml
            src/test/resources/jenkins/plugins/git/GitSCMSourceTraitsTest/pimpped_out.xml
            http://jenkins-ci.org/commit/git-plugin/1c1c664d1a18c600443a3ffe66f2a30ec2bd47ef
            Log:
            JENKINS-43507 Give GitSCMSource a BranchDiscoveryTrait in preparation for JENKINS-33445

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSource.java src/main/java/jenkins/plugins/git/GitSCMSourceContext.java src/main/java/jenkins/plugins/git/GitSCMSourceRequest.java src/main/java/jenkins/plugins/git/traits/BranchDiscoveryTrait.java src/main/resources/jenkins/plugins/git/traits/BranchDiscoveryTrait/config.jelly src/main/resources/jenkins/plugins/git/traits/BranchDiscoveryTrait/help.html src/main/resources/jenkins/plugins/git/traits/Messages.properties src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java src/test/java/jenkins/plugins/git/GitSCMSourceTraitsTest.java src/test/resources/jenkins/plugins/git/GitSCMSourceTraitsTest/modern.xml src/test/resources/jenkins/plugins/git/GitSCMSourceTraitsTest/pimpped_out.xml http://jenkins-ci.org/commit/git-plugin/1c1c664d1a18c600443a3ffe66f2a30ec2bd47ef Log: JENKINS-43507 Give GitSCMSource a BranchDiscoveryTrait in preparation for JENKINS-33445
            Hide
            evildeece Alastair D'Silva added a comment -

            That's unfortunate, there's a fairly long list of PRs that are bitrotting. Is there anything we can do to help move things along? (like reviewing some of the pending PRs)

            Show
            evildeece Alastair D'Silva added a comment - That's unfortunate, there's a fairly long list of PRs that are bitrotting. Is there anything we can do to help move things along? (like reviewing some of the pending PRs)
            Hide
            markewaite Mark Waite added a comment -

            I won't evaluate that pull request for several months at least. I'm evaluating git large file support currently, then plan to focus on two regressions related to renamed submodules, then plan to evaluate pull requests for authentication improvements.

            Show
            markewaite Mark Waite added a comment - I won't evaluate that pull request for several months at least. I'm evaluating git large file support currently, then plan to focus on two regressions related to renamed submodules, then plan to evaluate pull requests for authentication improvements.
            Hide
            evildeece Alastair D'Silva added a comment -
            Show
            evildeece Alastair D'Silva added a comment - Ping Mark Waite
            Hide
            evildeece Alastair D'Silva added a comment -
            Show
            evildeece Alastair D'Silva added a comment - A later optimisation requires https://github.com/jenkinsci/git-client-plugin/pull/234
            Hide
            evildeece Alastair D'Silva added a comment -

            Fixed by pull request #407

            Show
            evildeece Alastair D'Silva added a comment - Fixed by pull request #407

              People

              • Assignee:
                Unassigned
                Reporter:
                csmart Chris Smart
              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: