Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33467

CauseAction.causes can become huge

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      If you have some tool constantly pinging jobs/.../build?token=... but the job is stuck in the queue for a long time, you will get a CauseAction with a potentially unbounded number of causes, all identical RemoteCause instances. In a system with tens of thousands of build records loaded, there can be millions of such causes. This is a waste of heap space (and disk space, disk I/O time to load).

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Robert Sandell
            Path:
            src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java
            http://jenkins-ci.org/commit/gerrit-trigger-plugin/f1a6a398ba1cf1f1f1ce1fb48e84a437ec3fb3bb
            Log:
            Merge pull request #278 from jenkinsci/JENKINS-33467

            Don't crash because JENKINS-33467 has changed expected behaviour

            Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/b7ab5892c183...f1a6a398ba1c

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Robert Sandell Path: src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/f1a6a398ba1cf1f1f1ce1fb48e84a437ec3fb3bb Log: Merge pull request #278 from jenkinsci/ JENKINS-33467 Don't crash because JENKINS-33467 has changed expected behaviour Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/b7ab5892c183...f1a6a398ba1c
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/CauseAction.java
            test/src/test/java/hudson/model/QueueTest.java
            http://jenkins-ci.org/commit/jenkins/916e759f576fd9aec7eb563f71f6541ceb37f641
            Log:
            [FIXED JENKINS-33467] Do not store redundant copies of Cause in CauseAction.
            (cherry picked from commit 6ae54add5dd3f171cf7cca820ca2e5443ae34b14)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/CauseAction.java test/src/test/java/hudson/model/QueueTest.java http://jenkins-ci.org/commit/jenkins/916e759f576fd9aec7eb563f71f6541ceb37f641 Log: [FIXED JENKINS-33467] Do not store redundant copies of Cause in CauseAction. (cherry picked from commit 6ae54add5dd3f171cf7cca820ca2e5443ae34b14)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/CauseAction.java
            http://jenkins-ci.org/commit/jenkins/63886be9f75c6f538b9401d9cb445b701b1f017c
            Log:
            JENKINS-33467 Clarifying that CauseAction.getCauses is immutable and you should construct the action with the causes you want.
            (cherry picked from commit 4adee7597aad7a338db8d3eb320575ae618a8c81)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/CauseAction.java http://jenkins-ci.org/commit/jenkins/63886be9f75c6f538b9401d9cb445b701b1f017c Log: JENKINS-33467 Clarifying that CauseAction.getCauses is immutable and you should construct the action with the causes you want. (cherry picked from commit 4adee7597aad7a338db8d3eb320575ae618a8c81)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Dan Alvizu
            Path:
            src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java
            http://jenkins-ci.org/commit/build-pipeline-plugin/27e234d2f1b8c86e28465d6a2d8ace5db9c7d778
            Log:
            Fixed JENKINS-33935

            Jenkins core made CauseAction.getCauses an unmodifiable collection
            (JENKINS-33467) - so we need to make a copy.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dan Alvizu Path: src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java http://jenkins-ci.org/commit/build-pipeline-plugin/27e234d2f1b8c86e28465d6a2d8ace5db9c7d778 Log: Fixed JENKINS-33935 Jenkins core made CauseAction.getCauses an unmodifiable collection ( JENKINS-33467 ) - so we need to make a copy.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            core/src/main/java/hudson/model/CauseAction.java
            http://jenkins-ci.org/commit/jenkins/d53cab3ef68b62a4a6dbb247012577c338dfc133
            Log:
            JENKINS-33467 Adjust reported Jenkins version number for LTS

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/model/CauseAction.java http://jenkins-ci.org/commit/jenkins/d53cab3ef68b62a4a6dbb247012577c338dfc133 Log: JENKINS-33467 Adjust reported Jenkins version number for LTS

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: