Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33498

Improve full screen view of pipeline stage view

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Even in full screen mode, the pipeline stage view is pretty small. It takes about 40% of the screen. Can you make it take up more screen real estate, maybe based on the number of stages in the pipeline?

        Attachments

          Issue Links

            Activity

            Hide
            svanoort Sam Van Oort added a comment -

            John Ament The idea here is that you can see more stages onscreen without needing to scroll right (a common issue for very complex builds with many stages) – it's covering this:

            Can you make it take up more screen real estate, maybe based on the number of stages in the pipeline

            In my opinion, we don't gain much just by stretching the stages wider arbitrarily... but there might be value in allowing them to grow and shrink a bit if they have content that can use the screen real-estate.

            I think that should be treated as a separate RFE though because it requires more significant CSS layout changes in multiple changes, and needs testing under a variety of circumstances.

            As starting points:
            https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/js/view/templates/pipeline-staged.less#L239

            This sets the width of table cells (even if max-width is set, they don't grow).

            This sets the overall width of the table cells in view, as does the line below it:
            https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/js/view/templates/pipeline-staged.hbs#L4

            Which is unfortunately hardcoded in JS to give 10em to each stage:
            https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/js/view/pipeline-staged.js#L60

            Show
            svanoort Sam Van Oort added a comment - John Ament The idea here is that you can see more stages onscreen without needing to scroll right (a common issue for very complex builds with many stages) – it's covering this: Can you make it take up more screen real estate, maybe based on the number of stages in the pipeline In my opinion, we don't gain much just by stretching the stages wider arbitrarily... but there might be value in allowing them to grow and shrink a bit if they have content that can use the screen real-estate. I think that should be treated as a separate RFE though because it requires more significant CSS layout changes in multiple changes, and needs testing under a variety of circumstances. As starting points: https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/js/view/templates/pipeline-staged.less#L239 This sets the width of table cells (even if max-width is set, they don't grow). This sets the overall width of the table cells in view, as does the line below it: https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/js/view/templates/pipeline-staged.hbs#L4 Which is unfortunately hardcoded in JS to give 10em to each stage: https://github.com/jenkinsci/pipeline-stage-view-plugin/blob/master/ui/src/main/js/view/pipeline-staged.js#L60
            Hide
            klamb Ken Lamb added a comment -

            FWIW: I would like this ability as well.

            Currently, I have long stage names that stretch the stages to the right where they get cut off and I have to scroll.

            Meanwhile, if the page is being displayed in full screen mode, half of the screen is blank next to the stage view. Rather than scrolling right, it would be nice if the screen view would just use all of that real estate.

            Show
            klamb Ken Lamb added a comment - FWIW: I would like this ability as well. Currently, I have long stage names that stretch the stages to the right where they get cut off and I have to scroll. Meanwhile, if the page is being displayed in full screen mode, half of the screen is blank next to the stage view. Rather than scrolling right, it would be nice if the screen view would just use all of that real estate.
            Hide
            svanoort Sam Van Oort added a comment -

            John Ament and Ken Lamb I agree that it would have value to support dynamic column widths, however I think due to the complexity of the layout change that's probably out of scope for the original JIRA. I've created JENKINS-35252 for layout redesigns as a separate RFE - let's move discussion there.

            Show
            svanoort Sam Van Oort added a comment - John Ament and Ken Lamb I agree that it would have value to support dynamic column widths, however I think due to the complexity of the layout change that's probably out of scope for the original JIRA. I've created JENKINS-35252 for layout redesigns as a separate RFE - let's move discussion there.
            Hide
            svanoort Sam Van Oort added a comment -

            This was released with v1.4 - discussion of a full layout redesign to do dynamic sizing of columns is moving to separate JIRA to facilitate tracking.

            Show
            svanoort Sam Van Oort added a comment - This was released with v1.4 - discussion of a full layout redesign to do dynamic sizing of columns is moving to separate JIRA to facilitate tracking.
            Hide
            svanoort Sam Van Oort added a comment -

            Closing b/c in release.

            Show
            svanoort Sam Van Oort added a comment - Closing b/c in release.

              People

              • Assignee:
                svanoort Sam Van Oort
                Reporter:
                johndament John Ament
              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: