Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33559

Job configuration "search" box doesn't properly clear highlights

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      (setting aside my view that this search box is superfluous)

      When you search for something on the page, e.g. "CVS", the view will scroll to the element and highlight the search query on the page.

      When the search field is cleared, the highlight remains, see attached screenshot.

        Attachments

          Issue Links

            Activity

            rtyler R. Tyler Croy created issue -
            Hide
            danielbeck Daniel Beck added a comment -

            The box will get removed soon, it's kind of useless for scroll-spying anyway.

            Show
            danielbeck Daniel Beck added a comment - The box will get removed soon, it's kind of useless for scroll-spying anyway.
            Hide
            danielbeck Daniel Beck added a comment -

            Asking Tom FENNELLY for confirmation on the above.

            Show
            danielbeck Daniel Beck added a comment - Asking Tom FENNELLY for confirmation on the above.
            danielbeck Daniel Beck made changes -
            Field Original Value New Value
            Labels 2.0 2.0 2.0-planned
            danielbeck Daniel Beck made changes -
            Assignee Tom FENNELLY [ tfennelly ]
            Hide
            tfennelly Tom FENNELLY added a comment -

            Yes, that is a bug and is fixed in https://github.com/jenkinsci/jenkins/pull/2121.

            I also agree that the find feature is not so useful with scrollspy since the user can use cmd+f anyway. Maybe we should juts remove it for scrollspy.

            Show
            tfennelly Tom FENNELLY added a comment - Yes, that is a bug and is fixed in https://github.com/jenkinsci/jenkins/pull/2121 . I also agree that the find feature is not so useful with scrollspy since the user can use cmd+f anyway. Maybe we should juts remove it for scrollspy.
            Hide
            amuniz Antonio Muñiz added a comment -

            Is this bug related to JENKINS-33620 (or can they be fixed at the same time?)

            Show
            amuniz Antonio Muñiz added a comment - Is this bug related to JENKINS-33620 (or can they be fixed at the same time?)
            Hide
            amuniz Antonio Muñiz added a comment -

            Well, if the search box is removed then both issue would become out-dated.

            Show
            amuniz Antonio Muñiz added a comment - Well, if the search box is removed then both issue would become out-dated.
            Hide
            kohsuke Kohsuke Kawaguchi added a comment -

            Sounds like the consensus is that this issue should be closed because of the change made since then.

            Show
            kohsuke Kohsuke Kawaguchi added a comment - Sounds like the consensus is that this issue should be closed because of the change made since then.
            Hide
            kohsuke Kohsuke Kawaguchi added a comment -

            Based on the comments that this feature is soon to be removed.

            Show
            kohsuke Kohsuke Kawaguchi added a comment - Based on the comments that this feature is soon to be removed.
            kohsuke Kohsuke Kawaguchi made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Won't Do [ 10001 ]
            Hide
            swashbuck1r Spike Washburn added a comment -

            Gus is planning to remove this in PR-2117

            Show
            swashbuck1r Spike Washburn added a comment - Gus is planning to remove this in PR-2117
            swashbuck1r Spike Washburn made changes -
            Assignee Tom FENNELLY [ tfennelly ] gus reiber [ gusreiber ]
            swashbuck1r Spike Washburn made changes -
            Assignee gus reiber [ gusreiber ] Tom FENNELLY [ tfennelly ]
            amuniz Antonio Muñiz made changes -
            Link This issue is related to JENKINS-33620 [ JENKINS-33620 ]
            Hide
            tfennelly Tom FENNELLY added a comment -

            The search box has already been removed for scrollspy and is in the 2.0 codebase. The original bug was also fixed, but as said, that's not relevant for scrollspy.

            Show
            tfennelly Tom FENNELLY added a comment - The search box has already been removed for scrollspy and is in the 2.0 codebase. The original bug was also fixed, but as said, that's not relevant for scrollspy.
            Hide
            tfennelly Tom FENNELLY added a comment -

            I've been reviewing PR-2117 and its really a different thing i.e. not related to config pages.

            It does share a lot of the same CSS though and should look the same from the users perspective. There's probably more refactoring we can do on the js widgets to break out more common components, but that's probably a different days work.

            Show
            tfennelly Tom FENNELLY added a comment - I've been reviewing PR-2117 and its really a different thing i.e. not related to config pages. It does share a lot of the same CSS though and should look the same from the users perspective. There's probably more refactoring we can do on the js widgets to break out more common components, but that's probably a different days work.
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 169505 ] JNJira + In-Review [ 198619 ]

              People

              • Assignee:
                tfennelly Tom FENNELLY
                Reporter:
                rtyler R. Tyler Croy
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: