Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33564

Sections of "Git" SCM configuration can be X'd out but not restored

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: git-plugin
    • Labels:
      None
    • Environment:
      2.0-alpha3
    • Similar Issues:

      Description

      There are a couple sections in the Git SCM configuration that have a red "X" button in them. When you click those red Xs the sections disappear and there is no way to recover them past reloading the page.

      Switching the radio buttons around doesn't appear to bring the UI elements back either

        Attachments

        1. git-scm-1.png
          git-scm-1.png
          44 kB
        2. git-scm-2.png
          git-scm-2.png
          22 kB
        3. jenkins1_git.png
          jenkins1_git.png
          39 kB

          Issue Links

            Activity

            rtyler R. Tyler Croy created issue -
            danielbeck Daniel Beck made changes -
            Field Original Value New Value
            Priority Minor [ 4 ] Critical [ 2 ]
            danielbeck Daniel Beck made changes -
            Assignee gus reiber [ gusreiber ]
            Hide
            danielbeck Daniel Beck added a comment -

            gus reiber PTAL at this.

            Show
            danielbeck Daniel Beck added a comment - gus reiber PTAL at this.
            danielbeck Daniel Beck made changes -
            Labels 2.0 2.0 2.0-planned
            Hide
            gusreiber gus reiber added a comment -

            yup.
            I think it will need to wait for the merge traffic jam. But yup. Top of the list.

            Show
            gusreiber gus reiber added a comment - yup. I think it will need to wait for the merge traffic jam. But yup. Top of the list.
            gusreiber gus reiber made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            gusreiber gus reiber added a comment -

            I agree that this is a critical issue, and although I haven't seen it, likely blocks 2.0.
            Don't think much can be done about it until 31162 is merged.

            ...so critical, yes. Blocking, probability, but I think it is work that has to be serialized and it isn't quite first.

            Show
            gusreiber gus reiber added a comment - I agree that this is a critical issue, and although I haven't seen it, likely blocks 2.0. Don't think much can be done about it until 31162 is merged. ...so critical, yes. Blocking, probability, but I think it is work that has to be serialized and it isn't quite first.
            Hide
            gusreiber gus reiber added a comment -

            So this is a bug with the git plugin not the new UI: http://jenkins.beedemo.net/api-team/job/sandbox/job/FreeGit/configure

            Show
            gusreiber gus reiber added a comment - So this is a bug with the git plugin not the new UI: http://jenkins.beedemo.net/api-team/job/sandbox/job/FreeGit/configure
            Hide
            gusreiber gus reiber added a comment -

            this behavior is wrong, but it is the plugin behavior.

            Show
            gusreiber gus reiber added a comment - this behavior is wrong, but it is the plugin behavior.
            gusreiber gus reiber made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Not A Defect [ 7 ]
            Hide
            rtyler R. Tyler Croy added a comment -

            gus reiber the link you cite is behind an authentication wall, so I'm not entirely sure what you're attempting to show there.

            I've attached a screenshot from 1.652 and it appears that my confusion in the new UI was that the "Delete Repository" and "Delete Branch" become new "{x]" buttons.

            I agree with gus reiber's assessment that this isn't a bug with the new job configuration UI, but I disagree in that I still believe this to be a bug. for the Git plugin. I've updated the ticket accordingly.

            Show
            rtyler R. Tyler Croy added a comment - gus reiber the link you cite is behind an authentication wall, so I'm not entirely sure what you're attempting to show there. I've attached a screenshot from 1.652 and it appears that my confusion in the new UI was that the "Delete Repository" and "Delete Branch" become new "{x]" buttons. I agree with gus reiber 's assessment that this isn't a bug with the new job configuration UI, but I disagree in that I still believe this to be a bug. for the Git plugin. I've updated the ticket accordingly.
            rtyler R. Tyler Croy made changes -
            Component/s git-plugin [ 15543 ]
            Component/s core [ 15593 ]
            Priority Critical [ 2 ] Minor [ 4 ]
            Labels 2.0 2.0-planned
            Attachment jenkins1_git.png [ 32243 ]
            Assignee gus reiber [ gusreiber ] Mark Waite [ markewaite ]
            rtyler R. Tyler Croy made changes -
            Resolution Not A Defect [ 7 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            Hide
            markewaite Mark Waite added a comment - - edited

            Please roll your git plugin version back to 2.4.2. There is a bug reported in 2.4.3 that certain configurations are not preserved. It appears that my attempt to fix findbugs warnings in 2.4.3 had a very bad side effect of damaging the configuration load / store process. Refer to JENKINS-33695 for more information on the specific issue that was visible in 2.4.3 and not visible in 2.4.2.

            Show
            markewaite Mark Waite added a comment - - edited Please roll your git plugin version back to 2.4.2. There is a bug reported in 2.4.3 that certain configurations are not preserved. It appears that my attempt to fix findbugs warnings in 2.4.3 had a very bad side effect of damaging the configuration load / store process. Refer to JENKINS-33695 for more information on the specific issue that was visible in 2.4.3 and not visible in 2.4.2.
            markewaite Mark Waite made changes -
            Link This issue is related to JENKINS-33695 [ JENKINS-33695 ]
            Hide
            markewaite Mark Waite added a comment -

            Fixed in git plugin 2.4.4, released 24 Mar 2016

            Show
            markewaite Mark Waite added a comment - Fixed in git plugin 2.4.4, released 24 Mar 2016
            markewaite Mark Waite made changes -
            Status Reopened [ 4 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            markewaite Mark Waite made changes -
            Link This issue is related to JENKINS-33811 [ JENKINS-33811 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 169510 ] JNJira + In-Review [ 198621 ]
            markewaite Mark Waite made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                markewaite Mark Waite
                Reporter:
                rtyler R. Tyler Croy
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: