Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33623

Proxy wildcard list not checking against hostname only

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The latest version of the GitHub Branch Source plugin appears to have added some logic to use the Jenkins proxy configuration as part of the request caching logic. I have a proxy configured on my Jenkins server so that it can download plugins, but for internal sites the proxy is not required (and actually doesn't work). In order to get the new plugin version to properly ping my GitHub Enterprise instance, I had to modify my exclusion list and add a wildcard to the end of the hostname as well - *.<company>.com*. From looking through some of the code, it appears that the full URL is being passed to the createProxy(string host) function instead of passing only the hostname.

      I supposed this could also be corrected by having the createProxy function try to extract out the hostname if it appears that a full URL was passed, but that function appears to have existed for a while without problems, so it seems that the fix probably belongs in this plugin.

        Attachments

          Issue Links

            Activity

            Show
            schulzha Hans Schulz added a comment - Fixed with https://github.com/jenkinsci/github-branch-source-plugin/pull/48
            Hide
            recena Manuel Recena Soto added a comment -

            The PR is still open.

            Show
            recena Manuel Recena Soto added a comment - The PR is still open.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Manuel Recena
            Path:
            src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java
            http://jenkins-ci.org/commit/github-branch-source-plugin/b20d0ca1d2e2c52fcd4727587e0bc9fcf205e020
            Log:
            JENKINS-33623 Proxy configured in a wrong way (#58)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/org/jenkinsci/plugins/github_branch_source/Connector.java http://jenkins-ci.org/commit/github-branch-source-plugin/b20d0ca1d2e2c52fcd4727587e0bc9fcf205e020 Log: JENKINS-33623 Proxy configured in a wrong way (#58)

              People

              • Assignee:
                schulzha Hans Schulz
                Reporter:
                andne Andy Neebel
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: