Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33663

Upgrade wizard step #1: recommended plugin installation

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The real meat of JENKINS-33568. See the plan for more details.

      Not actually targeted for 2.0 GA but adding that label to track this on radar.

        Attachments

          Issue Links

            Activity

            Hide
            rsandell rsandell added a comment -

            Whatever is in the RC now irritated me extremely. I upgraded from 1.55x and when it came back up the banner prompted me to "finish the installation" or similar wording. When I clicked on it Jenkins installed a bunch of plugins without warning. That is unacceptable behaviour in my book!
            At least it should prompt me with something like "Hey, I see you are missing these recommended plugins, would you like to install them?" And give me the option to say "No, don't pollute my finely crafted installation!"

            Show
            rsandell rsandell added a comment - Whatever is in the RC now irritated me extremely. I upgraded from 1.55x and when it came back up the banner prompted me to "finish the installation" or similar wording. When I clicked on it Jenkins installed a bunch of plugins without warning. That is unacceptable behaviour in my book! At least it should prompt me with something like "Hey, I see you are missing these recommended plugins, would you like to install them?" And give me the option to say "No, don't pollute my finely crafted installation!"
            Hide
            kzantow Keith Zantow added a comment -

            Daniel Beck R. Tyler Croy - I'd appreciate if you could review this upgrade wizard, I assume you'll like to make some text changes at least. Thanks!

            Show
            kzantow Keith Zantow added a comment - Daniel Beck R. Tyler Croy - I'd appreciate if you could review this upgrade wizard, I assume you'll like to make some text changes at least. Thanks!
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            I've decoupled plugin suggestions to a separate issue: JENKINS-33663

            Show
            oleg_nenashev Oleg Nenashev added a comment - I've decoupled plugin suggestions to a separate issue: JENKINS-33663
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: kzantow
            Path:
            core/src/main/java/hudson/PluginManager.java
            core/src/main/java/jenkins/install/InstallState.java
            core/src/main/java/jenkins/install/InstallStateFilter.java
            core/src/main/java/jenkins/install/InstallUtil.java
            core/src/main/java/jenkins/install/SetupWizard.java
            core/src/main/java/jenkins/install/UpgradeWizard.java
            core/src/main/java/jenkins/model/Jenkins.java
            core/src/main/resources/hudson/security/GlobalSecurityConfiguration/index.groovy
            core/src/main/resources/jenkins/install/SetupWizard/authenticate-security-token.jelly
            core/src/main/resources/jenkins/install/SetupWizard/client-scripts.jelly
            core/src/main/resources/jenkins/install/SetupWizard/footer.jelly
            core/src/main/resources/jenkins/install/SetupWizard/index.jelly
            core/src/main/resources/jenkins/install/SetupWizard/wizard-ui.jelly
            core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts.jelly
            core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts.properties
            core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts_fr.properties
            core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts_lt.properties
            core/src/main/resources/jenkins/install/UpgradeWizard/footer.jelly
            core/src/main/resources/jenkins/install/UpgradeWizard/footer.properties
            core/src/main/resources/jenkins/install/UpgradeWizard/footer_fr.properties
            core/src/main/resources/jenkins/install/UpgradeWizard/footer_lt.properties
            core/src/main/resources/jenkins/install/pluginSetupWizard.properties
            core/src/main/resources/jenkins/model/Jenkins/login.jelly
            core/src/main/resources/jenkins/model/Jenkins/loginError.jelly
            core/src/main/resources/lib/layout/html.jelly
            test/src/test/java/jenkins/install/InstallUtilTest.java
            test/src/test/java/jenkins/install/SetupWizardTest.java
            test/src/test/java/jenkins/install/UpgradeWizardTest.java
            test/src/test/java/jenkins/util/SystemPropertiesTest.java
            war/gulpfile.js
            war/src/main/js/api/pluginManager.js
            war/src/main/js/pluginSetupWizardGui.js
            war/src/main/js/templates/pluginSelectList.hbs
            war/src/main/js/templates/pluginSelectionPanel.hbs
            war/src/main/js/templates/successPanel.hbs
            war/src/main/js/templates/upgradePanel.hbs
            war/src/main/js/templates/upgradeSkippedPanel.hbs
            war/src/main/js/templates/upgradeSuccessPanel.hbs
            war/src/main/js/upgradeWizard.js
            war/src/main/js/util/jenkins.js
            war/src/main/less/pluginSetupWizard.less
            war/src/main/webapp/WEB-INF/web.xml
            war/src/main/webapp/css/style.css
            war/src/test/js/pluginSetupWizard-spec.js
            http://jenkins-ci.org/commit/jenkins/89a24abcb0eabc36c7281979d1620c92b6a128a9
            Log:
            [FIX JENKINS-33663] - Upgrade wizard

            Add Upgrade Wizard
            Add 'replace' handlebars method in jenkins.js
            Fix state transitions to follow a single basic pattern
            Suggested plugins selected by default
            Add an install state for INITIAL_SECURITY_SETUP
            Removed duplicate setupWizard.js on page [FIX JENKINS-34676]
            Exclude plugins which are already installed when determining platform
            Change 'snooze' to not look like a 'close' button
            Make sure unlock screen doesn't show up after new install
            Add compatibility check when offering suggested plugins
            More appropriate handling of security token filter

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: kzantow Path: core/src/main/java/hudson/PluginManager.java core/src/main/java/jenkins/install/InstallState.java core/src/main/java/jenkins/install/InstallStateFilter.java core/src/main/java/jenkins/install/InstallUtil.java core/src/main/java/jenkins/install/SetupWizard.java core/src/main/java/jenkins/install/UpgradeWizard.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/hudson/security/GlobalSecurityConfiguration/index.groovy core/src/main/resources/jenkins/install/SetupWizard/authenticate-security-token.jelly core/src/main/resources/jenkins/install/SetupWizard/client-scripts.jelly core/src/main/resources/jenkins/install/SetupWizard/footer.jelly core/src/main/resources/jenkins/install/SetupWizard/index.jelly core/src/main/resources/jenkins/install/SetupWizard/wizard-ui.jelly core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts.jelly core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts.properties core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts_fr.properties core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts_lt.properties core/src/main/resources/jenkins/install/UpgradeWizard/footer.jelly core/src/main/resources/jenkins/install/UpgradeWizard/footer.properties core/src/main/resources/jenkins/install/UpgradeWizard/footer_fr.properties core/src/main/resources/jenkins/install/UpgradeWizard/footer_lt.properties core/src/main/resources/jenkins/install/pluginSetupWizard.properties core/src/main/resources/jenkins/model/Jenkins/login.jelly core/src/main/resources/jenkins/model/Jenkins/loginError.jelly core/src/main/resources/lib/layout/html.jelly test/src/test/java/jenkins/install/InstallUtilTest.java test/src/test/java/jenkins/install/SetupWizardTest.java test/src/test/java/jenkins/install/UpgradeWizardTest.java test/src/test/java/jenkins/util/SystemPropertiesTest.java war/gulpfile.js war/src/main/js/api/pluginManager.js war/src/main/js/pluginSetupWizardGui.js war/src/main/js/templates/pluginSelectList.hbs war/src/main/js/templates/pluginSelectionPanel.hbs war/src/main/js/templates/successPanel.hbs war/src/main/js/templates/upgradePanel.hbs war/src/main/js/templates/upgradeSkippedPanel.hbs war/src/main/js/templates/upgradeSuccessPanel.hbs war/src/main/js/upgradeWizard.js war/src/main/js/util/jenkins.js war/src/main/less/pluginSetupWizard.less war/src/main/webapp/WEB-INF/web.xml war/src/main/webapp/css/style.css war/src/test/js/pluginSetupWizard-spec.js http://jenkins-ci.org/commit/jenkins/89a24abcb0eabc36c7281979d1620c92b6a128a9 Log: [FIX JENKINS-33663] - Upgrade wizard Add Upgrade Wizard Add 'replace' handlebars method in jenkins.js Fix state transitions to follow a single basic pattern Suggested plugins selected by default Add an install state for INITIAL_SECURITY_SETUP Removed duplicate setupWizard.js on page [FIX JENKINS-34676] Exclude plugins which are already installed when determining platform Change 'snooze' to not look like a 'close' button Make sure unlock screen doesn't show up after new install Add compatibility check when offering suggested plugins More appropriate handling of security token filter
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Keith Zantow
            Path:
            core/src/main/java/hudson/PluginManager.java
            core/src/main/java/jenkins/install/InstallState.java
            core/src/main/java/jenkins/install/InstallStateFilter.java
            core/src/main/java/jenkins/install/InstallUtil.java
            core/src/main/java/jenkins/install/SetupWizard.java
            core/src/main/java/jenkins/install/UpgradeWizard.java
            core/src/main/java/jenkins/model/Jenkins.java
            core/src/main/resources/hudson/security/GlobalSecurityConfiguration/index.groovy
            core/src/main/resources/jenkins/install/SetupWizard/authenticate-security-token.jelly
            core/src/main/resources/jenkins/install/SetupWizard/client-scripts.jelly
            core/src/main/resources/jenkins/install/SetupWizard/footer.jelly
            core/src/main/resources/jenkins/install/SetupWizard/index.jelly
            core/src/main/resources/jenkins/install/SetupWizard/wizard-ui.jelly
            core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts.jelly
            core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts.properties
            core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts_fr.properties
            core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts_lt.properties
            core/src/main/resources/jenkins/install/UpgradeWizard/footer.jelly
            core/src/main/resources/jenkins/install/UpgradeWizard/footer.properties
            core/src/main/resources/jenkins/install/UpgradeWizard/footer_fr.properties
            core/src/main/resources/jenkins/install/UpgradeWizard/footer_lt.properties
            core/src/main/resources/jenkins/install/pluginSetupWizard.properties
            core/src/main/resources/jenkins/model/Jenkins/login.jelly
            core/src/main/resources/jenkins/model/Jenkins/loginError.jelly
            core/src/main/resources/lib/layout/html.jelly
            test/src/test/java/jenkins/install/InstallUtilTest.java
            test/src/test/java/jenkins/install/SetupWizardTest.java
            test/src/test/java/jenkins/install/UpgradeWizardTest.java
            test/src/test/java/jenkins/util/SystemPropertiesTest.java
            war/gulpfile.js
            war/src/main/js/api/pluginManager.js
            war/src/main/js/pluginSetupWizardGui.js
            war/src/main/js/templates/pluginSelectList.hbs
            war/src/main/js/templates/pluginSelectionPanel.hbs
            war/src/main/js/templates/successPanel.hbs
            war/src/main/js/templates/upgradePanel.hbs
            war/src/main/js/templates/upgradeSkippedPanel.hbs
            war/src/main/js/templates/upgradeSuccessPanel.hbs
            war/src/main/js/upgradeWizard.js
            war/src/main/js/util/jenkins.js
            war/src/main/less/pluginSetupWizard.less
            war/src/main/webapp/WEB-INF/web.xml
            war/src/main/webapp/css/style.css
            war/src/test/js/pluginSetupWizard-spec.js
            http://jenkins-ci.org/commit/jenkins/20cb8fdde819ab6a00140f6c987bb9dddaff7483
            Log:
            Merge pull request #2281 from kzantow/JENKINS-33663-upgrade-wizard

            JENKINS-33663 - Upgrade wizard

            Compare: https://github.com/jenkinsci/jenkins/compare/74d0412d74a6...20cb8fdde819

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Keith Zantow Path: core/src/main/java/hudson/PluginManager.java core/src/main/java/jenkins/install/InstallState.java core/src/main/java/jenkins/install/InstallStateFilter.java core/src/main/java/jenkins/install/InstallUtil.java core/src/main/java/jenkins/install/SetupWizard.java core/src/main/java/jenkins/install/UpgradeWizard.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/hudson/security/GlobalSecurityConfiguration/index.groovy core/src/main/resources/jenkins/install/SetupWizard/authenticate-security-token.jelly core/src/main/resources/jenkins/install/SetupWizard/client-scripts.jelly core/src/main/resources/jenkins/install/SetupWizard/footer.jelly core/src/main/resources/jenkins/install/SetupWizard/index.jelly core/src/main/resources/jenkins/install/SetupWizard/wizard-ui.jelly core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts.jelly core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts.properties core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts_fr.properties core/src/main/resources/jenkins/install/UpgradeWizard/client-scripts_lt.properties core/src/main/resources/jenkins/install/UpgradeWizard/footer.jelly core/src/main/resources/jenkins/install/UpgradeWizard/footer.properties core/src/main/resources/jenkins/install/UpgradeWizard/footer_fr.properties core/src/main/resources/jenkins/install/UpgradeWizard/footer_lt.properties core/src/main/resources/jenkins/install/pluginSetupWizard.properties core/src/main/resources/jenkins/model/Jenkins/login.jelly core/src/main/resources/jenkins/model/Jenkins/loginError.jelly core/src/main/resources/lib/layout/html.jelly test/src/test/java/jenkins/install/InstallUtilTest.java test/src/test/java/jenkins/install/SetupWizardTest.java test/src/test/java/jenkins/install/UpgradeWizardTest.java test/src/test/java/jenkins/util/SystemPropertiesTest.java war/gulpfile.js war/src/main/js/api/pluginManager.js war/src/main/js/pluginSetupWizardGui.js war/src/main/js/templates/pluginSelectList.hbs war/src/main/js/templates/pluginSelectionPanel.hbs war/src/main/js/templates/successPanel.hbs war/src/main/js/templates/upgradePanel.hbs war/src/main/js/templates/upgradeSkippedPanel.hbs war/src/main/js/templates/upgradeSuccessPanel.hbs war/src/main/js/upgradeWizard.js war/src/main/js/util/jenkins.js war/src/main/less/pluginSetupWizard.less war/src/main/webapp/WEB-INF/web.xml war/src/main/webapp/css/style.css war/src/test/js/pluginSetupWizard-spec.js http://jenkins-ci.org/commit/jenkins/20cb8fdde819ab6a00140f6c987bb9dddaff7483 Log: Merge pull request #2281 from kzantow/ JENKINS-33663 -upgrade-wizard JENKINS-33663 - Upgrade wizard Compare: https://github.com/jenkinsci/jenkins/compare/74d0412d74a6...20cb8fdde819
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Released as Jenkins-2.6

            Show
            oleg_nenashev Oleg Nenashev added a comment - Released as Jenkins-2.6

              People

              • Assignee:
                kzantow Keith Zantow
                Reporter:
                kohsuke Kohsuke Kawaguchi
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: