Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33799

Githhub Organization Folder icon is not scaled

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I created a new Github Organization job called 'ffoo'. This automaically tried to connect to the Github Organization named, "ffoo". This organization does not exist on Github so Jenkins pulls in the default Github icon to represent the organization in the folder view. This default icon is not scaled and takes up a large percentage of my screen.

      Screen shot is attached. Select S,M,L for icon size has no effect.

        Attachments

          Issue Links

            Activity

            Hide
            danielbeck Daniel Beck added a comment -

            Not needed for 2.0 RC.

            Show
            danielbeck Daniel Beck added a comment - Not needed for 2.0 RC.
            Hide
            kohsuke Kohsuke Kawaguchi added a comment -

            I think Daniel meant "this shouldn't have that epic link to JENKINS-33810 because it's not a fix in the core."

            I will operate under the assumption that this still needs to be fixed for RC. And FWIW I think this is a fix that needs to happen in core. But I'll investigate.

            Show
            kohsuke Kohsuke Kawaguchi added a comment - I think Daniel meant "this shouldn't have that epic link to JENKINS-33810 because it's not a fix in the core." I will operate under the assumption that this still needs to be fixed for RC. And FWIW I think this is a fix that needs to happen in core. But I'll investigate.
            Hide
            hrmpw Patrick Wolf added a comment -

            This also happens when I connect to a legitimate repo owner in GH. I dont know if it is only default pictures or with custom icons.

            Show
            hrmpw Patrick Wolf added a comment - This also happens when I connect to a legitimate repo owner in GH. I dont know if it is only default pictures or with custom icons.
            Hide
            kohsuke Kohsuke Kawaguchi added a comment - - edited

            The problem is because default avatars like this is not responding to the size specifier parameter 's' unlike explicit avatars like this. Both images should be served as 100px by 100px but only the latter is.

            So the plugin ends up serving a URL to an <img> tag that's too big.

            To fix this in a plugin requires us to proxy, resize, and cache avatar images, which also requires up-to-date check. In contrast, we can fix this in the core much easily by just fixing the height and width settings to CSS.

            Show
            kohsuke Kohsuke Kawaguchi added a comment - - edited The problem is because default avatars like this is not responding to the size specifier parameter 's' unlike explicit avatars like this . Both images should be served as 100px by 100px but only the latter is. So the plugin ends up serving a URL to an <img> tag that's too big. To fix this in a plugin requires us to proxy, resize, and cache avatar images, which also requires up-to-date check. In contrast, we can fix this in the core much easily by just fixing the height and width settings to CSS.
            Hide
            kohsuke Kohsuke Kawaguchi added a comment -

            Fix proposed. Pending review & merge.

            Show
            kohsuke Kohsuke Kawaguchi added a comment - Fix proposed. Pending review & merge.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            core/src/main/resources/lib/hudson/ballColorTd.jelly
            war/src/main/webapp/css/style.css
            http://jenkins-ci.org/commit/jenkins/25ad5aedfb77815a2605e69e1003a458648c2db4
            Log:
            [FIXED JENKINS-33799]

            Fix the width & height of the icon via CSS.

            Previously, we were relying on the actual image being served as a
            correct size. This is fine for icons we ship in Jenkins, but when
            plugins use avatars as icons, those images might not come in the correct
            size.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/resources/lib/hudson/ballColorTd.jelly war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/25ad5aedfb77815a2605e69e1003a458648c2db4 Log: [FIXED JENKINS-33799] Fix the width & height of the icon via CSS. Previously, we were relying on the actual image being served as a correct size. This is fine for icons we ship in Jenkins, but when plugins use avatars as icons, those images might not come in the correct size.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            war/src/main/webapp/css/style.css
            http://jenkins-ci.org/commit/jenkins/b23cb10980a3bcc9d14596b6a604543ff3745eec
            Log:
            JENKINS-33799

            As suggested by Tom, removing the tag name restriction
            and correcting the xlg class name.

            See the Icon class for more details

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/b23cb10980a3bcc9d14596b6a604543ff3745eec Log: JENKINS-33799 As suggested by Tom, removing the tag name restriction and correcting the xlg class name. See the Icon class for more details
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            core/src/main/resources/lib/hudson/ballColorTd.jelly
            war/src/main/webapp/css/style.css
            http://jenkins-ci.org/commit/jenkins/62d0e0c268ea3ae6940c01c643cb7027de1705a3
            Log:
            Merge pull request #2175 from kohsuke/JENKINS-33799

            [FIX JENKINS-33799] Enforce correct icon size in list view

            Compare: https://github.com/jenkinsci/jenkins/compare/bcbc0195b966...62d0e0c268ea

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/resources/lib/hudson/ballColorTd.jelly war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/62d0e0c268ea3ae6940c01c643cb7027de1705a3 Log: Merge pull request #2175 from kohsuke/ JENKINS-33799 [FIX JENKINS-33799] Enforce correct icon size in list view Compare: https://github.com/jenkinsci/jenkins/compare/bcbc0195b966...62d0e0c268ea

              People

              • Assignee:
                kohsuke Kohsuke Kawaguchi
                Reporter:
                hrmpw Patrick Wolf
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: