Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33805

Rename update/install tracking files

    Details

    • Similar Issues:

      Description

      Right now, these two approaches are independent and partially redundant.

        Attachments

          Issue Links

            Activity

            Hide
            danielbeck Daniel Beck added a comment -

            Keith Zantow Could you PTAL whether this can be handled towards 2.0 with reasonable effort? I suspect it might not.

            CC Kohsuke Kawaguchi

            Show
            danielbeck Daniel Beck added a comment - Keith Zantow Could you PTAL whether this can be handled towards 2.0 with reasonable effort? I suspect it might not. CC Kohsuke Kawaguchi
            Hide
            kohsuke Kohsuke Kawaguchi added a comment -

            I left this comment in the original PR but I don't think this is achievable.

            What I think we should do instead is to rename the file that UpgradeWizard is using so that it is marked clearly as local to that one class, as opposed to try to be something more universally useful.

            Show
            kohsuke Kohsuke Kawaguchi added a comment - I left this comment in the original PR but I don't think this is achievable. What I think we should do instead is to rename the file that UpgradeWizard is using so that it is marked clearly as local to that one class, as opposed to try to be something more universally useful.
            Hide
            kzantow Keith Zantow added a comment -

            I think we should modify the InstallUtil version to be more of an update log. This could be in JSON format or something similar. We could use that to track all version upgrades, downgrades, and attach timestamps and metadata to each version, so things like this we could fairly easily track and display upgrade wizards at version 2.0, 2.1, etc.. Thoughts Kohsuke Kawaguchi Tom FENNELLY Daniel Beck?

            Show
            kzantow Keith Zantow added a comment - I think we should modify the InstallUtil version to be more of an update log. This could be in JSON format or something similar. We could use that to track all version upgrades, downgrades, and attach timestamps and metadata to each version, so things like this we could fairly easily track and display upgrade wizards at version 2.0, 2.1, etc.. Thoughts Kohsuke Kawaguchi Tom FENNELLY Daniel Beck ?
            Hide
            danielbeck Daniel Beck added a comment -

            Keith Zantow Great idea, not towards 2.0 though. This issue is about investigating whether something can be done for that release to not introduce this redundant and possibly temporary system. If the answer is "no", that's a bit ugly but not the end of the world.

            Show
            danielbeck Daniel Beck added a comment - Keith Zantow Great idea, not towards 2.0 though. This issue is about investigating whether something can be done for that release to not introduce this redundant and possibly temporary system. If the answer is "no", that's a bit ugly but not the end of the world.
            Hide
            danielbeck Daniel Beck added a comment -

            Maybe just rename the files used by wizard step 0 so it's clear where they are from?

            Show
            danielbeck Daniel Beck added a comment - Maybe just rename the files used by wizard step 0 so it's clear where they are from?
            Hide
            swashbuck1r Spike Washburn added a comment -

            Discussion:

            • Keith recommends not fixing now and has a alternative suggestion.
            • Daniel would like the file renamed

            Decision: Keith will rename the file and open another ticket for the install log suggestion.

            Show
            swashbuck1r Spike Washburn added a comment - Discussion: Keith recommends not fixing now and has a alternative suggestion. Daniel would like the file renamed Decision: Keith will rename the file and open another ticket for the install log suggestion.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: kzantow
            Path:
            core/src/main/java/jenkins/install/InstallUtil.java
            core/src/main/java/jenkins/install/UpgradeWizard.java
            http://jenkins-ci.org/commit/jenkins/04a34a353d0c64c401a73facce16df086e091747
            Log:
            JENKINS-33805 - rename install/upgrade files to be more clear &
            consistent

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: kzantow Path: core/src/main/java/jenkins/install/InstallUtil.java core/src/main/java/jenkins/install/UpgradeWizard.java http://jenkins-ci.org/commit/jenkins/04a34a353d0c64c401a73facce16df086e091747 Log: JENKINS-33805 - rename install/upgrade files to be more clear & consistent
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/jenkins/install/InstallUtil.java
            core/src/main/java/jenkins/install/UpgradeWizard.java
            http://jenkins-ci.org/commit/jenkins/e6df9f55bb6bbd2e842bae1355ed15f96b344099
            Log:
            Merge pull request #2215 from kzantow/JENKINS-33805-rename-updated-file

            [FIX JENKINS-33805] rename install/upgrade files to be more clear & consistent

            Compare: https://github.com/jenkinsci/jenkins/compare/a9cc8406c5a7...e6df9f55bb6b

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/jenkins/install/InstallUtil.java core/src/main/java/jenkins/install/UpgradeWizard.java http://jenkins-ci.org/commit/jenkins/e6df9f55bb6bbd2e842bae1355ed15f96b344099 Log: Merge pull request #2215 from kzantow/ JENKINS-33805 -rename-updated-file [FIX JENKINS-33805] rename install/upgrade files to be more clear & consistent Compare: https://github.com/jenkinsci/jenkins/compare/a9cc8406c5a7...e6df9f55bb6b

              People

              • Assignee:
                kzantow Keith Zantow
                Reporter:
                danielbeck Daniel Beck
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: