Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33995

ExecutorStep::labels should be recorded in the FlowNode graph

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      In the current flow graph it's impossible to understand, which labels have been actually required by the node() call. Such info would be useful for the build analysis.

      In WorkspaceActionImpl we get all labels of the build, so this info is not relevant.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            The summary of the issue is clear enough, but the description is mangled. WorkspaceAction.getLabels() is clearly documented to be the labels of the node owning the workspace, and the implementation matches the documentation and will not be changed.

            What you are asking for is access to the ExecutorStep.getLabel()—the requested label expression. This is not really the responsibility of WorkspaceAction, which is used in a couple of other places, of which WorkspaceStepExecution has no associated label expression, and CpsScmFlowDefinition could (but currently does not, and anyway that information would be statically available in the job definition).

            What might be more generally useful is to record the step configuration as an action in the StepNode. JENKINS-31582 requests that the plugins associated with the step be recorded, but we might as well just record the whole configuration, since it is typically not very large, and the plugin information can be reconstructed from that.

            Show
            jglick Jesse Glick added a comment - The summary of the issue is clear enough, but the description is mangled. WorkspaceAction.getLabels() is clearly documented to be the labels of the node owning the workspace, and the implementation matches the documentation and will not be changed. What you are asking for is access to the ExecutorStep.getLabel() —the requested label expression . This is not really the responsibility of WorkspaceAction , which is used in a couple of other places, of which WorkspaceStepExecution has no associated label expression, and CpsScmFlowDefinition could (but currently does not, and anyway that information would be statically available in the job definition). What might be more generally useful is to record the step configuration as an action in the StepNode . JENKINS-31582 requests that the plugins associated with the step be recorded, but we might as well just record the whole configuration, since it is typically not very large, and the plugin information can be reconstructed from that.
            Hide
            jglick Jesse Glick added a comment -

            Presumably relates somehow to JENKINS-32225.

            Show
            jglick Jesse Glick added a comment - Presumably relates somehow to JENKINS-32225 .
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Finally found the docs. WorkspaceActionImpl != WorkspaceAction, but I agree the proposal is no-go

            Show
            oleg_nenashev Oleg Nenashev added a comment - Finally found the docs. WorkspaceActionImpl != WorkspaceAction, but I agree the proposal is no-go
            Hide
            abayer Andrew Bayer added a comment -

            Is this still relevant or can we close it as won't fix?

            Show
            abayer Andrew Bayer added a comment - Is this still relevant or can we close it as won't fix?

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: