Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34093

2.0 introduces TopLevelItemDescriptor.LOGGER that is not private

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Resolved (View Workflow)
    • Priority: Trivial
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      I may be missing the usage of this logger but I don't think it's needed to have default access by package (seems strange anyway)

      https://github.com/daniel-beck/jenkins/commit/1fe9cf7b7ada45230f2bc5b8e2f1bdb93175ff9f#diff-ad8ba48d76d0d0aa6faa012af1f42280R53

        Attachments

          Activity

          Hide
          danielbeck Daniel Beck added a comment -

          Good catch, this actually changed which logger AbstractProject.AbstractProjectDescriptor methods referred to.

          Show
          danielbeck Daniel Beck added a comment - Good catch, this actually changed which logger AbstractProject.AbstractProjectDescriptor methods referred to.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/hudson/model/TopLevelItemDescriptor.java
          http://jenkins-ci.org/commit/jenkins/b01a1b1c15b3ed17a5bb4d584218ef3e9cf3de3f
          Log:
          [FIX JENKINS-34093] Make logger field private

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/model/TopLevelItemDescriptor.java http://jenkins-ci.org/commit/jenkins/b01a1b1c15b3ed17a5bb4d584218ef3e9cf3de3f Log: [FIX JENKINS-34093] Make logger field private
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/hudson/model/TopLevelItemDescriptor.java
          http://jenkins-ci.org/commit/jenkins/4f51944cf1f9fcf4d8b5bb4a9671730bf455838c
          Log:
          Merge pull request #2271 from daniel-beck/JENKINS-34093

          [FIX JENKINS-34093] Make logger field private

          Compare: https://github.com/jenkinsci/jenkins/compare/51b70aea3754...4f51944cf1f9

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/model/TopLevelItemDescriptor.java http://jenkins-ci.org/commit/jenkins/4f51944cf1f9fcf4d8b5bb4a9671730bf455838c Log: Merge pull request #2271 from daniel-beck/ JENKINS-34093 [FIX JENKINS-34093] Make logger field private Compare: https://github.com/jenkinsci/jenkins/compare/51b70aea3754...4f51944cf1f9

            People

            • Assignee:
              danielbeck Daniel Beck
              Reporter:
              teilo James Nord
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: