Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34246

Deleting Jenkinsfile does not remove a repository from an organization folder

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: branch-api-plugin
    • Labels:
    • Environment:
      Jenkins 1.642.4 + Github Organization Folder Plugin 1.2
      GitHub Enterprise in private mode.
    • Similar Issues:

      Description

      If I remove all Jenkinsfile from a GitHub repository (all branches) then the repository is still left in the folder. The contents of the repository are empty (i.e. no branches are shown).

      The same happens if I delete or transfer a repository to a another group/owner.

      I expected the repository to disappear if there are no longer any Jenkinsfile or if the repository doesn't exist.

        Attachments

          Activity

          Hide
          jglick Jesse Glick added a comment -

          I think I can reproduce this in a test.

          Show
          jglick Jesse Glick added a comment - I think I can reproduce this in a test.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/jenkins/branch/MultiBranchProjectFactory.java
          src/main/java/jenkins/branch/OrganizationFolder.java
          src/test/java/jenkins/branch/OrganizationFolderTest.java
          http://jenkins-ci.org/commit/branch-api-plugin/c7de701c13d515d4118bf1f2868d42b25428c7a9
          Log:
          JENKINS-34246 Fix MultiBranchProjectFactory API to allow deletion or update of existing children.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/jenkins/branch/MultiBranchProjectFactory.java src/main/java/jenkins/branch/OrganizationFolder.java src/test/java/jenkins/branch/OrganizationFolderTest.java http://jenkins-ci.org/commit/branch-api-plugin/c7de701c13d515d4118bf1f2868d42b25428c7a9 Log: JENKINS-34246 Fix MultiBranchProjectFactory API to allow deletion or update of existing children.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/jenkins/branch/MultiBranchProjectFactory.java
          src/main/java/jenkins/branch/OrganizationFolder.java
          src/test/java/jenkins/branch/OrganizationFolderTest.java
          http://jenkins-ci.org/commit/branch-api-plugin/2d3afb7f41c980d848add9baa7438bc838b75e9b
          Log:
          Merge pull request #45 from jglick/MultiBranchProjectFactory-update-JENKINS-34246

          JENKINS-34246 Fix MultiBranchProjectFactory API to allow deletion or update of existing children

          Compare: https://github.com/jenkinsci/branch-api-plugin/compare/0c390a0e40dd...2d3afb7f41c9

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/jenkins/branch/MultiBranchProjectFactory.java src/main/java/jenkins/branch/OrganizationFolder.java src/test/java/jenkins/branch/OrganizationFolderTest.java http://jenkins-ci.org/commit/branch-api-plugin/2d3afb7f41c980d848add9baa7438bc838b75e9b Log: Merge pull request #45 from jglick/MultiBranchProjectFactory-update- JENKINS-34246 JENKINS-34246 Fix MultiBranchProjectFactory API to allow deletion or update of existing children Compare: https://github.com/jenkinsci/branch-api-plugin/compare/0c390a0e40dd...2d3afb7f41c9
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/multibranch/AbstractWorkflowMultiBranchProjectFactory.java
          src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectFactoryTest.java
          http://jenkins-ci.org/commit/workflow-multibranch-plugin/a7d63ecf3fc97a4657514c1b0495dd039aeafbc0
          Log:
          [FIXED JENKINS-34246] Make AbstractWorkflowMultiBranchProjectFactory handle deletion or update of existing children.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/multibranch/AbstractWorkflowMultiBranchProjectFactory.java src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectFactoryTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/a7d63ecf3fc97a4657514c1b0495dd039aeafbc0 Log: [FIXED JENKINS-34246] Make AbstractWorkflowMultiBranchProjectFactory handle deletion or update of existing children.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/multibranch/AbstractWorkflowMultiBranchProjectFactory.java
          src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectFactoryTest.java
          http://jenkins-ci.org/commit/workflow-multibranch-plugin/c0d0368994973cc3d6d2d542c36304b4acd71de3
          Log:
          Merge pull request #15 from jglick/MultiBranchProjectFactory-update-JENKINS-34246

          JENKINS-34246 Make AbstractWorkflowMultiBranchProjectFactory handle deletion or update of existing children

          Compare: https://github.com/jenkinsci/workflow-multibranch-plugin/compare/04d93559028b...c0d036899497

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/multibranch/AbstractWorkflowMultiBranchProjectFactory.java src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectFactoryTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/c0d0368994973cc3d6d2d542c36304b4acd71de3 Log: Merge pull request #15 from jglick/MultiBranchProjectFactory-update- JENKINS-34246 JENKINS-34246 Make AbstractWorkflowMultiBranchProjectFactory handle deletion or update of existing children Compare: https://github.com/jenkinsci/workflow-multibranch-plugin/compare/04d93559028b...c0d036899497

            People

            • Assignee:
              jglick Jesse Glick
              Reporter:
              docwhat Christian Höltje
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: