Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-3430

Regression trigger, improvement trigger, a few small improvements (PATCH)

    Details

    • Type: Patch
    • Status: Resolved
    • Priority: Major
    • Resolution: Incomplete
    • Component/s: email-ext-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: All

      Description

      Attached is a patch that adds the following to the email-ext plugin:

      • Regression trigger: Applies when current build has more failures than previous
        build.
      • Improvement trigger: Applies when current build has fewer failures than
        previous build.
      • Added options to tokens:
      • FAILED_TESTS: showStack option to suppress stack traces in the mail
      • CHANGES_SINCE_LAST_BUILD: showDependencies option to show changes in
        projects the current project depends on

      All of these have been tested and work on our Hudson instance.

        Activity

        Hide
        miked30 Mike Doherty added a comment -

        As the previous pull request from comradep appears to have stalled I've added a new pull request for just the initial two triggers, improvement and regression. https://github.com/jenkinsci/email-ext-plugin/pull/21

        We've been testing this on our team for several days now and all seems fine.

        Show
        miked30 Mike Doherty added a comment - As the previous pull request from comradep appears to have stalled I've added a new pull request for just the initial two triggers, improvement and regression. https://github.com/jenkinsci/email-ext-plugin/pull/21 We've been testing this on our team for several days now and all seems fine.
        Hide
        miked30 Mike Doherty added a comment -
        Show
        miked30 Mike Doherty added a comment - Fixed in pull request 21 ( https://github.com/jenkinsci/email-ext-plugin/pull/21 )
        Hide
        jukka Jukka Zitting added a comment -

        The showStacks option doesn't work properly, so reopening. See https://github.com/jenkinsci/email-ext-plugin/pull/26 for a fix.

        Show
        jukka Jukka Zitting added a comment - The showStacks option doesn't work properly, so reopening. See https://github.com/jenkinsci/email-ext-plugin/pull/26 for a fix.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Jukka Zitting
        Path:
        src/main/java/hudson/plugins/emailext/plugins/content/FailedTestsContent.java
        http://jenkins-ci.org/commit/email-ext-plugin/12a08fc0446dbb26f5b4bed2fe0f99cd1e5495f8
        Log:
        JENKINS-3430: Only include the stack trace if showStacks is true (the default)

        The previous implementation always included the stack trace, twice if showStacks was enabled!

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jukka Zitting Path: src/main/java/hudson/plugins/emailext/plugins/content/FailedTestsContent.java http://jenkins-ci.org/commit/email-ext-plugin/12a08fc0446dbb26f5b4bed2fe0f99cd1e5495f8 Log: JENKINS-3430 : Only include the stack trace if showStacks is true (the default) The previous implementation always included the stack trace, twice if showStacks was enabled!
        Hide
        slide_o_mix Alex Earl added a comment -

        Is this fixed or not?

        Show
        slide_o_mix Alex Earl added a comment - Is this fixed or not?

          People

          • Assignee:
            miked30 Mike Doherty
            Reporter:
            comradep comradep
          • Votes:
            3 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: