Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34464

DescribableModel can't inspect ReverseBuildTrigger; need binding for Result

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core, structs-plugin
    • Labels:
      None
    • Environment:
      core 2.0
      structs 1.1
    • Similar Issues:

      Description

      DescribableModel reports an error for hudson.model.Result.

      Run this in script console to reproduce:

      import org.jenkinsci.plugins.structs.describable.*
      import jenkins.triggers.*
        
      new DescribableModel(ReverseBuildTrigger)
      

      Result:

      (upstreamProjects: String, threshold: org.kohsuke.stapler.NoStaplerConstructorException: There's no @DataBoundConstructor on any constructor of class hudson.model.Result)
      

        Attachments

          Issue Links

            Activity

            daspilker Daniel Spilker created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Summary DescribableModel can't inspect ReverseBuildTrigger DescribableModel can't inspect ReverseBuildTrigger; need binding for Result
            jglick Jesse Glick made changes -
            Epic Link JENKINS-35393 [ 171186 ]
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-27092 [ JENKINS-27092 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 170583 ] JNJira + In-Review [ 183964 ]
            Hide
            jglick Jesse Glick added a comment -

            Also ReverseBuildTrigger should be fixed to use @DataBoundSetter for threshold so that the default in the UI of SUCCESS would apply also in code.

            Show
            jglick Jesse Glick added a comment - Also ReverseBuildTrigger should be fixed to use @DataBoundSetter for threshold so that the default in the UI of SUCCESS would apply also in code.
            jglick Jesse Glick made changes -
            Link This issue relates to JENKINS-40849 [ JENKINS-40849 ]
            jglick Jesse Glick made changes -
            Link This issue relates to JENKINS-40307 [ JENKINS-40307 ]
            jglick Jesse Glick made changes -
            Link This issue is duplicated by JENKINS-40304 [ JENKINS-40304 ]
            abayer Andrew Bayer made changes -
            Assignee Kohsuke Kawaguchi [ kohsuke ] Andrew Bayer [ abayer ]
            abayer Andrew Bayer made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            abayer Andrew Bayer made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            Show
            abayer Andrew Bayer added a comment - PR up at https://github.com/jenkinsci/structs-plugin/pull/19
            abayer Andrew Bayer made changes -
            Remote Link This issue links to "PR #19 (Web Link)" [ 16904 ]
            abayer Andrew Bayer made changes -
            Remote Link This issue links to "Test PR (workflow-multibranch #63) (Web Link)" [ 16905 ]
            Hide
            abayer Andrew Bayer added a comment -

            Added core PR for @DataBoundSetter change and workflow-multibranch PR for snippetizer test.

            Show
            abayer Andrew Bayer added a comment - Added core PR for @DataBoundSetter change and workflow-multibranch PR for snippetizer test.
            abayer Andrew Bayer made changes -
            Remote Link This issue links to "Core PR #2895 (Web Link)" [ 16906 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableModel.java
            plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableParameter.java
            plugin/src/main/java/org/jenkinsci/plugins/structs/describable/ParameterType.java
            plugin/src/test/java/org/jenkinsci/plugins/structs/describable/DescribableModelTest.java
            http://jenkins-ci.org/commit/structs-plugin/1c8a50cff6b53babc8d155b5c92b3497fe33c6b3
            Log:
            [FIXED JENKINS-34464] Enable DescribableModel binding for Result

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableModel.java plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableParameter.java plugin/src/main/java/org/jenkinsci/plugins/structs/describable/ParameterType.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/DescribableModelTest.java http://jenkins-ci.org/commit/structs-plugin/1c8a50cff6b53babc8d155b5c92b3497fe33c6b3 Log: [FIXED JENKINS-34464] Enable DescribableModel binding for Result
            Hide
            abayer Andrew Bayer added a comment -

            Fixed in next release (1.7?) of structs plugin.

            Show
            abayer Andrew Bayer added a comment - Fixed in next release (1.7?) of structs plugin.
            abayer Andrew Bayer made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            abayer Andrew Bayer added a comment -

            Hrm, having some problem with the downstream test. Reopening until I get that straightened out.

            Show
            abayer Andrew Bayer added a comment - Hrm, having some problem with the downstream test. Reopening until I get that straightened out.
            abayer Andrew Bayer made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            jglick Jesse Glick made changes -
            Status Reopened [ 4 ] Open [ 1 ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pom.xml
            src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java
            src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/EchoResultStep.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/b5343636ebdcb5da3b1a2d1be6ce6afb128cb258
            Log:
            JENKINS-34464 Bump structs version, add test for result roundtrip

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/EchoResultStep.java http://jenkins-ci.org/commit/workflow-cps-plugin/b5343636ebdcb5da3b1a2d1be6ce6afb128cb258 Log: JENKINS-34464 Bump structs version, add test for result roundtrip
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pom.xml
            src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java
            src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/EchoResultStep.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/448fe7a6d701f21c5b43a9cb8dd880edd6f9b0ad
            Log:
            Merge pull request #136 from abayer/jenkins-34464

            JENKINS-34464 Bump structs version, add test for result roundtrip

            Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/21e1ef16c7fe...448fe7a6d701

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/EchoResultStep.java http://jenkins-ci.org/commit/workflow-cps-plugin/448fe7a6d701f21c5b43a9cb8dd880edd6f9b0ad Log: Merge pull request #136 from abayer/jenkins-34464 JENKINS-34464 Bump structs version, add test for result roundtrip Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/21e1ef16c7fe...448fe7a6d701
            Hide
            abayer Andrew Bayer added a comment -

            Fixed in structs 1.7 release.

            Show
            abayer Andrew Bayer added a comment - Fixed in structs 1.7 release.
            abayer Andrew Bayer made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pom.xml
            src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/ec7abe9bfe60caeaeaa55df949eb1b2b04cbfa5d
            Log:
            JENKINS-34464 Test for Result working in Snippet Generator

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/ec7abe9bfe60caeaeaa55df949eb1b2b04cbfa5d Log: JENKINS-34464 Test for Result working in Snippet Generator
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pom.xml
            src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/adf46741ea0520c42aea62cc02c916ff5a8e6d21
            Log:
            Merge pull request #63 from abayer/jenkins-34464

            JENKINS-34464 Test for Result working in Snippet Generator

            Compare: https://github.com/jenkinsci/workflow-multibranch-plugin/compare/0f5fae969de6...adf46741ea05

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/adf46741ea0520c42aea62cc02c916ff5a8e6d21 Log: Merge pull request #63 from abayer/jenkins-34464 JENKINS-34464 Test for Result working in Snippet Generator Compare: https://github.com/jenkinsci/workflow-multibranch-plugin/compare/0f5fae969de6...adf46741ea05
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
            http://jenkins-ci.org/commit/jenkins/3b712af2ded342d992aed559fcce314e11bb32b7
            Log:
            JENKINS-34464 Switch ReverseBuildTrigger.threshold to DataBoundSetter

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java http://jenkins-ci.org/commit/jenkins/3b712af2ded342d992aed559fcce314e11bb32b7 Log: JENKINS-34464 Switch ReverseBuildTrigger.threshold to DataBoundSetter
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
            http://jenkins-ci.org/commit/jenkins/4515a075182e3dd98bec027047ed8385be137064
            Log:
            Merge pull request #2895 from abayer/jenkins-34464

            JENKINS-34464 Switch ReverseBuildTrigger.threshold to DataBoundSetter

            Compare: https://github.com/jenkinsci/jenkins/compare/2b8b18997945...4515a075182e

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java http://jenkins-ci.org/commit/jenkins/4515a075182e3dd98bec027047ed8385be137064 Log: Merge pull request #2895 from abayer/jenkins-34464 JENKINS-34464 Switch ReverseBuildTrigger.threshold to DataBoundSetter Compare: https://github.com/jenkinsci/jenkins/compare/2b8b18997945...4515a075182e

              People

              • Assignee:
                abayer Andrew Bayer
                Reporter:
                daspilker Daniel Spilker
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: