Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34596

Set visible flag when Jenkinsfile is taken from a trusted revision rather than PR head

    Details

    • Similar Issues:

      Description

      When pull requests are done from private repos in a github organization, for example: A develop will fork a repo, commit some changes then submit a pull request from the forked repo. In that case the files will be taken from organization instead of developer, so the tests actually run on the wrong code, they pass and the pull request in github gets marked as passing even though it was never actually tested.

      A way to know if the revision of the Jenkinsfile is not the same than the branch tip (a.k.a the Jenkinsfile comes from an untrusted brach) should be great.

      https://github.com/jenkinsci/github-branch-source-plugin/blob/a10e869ec3b653b05eb188bd1e4054211d32294f/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java#L421-L433

        Attachments

          Issue Links

            Activity

            escoem Emilio Escobar created issue -
            amuniz Antonio Muñiz made changes -
            Field Original Value New Value
            Component/s github-branch-source-plugin [ 20858 ]
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-33256 [ JENKINS-33256 ]
            jglick Jesse Glick made changes -
            Summary Add a way to know if the revision of the Jenkinsfile is not the same than the branch tip Set visible flag when Jenkinsfile is taken from a trusted revision rather than PR head
            jglick Jesse Glick made changes -
            Labels multibranch
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-33273 [ JENKINS-33273 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "PR 10 (Web Link)" [ 14344 ]
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-32400 [ JENKINS-32400 ]
            scm_issue_link SCM/JIRA link daemon made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 170756 ] JNJira + In-Review [ 198936 ]
            abayer Andrew Bayer made changes -
            Component/s pipeline-general [ 21692 ]
            abayer Andrew Bayer made changes -
            Component/s workflow-plugin [ 18820 ]

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                escoem Emilio Escobar
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: