Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34628

Jenkins core contains dependencies with external static resources

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Environment:
      jenkins-2.0+
    • Similar Issues:

      Description

      There are dependencies with external resources in runtime. You can find an example like this:

      <?jelly escape-by-default='true'?>
      <l:html norefresh="true" title="${it.displayName}" xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
        <l:main-panel>
          <style type="text/css">
            @import url(https://maxcdn.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css);
            @import url(https://fonts.googleapis.com/css?family=Roboto:400,300,500,900,700);
      

      in core/src/main/resources/jenkins/install/SetupWizard/setupWizardFirstUser.jelly.

      1. Remove CSS inline in Jelly file if it is possible.
      2. Remove duplicated refereces: here and here

      This does more difficult a real environment without direct internet connection (offline mode).

        Attachments

          Issue Links

            Activity

            Hide
            recena Manuel Recena Soto added a comment -

            Keith Zantow What do you think?

            Show
            recena Manuel Recena Soto added a comment - Keith Zantow What do you think?
            Hide
            danielbeck Daniel Beck added a comment -

            Agree, we shouldn't do this. Jenkins must be able to work equally well offline (there could be update sites on the local network, which make internet access for even that unnecessary).

            Show
            danielbeck Daniel Beck added a comment - Agree, we shouldn't do this. Jenkins must be able to work equally well offline (there could be update sites on the local network, which make internet access for even that unnecessary).
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            I vote for converting it to a Bug. Just in case the fix misses the 2.x LTS baseline and we need to backport it

            Show
            oleg_nenashev Oleg Nenashev added a comment - I vote for converting it to a Bug. Just in case the fix misses the 2.x LTS baseline and we need to backport it
            Hide
            andresrc Andres Rodriguez added a comment -

            +1 to converting it to a bug

            Show
            andresrc Andres Rodriguez added a comment - +1 to converting it to a bug
            Hide
            danielbeck Daniel Beck added a comment -

            Absolutely. Would be great to not have an LTS with weird web dependencies.

            Show
            danielbeck Daniel Beck added a comment - Absolutely. Would be great to not have an LTS with weird web dependencies.
            Hide
            recena Manuel Recena Soto added a comment -

            I agree with the change.

            Show
            recena Manuel Recena Soto added a comment - I agree with the change.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Manuel Recena
            Path:
            core/src/main/resources/hudson/AboutJenkins/index.jelly
            core/src/main/resources/hudson/AboutJenkins/index.properties
            core/src/main/resources/jenkins/install/SetupWizard/setupWizardFirstUser.jelly
            war/package.json
            war/pom.xml
            war/src/main/less/pluginSetupWizard.less
            war/src/main/webapp/css/font-awesome/css/LICENSE.txt
            war/src/main/webapp/css/font-awesome/css/font-awesome.css
            war/src/main/webapp/css/font-awesome/css/font-awesome.min.css
            war/src/main/webapp/css/font-awesome/fonts/FontAwesome.otf
            war/src/main/webapp/css/font-awesome/fonts/LICENSE.txt
            war/src/main/webapp/css/font-awesome/fonts/fontawesome-webfont.eot
            war/src/main/webapp/css/font-awesome/fonts/fontawesome-webfont.svg
            war/src/main/webapp/css/font-awesome/fonts/fontawesome-webfont.ttf
            war/src/main/webapp/css/font-awesome/fonts/fontawesome-webfont.woff
            war/src/main/webapp/css/font-awesome/fonts/fontawesome-webfont.woff2
            war/src/main/webapp/css/google-fonts/roboto/LICENSE.txt
            war/src/main/webapp/css/google-fonts/roboto/css/roboto.css
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-300.eot
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-300.svg
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-300.ttf
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-300.woff
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-300.woff2
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-500.eot
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-500.svg
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-500.ttf
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-500.woff
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-500.woff2
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-700.eot
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-700.svg
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-700.ttf
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-700.woff
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-700.woff2
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-900.eot
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-900.svg
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-900.ttf
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-900.woff
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-900.woff2
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-regular.eot
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-regular.svg
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-regular.ttf
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-regular.woff
            war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-regular.woff2
            war/src/main/webapp/css/icomoon/css/icomoon.css
            war/src/main/webapp/css/icomoon/fonts/icomoon.eot
            war/src/main/webapp/css/icomoon/fonts/icomoon.svg
            war/src/main/webapp/css/icomoon/fonts/icomoon.ttf
            war/src/main/webapp/css/icomoon/fonts/icomoon.woff
            war/src/main/webapp/css/icons/icomoon.css
            war/src/main/webapp/css/icons/icomoon/icomoon.eot
            war/src/main/webapp/css/icons/icomoon/icomoon.svg
            war/src/main/webapp/css/icons/icomoon/icomoon.ttf
            war/src/main/webapp/css/icons/icomoon/icomoon.woff
            http://jenkins-ci.org/commit/jenkins/606794a46fca01a83387064844abbc1886ba211c
            Log:
            JENKINS-34628 - Bundle "Font Awesome" and "Google Fints: Roboto" dependencies to prevent failures in the offline mode (#2318)

            • JENKINS-34628 Remove dependencies with external static resources
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: core/src/main/resources/hudson/AboutJenkins/index.jelly core/src/main/resources/hudson/AboutJenkins/index.properties core/src/main/resources/jenkins/install/SetupWizard/setupWizardFirstUser.jelly war/package.json war/pom.xml war/src/main/less/pluginSetupWizard.less war/src/main/webapp/css/font-awesome/css/LICENSE.txt war/src/main/webapp/css/font-awesome/css/font-awesome.css war/src/main/webapp/css/font-awesome/css/font-awesome.min.css war/src/main/webapp/css/font-awesome/fonts/FontAwesome.otf war/src/main/webapp/css/font-awesome/fonts/LICENSE.txt war/src/main/webapp/css/font-awesome/fonts/fontawesome-webfont.eot war/src/main/webapp/css/font-awesome/fonts/fontawesome-webfont.svg war/src/main/webapp/css/font-awesome/fonts/fontawesome-webfont.ttf war/src/main/webapp/css/font-awesome/fonts/fontawesome-webfont.woff war/src/main/webapp/css/font-awesome/fonts/fontawesome-webfont.woff2 war/src/main/webapp/css/google-fonts/roboto/LICENSE.txt war/src/main/webapp/css/google-fonts/roboto/css/roboto.css war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-300.eot war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-300.svg war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-300.ttf war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-300.woff war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-300.woff2 war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-500.eot war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-500.svg war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-500.ttf war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-500.woff war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-500.woff2 war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-700.eot war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-700.svg war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-700.ttf war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-700.woff war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-700.woff2 war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-900.eot war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-900.svg war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-900.ttf war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-900.woff war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-900.woff2 war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-regular.eot war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-regular.svg war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-regular.ttf war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-regular.woff war/src/main/webapp/css/google-fonts/roboto/fonts/roboto-v15-greek_latin-ext_latin_vietnamese_cyrillic_greek-ext_cyrillic-ext-regular.woff2 war/src/main/webapp/css/icomoon/css/icomoon.css war/src/main/webapp/css/icomoon/fonts/icomoon.eot war/src/main/webapp/css/icomoon/fonts/icomoon.svg war/src/main/webapp/css/icomoon/fonts/icomoon.ttf war/src/main/webapp/css/icomoon/fonts/icomoon.woff war/src/main/webapp/css/icons/icomoon.css war/src/main/webapp/css/icons/icomoon/icomoon.eot war/src/main/webapp/css/icons/icomoon/icomoon.svg war/src/main/webapp/css/icons/icomoon/icomoon.ttf war/src/main/webapp/css/icons/icomoon/icomoon.woff http://jenkins-ci.org/commit/jenkins/606794a46fca01a83387064844abbc1886ba211c Log: JENKINS-34628 - Bundle "Font Awesome" and "Google Fints: Roboto" dependencies to prevent failures in the offline mode (#2318) JENKINS-34628 Remove dependencies with external static resources JENKINS-34628 License files were added JENKINS-34628 Added references in the About page
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Released as Jenkins-2.4

            Show
            oleg_nenashev Oleg Nenashev added a comment - Released as Jenkins-2.4

              People

              • Assignee:
                recena Manuel Recena Soto
                Reporter:
                recena Manuel Recena Soto
              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: