Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34755

Allow setting of system properties from context.xml in addition to setting from command line

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Issue for https://github.com/jenkinsci/jenkins/pull/1914

      Goals:

      • Allow the specification of system properties in context.xml in addition to in environment variables
      • Avoid having to edit tomcat's systemd.service file to run Jenkins with flags.
      • Avoid having to restart app server if flags are changed in context.xml.
      • Makes it easier for Jenkins to coexist with other apps on the same app server.
      • Centralize parsing of system properties:
        • over time, consistent error reporting can be implemented for malformed system properties. Right now, that code is all over the place (e.g. what is and isn't true or false in boolean values is implemented differently)
        • access to system properties is now logged, which helps with debugging setups

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/ClassicPluginStrategy.java
            core/src/main/java/hudson/DNSMultiCast.java
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/Functions.java
            core/src/main/java/hudson/LocalPluginManager.java
            core/src/main/java/hudson/Main.java
            core/src/main/java/hudson/PluginManager.java
            core/src/main/java/hudson/TcpSlaveAgentListener.java
            core/src/main/java/hudson/UDPBroadcastThread.java
            core/src/main/java/hudson/Util.java
            core/src/main/java/hudson/WebAppMain.java
            core/src/main/java/hudson/cli/CLICommand.java
            core/src/main/java/hudson/init/InitStrategy.java
            core/src/main/java/hudson/lifecycle/Lifecycle.java
            core/src/main/java/hudson/lifecycle/WindowsInstallerLink.java
            core/src/main/java/hudson/model/AbstractBuild.java
            core/src/main/java/hudson/model/Computer.java
            core/src/main/java/hudson/model/DownloadService.java
            core/src/main/java/hudson/model/FullDuplexHttpChannel.java
            core/src/main/java/hudson/model/Item.java
            core/src/main/java/hudson/model/LoadStatistics.java
            core/src/main/java/hudson/model/Queue.java
            core/src/main/java/hudson/model/Run.java
            core/src/main/java/hudson/model/Slave.java
            core/src/main/java/hudson/model/TreeView.java
            core/src/main/java/hudson/model/UpdateCenter.java
            core/src/main/java/hudson/model/UpdateSite.java
            core/src/main/java/hudson/model/UsageStatistics.java
            core/src/main/java/hudson/model/User.java
            core/src/main/java/hudson/model/ViewJob.java
            core/src/main/java/hudson/model/WorkspaceCleanupThread.java
            core/src/main/java/hudson/model/queue/BackFiller.java
            core/src/main/java/hudson/os/solaris/ZFSInstaller.java
            core/src/main/java/hudson/scheduler/BaseParser.java
            core/src/main/java/hudson/security/csrf/DefaultCrumbIssuer.java
            core/src/main/java/hudson/slaves/ChannelPinger.java
            core/src/main/java/hudson/slaves/CloudRetentionStrategy.java
            core/src/main/java/hudson/slaves/ConnectionActivityMonitor.java
            core/src/main/java/hudson/slaves/NodeProvisioner.java
            core/src/main/java/hudson/slaves/WorkspaceList.java
            core/src/main/java/hudson/tasks/ArtifactArchiver.java
            core/src/main/java/hudson/tasks/Fingerprinter.java
            core/src/main/java/hudson/util/CharacterEncodingFilter.java
            core/src/main/java/hudson/util/ProcessTree.java
            core/src/main/java/hudson/util/RingBufferLogHandler.java
            core/src/main/java/hudson/util/Secret.java
            core/src/main/java/hudson/widgets/HistoryWidget.java
            core/src/main/java/jenkins/InitReactorRunner.java
            core/src/main/java/jenkins/model/Configuration.java
            core/src/main/java/jenkins/model/Jenkins.java
            core/src/main/java/jenkins/model/lazy/BuildReference.java
            core/src/main/java/jenkins/security/ApiTokenProperty.java
            core/src/main/java/jenkins/security/BasicHeaderRealPasswordAuthenticator.java
            core/src/main/java/jenkins/security/FrameOptionsPageDecorator.java
            core/src/main/java/jenkins/security/SecureRequester.java
            core/src/main/java/jenkins/security/s2m/CallableDirectionChecker.java
            core/src/main/java/jenkins/security/s2m/DefaultFilePathFilter.java
            core/src/main/java/jenkins/slaves/NioChannelSelector.java
            core/src/main/java/jenkins/slaves/StandardOutputSwapper.java
            core/src/main/java/jenkins/util/SystemProperties.java
            core/src/main/java/jenkins/util/xml/XMLUtils.java
            test/src/test/java/jenkins/util/SystemPropertiesTest.java
            http://jenkins-ci.org/commit/jenkins/cf64ba04fe8b0312bb4492766d62b5a00b790432
            Log:
            Merge pull request #2337 from oleg-nenashev/JENKINS-34755

            JENKINS-34755 - Allow setting of system properties from context.xml in addition to setting from command line

            Compare: https://github.com/jenkinsci/jenkins/compare/409438f36dc8...cf64ba04fe8b

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/ClassicPluginStrategy.java core/src/main/java/hudson/DNSMultiCast.java core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/Functions.java core/src/main/java/hudson/LocalPluginManager.java core/src/main/java/hudson/Main.java core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/TcpSlaveAgentListener.java core/src/main/java/hudson/UDPBroadcastThread.java core/src/main/java/hudson/Util.java core/src/main/java/hudson/WebAppMain.java core/src/main/java/hudson/cli/CLICommand.java core/src/main/java/hudson/init/InitStrategy.java core/src/main/java/hudson/lifecycle/Lifecycle.java core/src/main/java/hudson/lifecycle/WindowsInstallerLink.java core/src/main/java/hudson/model/AbstractBuild.java core/src/main/java/hudson/model/Computer.java core/src/main/java/hudson/model/DownloadService.java core/src/main/java/hudson/model/FullDuplexHttpChannel.java core/src/main/java/hudson/model/Item.java core/src/main/java/hudson/model/LoadStatistics.java core/src/main/java/hudson/model/Queue.java core/src/main/java/hudson/model/Run.java core/src/main/java/hudson/model/Slave.java core/src/main/java/hudson/model/TreeView.java core/src/main/java/hudson/model/UpdateCenter.java core/src/main/java/hudson/model/UpdateSite.java core/src/main/java/hudson/model/UsageStatistics.java core/src/main/java/hudson/model/User.java core/src/main/java/hudson/model/ViewJob.java core/src/main/java/hudson/model/WorkspaceCleanupThread.java core/src/main/java/hudson/model/queue/BackFiller.java core/src/main/java/hudson/os/solaris/ZFSInstaller.java core/src/main/java/hudson/scheduler/BaseParser.java core/src/main/java/hudson/security/csrf/DefaultCrumbIssuer.java core/src/main/java/hudson/slaves/ChannelPinger.java core/src/main/java/hudson/slaves/CloudRetentionStrategy.java core/src/main/java/hudson/slaves/ConnectionActivityMonitor.java core/src/main/java/hudson/slaves/NodeProvisioner.java core/src/main/java/hudson/slaves/WorkspaceList.java core/src/main/java/hudson/tasks/ArtifactArchiver.java core/src/main/java/hudson/tasks/Fingerprinter.java core/src/main/java/hudson/util/CharacterEncodingFilter.java core/src/main/java/hudson/util/ProcessTree.java core/src/main/java/hudson/util/RingBufferLogHandler.java core/src/main/java/hudson/util/Secret.java core/src/main/java/hudson/widgets/HistoryWidget.java core/src/main/java/jenkins/InitReactorRunner.java core/src/main/java/jenkins/model/Configuration.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/java/jenkins/model/lazy/BuildReference.java core/src/main/java/jenkins/security/ApiTokenProperty.java core/src/main/java/jenkins/security/BasicHeaderRealPasswordAuthenticator.java core/src/main/java/jenkins/security/FrameOptionsPageDecorator.java core/src/main/java/jenkins/security/SecureRequester.java core/src/main/java/jenkins/security/s2m/CallableDirectionChecker.java core/src/main/java/jenkins/security/s2m/DefaultFilePathFilter.java core/src/main/java/jenkins/slaves/NioChannelSelector.java core/src/main/java/jenkins/slaves/StandardOutputSwapper.java core/src/main/java/jenkins/util/SystemProperties.java core/src/main/java/jenkins/util/xml/XMLUtils.java test/src/test/java/jenkins/util/SystemPropertiesTest.java http://jenkins-ci.org/commit/jenkins/cf64ba04fe8b0312bb4492766d62b5a00b790432 Log: Merge pull request #2337 from oleg-nenashev/ JENKINS-34755 JENKINS-34755 - Allow setting of system properties from context.xml in addition to setting from command line Compare: https://github.com/jenkinsci/jenkins/compare/409438f36dc8...cf64ba04fe8b
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/model/DirectoryBrowserSupport.java
            core/src/main/java/hudson/model/ParametersAction.java
            core/src/main/java/hudson/model/User.java
            core/src/main/java/jenkins/install/InstallUtil.java
            core/src/main/java/jenkins/util/SystemProperties.java
            http://jenkins-ci.org/commit/jenkins/99f80a0b0b93a6d7c928d21849d96e0d642e5d1f
            Log:
            JENKINS-34755 Migrate the stuff and restrict access to the engine in the next release (#2346)

            JENKINS-34755 Migrate to SystemProperties and restrict access to the engine

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/DirectoryBrowserSupport.java core/src/main/java/hudson/model/ParametersAction.java core/src/main/java/hudson/model/User.java core/src/main/java/jenkins/install/InstallUtil.java core/src/main/java/jenkins/util/SystemProperties.java http://jenkins-ci.org/commit/jenkins/99f80a0b0b93a6d7c928d21849d96e0d642e5d1f Log: JENKINS-34755 Migrate the stuff and restrict access to the engine in the next release (#2346) JENKINS-34755 Migrate to SystemProperties and restrict access to the engine
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: evernat
            Path:
            core/src/main/java/hudson/WebAppMain.java
            core/src/main/java/jenkins/util/SystemProperties.java
            test/src/test/java/jenkins/util/SystemPropertiesTest.java
            war/src/main/webapp/WEB-INF/web.xml
            http://jenkins-ci.org/commit/jenkins/65f2a4a406c9d853a4ba9c763acc8f049a82c649
            Log:
            JENKINS-34755 fix read of 'SystemProperties' values before init of the context (#2347)

            • fix read of 'SystemProperties' values before init of the context
            • fix constructor and test
            • revert help-spec_fr.html
            • revert help-spec_fr.html
            • revert help-spec_fr.html
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: evernat Path: core/src/main/java/hudson/WebAppMain.java core/src/main/java/jenkins/util/SystemProperties.java test/src/test/java/jenkins/util/SystemPropertiesTest.java war/src/main/webapp/WEB-INF/web.xml http://jenkins-ci.org/commit/jenkins/65f2a4a406c9d853a4ba9c763acc8f049a82c649 Log: JENKINS-34755 fix read of 'SystemProperties' values before init of the context (#2347) fix read of 'SystemProperties' values before init of the context fix constructor and test revert help-spec_fr.html revert help-spec_fr.html revert help-spec_fr.html
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            released in jenkins-2.4

            Show
            oleg_nenashev Oleg Nenashev added a comment - released in jenkins-2.4
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/jenkins/util/SystemProperties.java
            http://jenkins-ci.org/commit/jenkins/d8821c86451e7e30d6f3225892f01404000e2a60
            Log:
            JENKINS-34755 Noting since for #2337.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/util/SystemProperties.java http://jenkins-ci.org/commit/jenkins/d8821c86451e7e30d6f3225892f01404000e2a60 Log: JENKINS-34755 Noting since for #2337.

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: