Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34825

Jobs in Folders should show credentials bound in the credential domain

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: p4-plugin
    • Labels:
      None
    • Similar Issues:

      Description

      Credentials "bound" to the folder do not show in the credentials dropdown

      Repro:

      • Install the Folders plugin
      • Create a Folder
      • Configure the Folder to have a Credential Domain, then a dd a Perforce Password credential to that domain
      • Create a job within the folder with SCM Perforce. View credentials from the dropdown

      Expected: pick from global credentials and the credential just added in the folder's credential domain.

      Actual: only global credentials.

      I do have project team specific folders on the master and each has a local credential store that is visible only to users with the permission to create jobs in that folder. But the P4 plugin doesn’t see those credentials – it only sees the ones at the master level.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Allan Burdajewicz
            Path:
            src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java
            src/test/java/org/jenkinsci/plugins/p4/credentials/PerforceCredentialsTest.java
            http://jenkins-ci.org/commit/p4-plugin/31d91eaf56a73015ce014fd3f95c9df1f083cfc5
            Log:
            JENKINS-34825 Fix imports

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Allan Burdajewicz Path: src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java src/test/java/org/jenkinsci/plugins/p4/credentials/PerforceCredentialsTest.java http://jenkins-ci.org/commit/p4-plugin/31d91eaf56a73015ce014fd3f95c9df1f083cfc5 Log: JENKINS-34825 Fix imports
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Allan Burdajewicz
            Path:
            pom.xml
            src/test/java/org/jenkinsci/plugins/p4/client/ConnectionTest.java
            http://jenkins-ci.org/commit/p4-plugin/460b252ca1aba9ff99999bc8eba4ecb0fca3b2ed
            Log:
            JENKINS-34825 Fixed test for credentials tracking. Fixed dependency for testing credentials in Folder.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Allan Burdajewicz Path: pom.xml src/test/java/org/jenkinsci/plugins/p4/client/ConnectionTest.java http://jenkins-ci.org/commit/p4-plugin/460b252ca1aba9ff99999bc8eba4ecb0fca3b2ed Log: JENKINS-34825 Fixed test for credentials tracking. Fixed dependency for testing credentials in Folder.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Allan Burdajewicz
            Path:
            src/main/java/org/jenkinsci/plugins/p4/ConfigurationListener.java
            src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java
            src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java
            src/main/java/org/jenkinsci/plugins/p4/groovy/P4Groovy.java
            src/main/java/org/jenkinsci/plugins/p4/scm/AbstractP4ScmSource.java
            src/main/java/org/jenkinsci/plugins/p4/scm/BranchesScmSource.java
            src/main/java/org/jenkinsci/plugins/p4/scm/P4Probe.java
            src/main/java/org/jenkinsci/plugins/p4/scm/P4ScmSourceDescriptor.java
            src/main/java/org/jenkinsci/plugins/p4/scm/StreamsScmSource.java
            src/main/java/org/jenkinsci/plugins/p4/tagging/TagAction.java
            src/test/java/org/jenkinsci/plugins/p4/DefaultEnvironment.java
            src/test/java/org/jenkinsci/plugins/p4/client/JenkinsfileTest.java
            src/test/java/org/jenkinsci/plugins/p4/client/PublishTest.java
            src/test/java/org/jenkinsci/plugins/p4/scm/PerforceScmSourceTest.java
            http://jenkins-ci.org/commit/p4-plugin/1e4f9531b0a47e558bb299bae3bc2160b89f70a9
            Log:
            JENKINS-34825 Added support for folder credentials to PerformSCMSource

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Allan Burdajewicz Path: src/main/java/org/jenkinsci/plugins/p4/ConfigurationListener.java src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java src/main/java/org/jenkinsci/plugins/p4/groovy/P4Groovy.java src/main/java/org/jenkinsci/plugins/p4/scm/AbstractP4ScmSource.java src/main/java/org/jenkinsci/plugins/p4/scm/BranchesScmSource.java src/main/java/org/jenkinsci/plugins/p4/scm/P4Probe.java src/main/java/org/jenkinsci/plugins/p4/scm/P4ScmSourceDescriptor.java src/main/java/org/jenkinsci/plugins/p4/scm/StreamsScmSource.java src/main/java/org/jenkinsci/plugins/p4/tagging/TagAction.java src/test/java/org/jenkinsci/plugins/p4/DefaultEnvironment.java src/test/java/org/jenkinsci/plugins/p4/client/JenkinsfileTest.java src/test/java/org/jenkinsci/plugins/p4/client/PublishTest.java src/test/java/org/jenkinsci/plugins/p4/scm/PerforceScmSourceTest.java http://jenkins-ci.org/commit/p4-plugin/1e4f9531b0a47e558bb299bae3bc2160b89f70a9 Log: JENKINS-34825 Added support for folder credentials to PerformSCMSource
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Paul Allen
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/p4/ConfigurationListener.java
            src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java
            src/main/java/org/jenkinsci/plugins/p4/changes/P4ChangeParser.java
            src/main/java/org/jenkinsci/plugins/p4/client/CleanupNotifier.java
            src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java
            src/main/java/org/jenkinsci/plugins/p4/client/ConnectionHelper.java
            src/main/java/org/jenkinsci/plugins/p4/credentials/P4CredentialsImpl.java
            src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4Step.java
            src/main/java/org/jenkinsci/plugins/p4/groovy/P4Groovy.java
            src/main/java/org/jenkinsci/plugins/p4/publish/PublishNotifier.java
            src/main/java/org/jenkinsci/plugins/p4/publish/PublishNotifierStep.java
            src/main/java/org/jenkinsci/plugins/p4/scm/AbstractP4ScmSource.java
            src/main/java/org/jenkinsci/plugins/p4/scm/BranchesScmSource.java
            src/main/java/org/jenkinsci/plugins/p4/scm/P4Probe.java
            src/main/java/org/jenkinsci/plugins/p4/scm/P4ScmSourceDescriptor.java
            src/main/java/org/jenkinsci/plugins/p4/scm/StreamsScmSource.java
            src/main/java/org/jenkinsci/plugins/p4/tagging/TagAction.java
            src/main/java/org/jenkinsci/plugins/p4/tasks/AbstractTask.java
            src/main/java/org/jenkinsci/plugins/p4/unshelve/UnshelveBuilder.java
            src/main/java/org/jenkinsci/plugins/p4/workflow/P4PublishStep.java
            src/main/java/org/jenkinsci/plugins/p4/workflow/P4Step.java
            src/main/resources/org/jenkinsci/plugins/p4/credentials/P4PasswordImpl/config.jelly
            src/main/resources/org/jenkinsci/plugins/p4/credentials/P4PasswordImpl/credentials.jelly
            src/main/resources/org/jenkinsci/plugins/p4/credentials/P4TicketImpl/config.jelly
            src/main/resources/org/jenkinsci/plugins/p4/credentials/P4TicketImpl/credentials.jelly
            src/test/java/org/jenkinsci/plugins/p4/DefaultEnvironment.java
            src/test/java/org/jenkinsci/plugins/p4/client/ConnectionTest.java
            src/test/java/org/jenkinsci/plugins/p4/client/JenkinsfileTest.java
            src/test/java/org/jenkinsci/plugins/p4/client/PublishTest.java
            src/test/java/org/jenkinsci/plugins/p4/credentials/PerforceCredentialsTest.java
            src/test/java/org/jenkinsci/plugins/p4/scm/PerforceScmSourceTest.java
            http://jenkins-ci.org/commit/p4-plugin/060fe50ca5d95e43c8d65c37ac10b70b8daced2f
            Log:
            Merge pull request #39 from Dohbedoh/JENKINS-34825

            Jenkins 34825

            Compare: https://github.com/jenkinsci/p4-plugin/compare/11b2394b7f86...060fe50ca5d9

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Paul Allen Path: pom.xml src/main/java/org/jenkinsci/plugins/p4/ConfigurationListener.java src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java src/main/java/org/jenkinsci/plugins/p4/changes/P4ChangeParser.java src/main/java/org/jenkinsci/plugins/p4/client/CleanupNotifier.java src/main/java/org/jenkinsci/plugins/p4/client/ClientHelper.java src/main/java/org/jenkinsci/plugins/p4/client/ConnectionHelper.java src/main/java/org/jenkinsci/plugins/p4/credentials/P4CredentialsImpl.java src/main/java/org/jenkinsci/plugins/p4/groovy/GetP4Step.java src/main/java/org/jenkinsci/plugins/p4/groovy/P4Groovy.java src/main/java/org/jenkinsci/plugins/p4/publish/PublishNotifier.java src/main/java/org/jenkinsci/plugins/p4/publish/PublishNotifierStep.java src/main/java/org/jenkinsci/plugins/p4/scm/AbstractP4ScmSource.java src/main/java/org/jenkinsci/plugins/p4/scm/BranchesScmSource.java src/main/java/org/jenkinsci/plugins/p4/scm/P4Probe.java src/main/java/org/jenkinsci/plugins/p4/scm/P4ScmSourceDescriptor.java src/main/java/org/jenkinsci/plugins/p4/scm/StreamsScmSource.java src/main/java/org/jenkinsci/plugins/p4/tagging/TagAction.java src/main/java/org/jenkinsci/plugins/p4/tasks/AbstractTask.java src/main/java/org/jenkinsci/plugins/p4/unshelve/UnshelveBuilder.java src/main/java/org/jenkinsci/plugins/p4/workflow/P4PublishStep.java src/main/java/org/jenkinsci/plugins/p4/workflow/P4Step.java src/main/resources/org/jenkinsci/plugins/p4/credentials/P4PasswordImpl/config.jelly src/main/resources/org/jenkinsci/plugins/p4/credentials/P4PasswordImpl/credentials.jelly src/main/resources/org/jenkinsci/plugins/p4/credentials/P4TicketImpl/config.jelly src/main/resources/org/jenkinsci/plugins/p4/credentials/P4TicketImpl/credentials.jelly src/test/java/org/jenkinsci/plugins/p4/DefaultEnvironment.java src/test/java/org/jenkinsci/plugins/p4/client/ConnectionTest.java src/test/java/org/jenkinsci/plugins/p4/client/JenkinsfileTest.java src/test/java/org/jenkinsci/plugins/p4/client/PublishTest.java src/test/java/org/jenkinsci/plugins/p4/credentials/PerforceCredentialsTest.java src/test/java/org/jenkinsci/plugins/p4/scm/PerforceScmSourceTest.java http://jenkins-ci.org/commit/p4-plugin/060fe50ca5d95e43c8d65c37ac10b70b8daced2f Log: Merge pull request #39 from Dohbedoh/ JENKINS-34825 Jenkins 34825 Compare: https://github.com/jenkinsci/p4-plugin/compare/11b2394b7f86...060fe50ca5d9
            Hide
            p4paul Paul Allen added a comment -

            1.6.0

            Show
            p4paul Paul Allen added a comment - 1.6.0

              People

              • Assignee:
                allan_burdajewicz Allan BURDAJEWICZ
                Reporter:
                joel_brown Joel Brown
              • Votes:
                2 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: