Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35020

Fix JSHint errors

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      Recently, some JSHint errors were introduced:

      [INFO] src/main/js/pluginSetupWizardGui.js: line 528, col 53, Expected '===' and instead saw '=='.
      [INFO] src/main/js/pluginSetupWizardGui.js: line 430, col 40, 'state' is defined but never used.
      [INFO] src/main/js/pluginSetupWizardGui.js: line 798, col 42, Expected '===' and instead saw '=='.
      [INFO] src/main/js/pluginSetupWizardGui.js: line 953, col 23, Expected '!==' and instead saw '!='.
      [INFO] src/main/js/pluginSetupWizardGui.js: line 954, col 16, 'setupWizardExtensions' is not defined.
      [INFO] 
      [INFO] 5 errors
      [INFO] src/main/js/upgradeWizard.js: line 2, col 9, '$' is defined but never used.
      [INFO] src/main/js/upgradeWizard.js: line 1, col 1, 'onSetupWizardInitialized' is not defined.
      [INFO] 
      [INFO] 2 errors
      [INFO] src/main/js/util/jenkins.js: line 201, col 49, 'receiver' is defined but never used.
      [INFO] src/main/js/util/jenkins.js: line 200, col 32, 'Proxy' is not defined.
      [INFO] 
      [INFO] 2 errors
      

      It seems this JENKINS-34438 is not working very well.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Manuel Recena
            Path:
            war/src/main/js/pluginSetupWizardGui.js
            war/src/main/js/upgradeWizard.js
            war/src/main/js/util/jenkins.js
            http://jenkins-ci.org/commit/jenkins/1fe92556c20feee48022ed0c586a4ec479ae232d
            Log:
            JENKINS-35020 Fixed some JSHint errors (#2368)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: war/src/main/js/pluginSetupWizardGui.js war/src/main/js/upgradeWizard.js war/src/main/js/util/jenkins.js http://jenkins-ci.org/commit/jenkins/1fe92556c20feee48022ed0c586a4ec479ae232d Log: JENKINS-35020 Fixed some JSHint errors (#2368) JENKINS-35020 Fixed some JSHint errors JENKINS-35020 @kzantow's comment was addressed JENKINS-35020 @kzantow's comment was addressed
            Show
            oleg_nenashev Oleg Nenashev added a comment - If we backport it, it also requires https://github.com/jenkinsci/jenkins/commit/a2e7661f212c4564fffa57ddc9b9ab92f2f2dc5b
            Hide
            oleg_nenashev Oleg Nenashev added a comment - - edited

            Released as Jenkins-2.7

            Show
            oleg_nenashev Oleg Nenashev added a comment - - edited Released as Jenkins-2.7

              People

              • Assignee:
                recena Manuel Recena Soto
                Reporter:
                recena Manuel Recena Soto
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: