Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35112

Should not be allowed to delete a ComputedFolder in progress

    Details

    • Similar Issues:

      Description

      If a FolderComputation is running:

      • AbstractFolder/tasks-new.jelly should not show the delete link
      • ComputedFolder.performDelete, if called anyway, should try hard to cancel any running computation

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            Noticed in conjunction with JENKINS-35111. Computation could not be aborted; and if you try to delete the organization folder anyway, things go crazy.

            Show
            jglick Jesse Glick added a comment - Noticed in conjunction with JENKINS-35111 . Computation could not be aborted; and if you try to delete the organization folder anyway, things go crazy.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            src/test/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolderTest.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/65682eb886e56f071e1c39772b3ab3cf7a00cbb6
            Log:
            [FIXED JENKINS-35112] Interrupt the computation when deleting

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java src/test/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolderTest.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/65682eb886e56f071e1c39772b3ab3cf7a00cbb6 Log: [FIXED JENKINS-35112] Interrupt the computation when deleting
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/ItemDeletion.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            src/main/resources/com/cloudbees/hudson/plugins/folder/Messages.properties
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/7d0c7811196d44726fb1b91d96ecd39ed357de19
            Log:
            JENKINS-35112 Re-implement based on JENKINS-35160 impl in core

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/ItemDeletion.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java src/main/resources/com/cloudbees/hudson/plugins/folder/Messages.properties http://jenkins-ci.org/commit/cloudbees-folder-plugin/7d0c7811196d44726fb1b91d96ecd39ed357de19 Log: JENKINS-35112 Re-implement based on JENKINS-35160 impl in core
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/1d06afb262c3547b61bc004aabeb480490ffae77
            Log:
            JENKINS-35112 Fix IDE error

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/1d06afb262c3547b61bc004aabeb480490ffae77 Log: JENKINS-35112 Fix IDE error
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/ItemDeletion.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            src/main/resources/com/cloudbees/hudson/plugins/folder/Messages.properties
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/37eeaf496b6e30450bc59158a0ae91bb37b9074b
            Log:
            Merge pull request #95 from stephenc/jenkins-35112-redux

            JENKINS-35112 Re-implement based on JENKINS-35160 impl in core

            Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/d43aa4d30bd6...37eeaf496b6e

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/ItemDeletion.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java src/main/resources/com/cloudbees/hudson/plugins/folder/Messages.properties http://jenkins-ci.org/commit/cloudbees-folder-plugin/37eeaf496b6e30450bc59158a0ae91bb37b9074b Log: Merge pull request #95 from stephenc/jenkins-35112-redux JENKINS-35112 Re-implement based on JENKINS-35160 impl in core Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/d43aa4d30bd6...37eeaf496b6e

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: