Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35170

GHPRB latest version incorrectly identifying the base branch for merge

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Using Jenkins 2.6

      Upgrading to 1.32.2 called my pull requests to identify the wrong base branch, as a result PRs started being built against a very old commit SHA.

      Downgrading to 1.31.4 fixed the issue.

        Attachments

          Activity

          Hide
          marcusahle Marcus Ahle added a comment -

          +1 - Running into the same issue. Jenkins is checking out an older commit. For us, the correct commit hash does show on the build page

          GitHub pull request #531 of commit abcdxyz(example hash), no merge conflicts.
          

          But then if you look at the console output you see jenkins checking out an old commit. I've tried using both ${ghprbActualCommit} and ${sha1} as the branch identifier.

          Show
          marcusahle Marcus Ahle added a comment - +1 - Running into the same issue. Jenkins is checking out an older commit. For us, the correct commit hash does show on the build page GitHub pull request #531 of commit abcdxyz(example hash), no merge conflicts. But then if you look at the console output you see jenkins checking out an old commit. I've tried using both ${ghprbActualCommit} and ${sha1} as the branch identifier.
          Show
          johnny_shields Johnny Shields added a comment - Same as https://github.com/jenkinsci/ghprb-plugin/issues/352
          Hide
          dantliff David Antliff added a comment -

          Seen here with Jenkins 2.7 and GHPRB 1.32.2 - wrong commit is used for the job. Reverted to 1.31.3 for now.

          Show
          dantliff David Antliff added a comment - Seen here with Jenkins 2.7 and GHPRB 1.32.2 - wrong commit is used for the job. Reverted to 1.31.3 for now.
          Hide
          ickersep ickersep added a comment -

          For me this happens when I define a parameter with the same name as one defined by ghprb-plugin. Things start to work again when I remove the parameter.

          Show
          ickersep ickersep added a comment - For me this happens when I define a parameter with the same name as one defined by ghprb-plugin. Things start to work again when I remove the parameter.
          Hide
          gtirloni Giovanni Tirloni added a comment -

          We are having the exact same issue with Jenkins 2.14 and GHPRB 1.32.8 (also tried 1.32.1, 1.31.4, 1.31.1 and 1.30.1).

          GitHub pull request #1 of commit 72632197f926fb54a109376a4ed996aea3b6cf7b, no merge conflicts.
          Checking out Revision 8bf72ee7b68988da0dcf786e75cade81ad98bfac (origin/master)

          It sees the PR commit and checks out the old revision anyway.

          Show
          gtirloni Giovanni Tirloni added a comment - We are having the exact same issue with Jenkins 2.14 and GHPRB 1.32.8 (also tried 1.32.1, 1.31.4, 1.31.1 and 1.30.1). GitHub pull request #1 of commit 72632197f926fb54a109376a4ed996aea3b6cf7b, no merge conflicts. Checking out Revision 8bf72ee7b68988da0dcf786e75cade81ad98bfac (origin/master) It sees the PR commit and checks out the old revision anyway.
          Hide
          dalejoel Joel Dale added a comment -

          I'm on 1.33.1 and from what I can tell the right sha1 is being used. The console output from the build is pointing to the right checkpoint. I also have manually added every parameter that the plugin was trying to write.

          So is this still a bug?

          Show
          dalejoel Joel Dale added a comment - I'm on 1.33.1 and from what I can tell the right sha1 is being used. The console output from the build is pointing to the right checkpoint. I also have manually added every parameter that the plugin was trying to write. So is this still a bug?

            People

            • Assignee:
              Unassigned
              Reporter:
              johnny_shields Johnny Shields
            • Votes:
              6 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated: