Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35175

Make SSE connection keep-alive configurable

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      1.0-m11, 1.0-m12

      Description

      Doing this should get rid of a scary (but harmless) looking browser console errors when the SSE connection is unexpectedly dropped e.g. by an intermediary proxy/gateway.

      By doing this periodically from the client side (disconnecting and reconnecting), we avoid the user seeing this.

      The error looks scary but is actually fine because the SSE EventSource auto-reconnects.

      Something to consider though .... we might need to do some sort of "store and forward" at the gateway for when messages arrive during a reconnect. See JENKINS-36238

        Attachments

          Issue Links

            Activity

            tfennelly Tom FENNELLY created issue -
            jamesdumay James Dumay made changes -
            Field Original Value New Value
            Epic Link JENKINS-35737 [ 171801 ]
            tfennelly Tom FENNELLY made changes -
            Link This issue is duplicated by JENKINS-35764 [ JENKINS-35764 ]
            tfennelly Tom FENNELLY made changes -
            Link This issue is related to JENKINS-36054 [ JENKINS-36054 ]
            jamesdumay James Dumay made changes -
            Sprint 1.0-m11 [ 71 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            tfennelly Tom FENNELLY made changes -
            Priority Minor [ 4 ] Critical [ 2 ]
            tfennelly Tom FENNELLY made changes -
            Priority Critical [ 2 ] Minor [ 4 ]
            tfennelly Tom FENNELLY made changes -
            Link This issue is related to JENKINS-36238 [ JENKINS-36238 ]
            tfennelly Tom FENNELLY made changes -
            Description Doing this should get rid of a scary (but harmless) looking browser console errors when the SSE connection is unexpectedly dropped e.g. by an intermediary proxy/gateway.

            By doing this periodically from the client side (disconnecting and reconnecting), we avoid the user seeing this.

            The error looks scary but is actually fine because the SSE EventSource auto-reconnects.

            Something to consider though .... we might need to do some sort of "store and forward" at the gateway for when messages arrive during a reconnect.
            Doing this should get rid of a scary (but harmless) looking browser console errors when the SSE connection is unexpectedly dropped e.g. by an intermediary proxy/gateway.

            By doing this periodically from the client side (disconnecting and reconnecting), we avoid the user seeing this.

            The error looks scary but is actually fine because the SSE EventSource auto-reconnects.

            Something to consider though .... we might need to do some sort of "store and forward" at the gateway for when messages arrive during a reconnect. See JENKINS-36238
            jamesdumay James Dumay made changes -
            Issue Type Improvement [ 4 ] Bug [ 1 ]
            tfennelly Tom FENNELLY made changes -
            Issue Type Bug [ 1 ] Story [ 10002 ]
            jamesdumay James Dumay made changes -
            Sprint 1.0-m11 [ 71 ] 1.0-m11, 1.0-m12 [ 71, 76 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 171398 ] JNJira + In-Review [ 184295 ]
            Hide
            tfennelly Tom FENNELLY added a comment -

            Not really needed now because we have the connection timeout set so low that this should no longer be an issue. Those scary browser console errors (as seen on dogfood) should be a thing of the past now too.

            Show
            tfennelly Tom FENNELLY added a comment - Not really needed now because we have the connection timeout set so low that this should no longer be an issue. Those scary browser console errors (as seen on dogfood) should be a thing of the past now too.
            tfennelly Tom FENNELLY made changes -
            Status Open [ 1 ] Closed [ 6 ]
            Resolution Won't Do [ 10001 ]

              People

              • Assignee:
                tfennelly Tom FENNELLY
                Reporter:
                tfennelly Tom FENNELLY
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: