Details

    • Similar Issues:

      Description

      There are several problems with the way ping threads are set up.

      • ChannelPinger sets up a master → agent ping, and also an agent → master ping. But Launcher sets up another slave → master ping for JNLP agents (not for master-initiated ones)...and is more awkward to disable, since you must pass a system property to each agent's launch line.
      • As noted here, the agent → master ping from ChannelPinger does not work at all, due to a mistake in usage of PingFailureAnalyzer. (Oddly, Kohsuke Kawaguchi introduced this extension point claiming it could be implemented in ssh-slaves, but apparently never did so there, or anywhere else!)
      • The Launcher variant fails to override the nondeprecated onDead variant that gets a stack trace.

        Attachments

          Issue Links

            Activity

            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "remoting PR 85 (Web Link)" [ 14349 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "core PR 2377 (Web Link)" [ 14350 ]
            jglick Jesse Glick made changes -
            Link This issue is duplicated by JENKINS-34887 [ JENKINS-34887 ]
            oleg_nenashev Oleg Nenashev made changes -
            Assignee Jesse Glick [ jglick ] Oleg Nenashev [ oleg_nenashev ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "core PR 2403 (Web Link)" [ 14444 ]
            oleg_nenashev Oleg Nenashev made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            olivergondza Oliver Gondža made changes -
            Labels remoting 2.7.2-fixed remoting
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 171413 ] JNJira + In-Review [ 199096 ]
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal OSS-1013 (Web Link)" [ 18786 ]

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: