Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35490

JENKINS-27387 broke binding to credentials parameter for Freestyle jobs

    Details

    • Similar Issues:

      Description

      I cannot use a credentials parameter when adding a binding in a Freestyle job

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper/config.jelly
            http://jenkins-ci.org/commit/credentials-binding-plugin/5e2f3a81f8290044d7b2e25dad2d49570147a10a
            Log:
            [FIXED JENKINS-35490] Ensure the expressionAllowed variable is captured for the hetero-add

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper/config.jelly http://jenkins-ci.org/commit/credentials-binding-plugin/5e2f3a81f8290044d7b2e25dad2d49570147a10a Log: [FIXED JENKINS-35490] Ensure the expressionAllowed variable is captured for the hetero-add
            Hide
            stephenconnolly Stephen Connolly added a comment -

            So the issue here is that the expressionAllowed variable is not being captured in the closure for the hetero-add

            Show
            stephenconnolly Stephen Connolly added a comment - So the issue here is that the expressionAllowed variable is not being captured in the closure for the hetero-add
            Hide
            jglick Jesse Glick added a comment - - edited

            I am sure I tested this for both project types…did something regress here?

            Show
            jglick Jesse Glick added a comment - - edited I am sure I tested this for both project types…did something regress here?
            Hide
            stephenconnolly Stephen Connolly added a comment -

            Jesse Glick it works if you load an existing job with an existing configuration... when you are configuring a new job from scratch is when it blows up.

            Show
            stephenconnolly Stephen Connolly added a comment - Jesse Glick it works if you load an existing job with an existing configuration... when you are configuring a new job from scratch is when it blows up.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper/config.jelly
            http://jenkins-ci.org/commit/credentials-binding-plugin/3262d165e7be227f7a5ae567723446188ccd26bd
            Log:
            Merge pull request #17 from jenkinsci/jenkins-35490

            [FIXED JENKINS-35490] Ensure the expressionAllowed variable is captured for the hetero-add

            Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/dfe5288c5aa0...3262d165e7be

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/resources/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper/config.jelly http://jenkins-ci.org/commit/credentials-binding-plugin/3262d165e7be227f7a5ae567723446188ccd26bd Log: Merge pull request #17 from jenkinsci/jenkins-35490 [FIXED JENKINS-35490] Ensure the expressionAllowed variable is captured for the hetero-add Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/dfe5288c5aa0...3262d165e7be
            Hide
            jglick Jesse Glick added a comment -

            Ah, because of the lazy-loaded block. Right, I must have forgotten to test that.

            Show
            jglick Jesse Glick added a comment - Ah, because of the lazy-loaded block. Right, I must have forgotten to test that.

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                stephenconnolly Stephen Connolly
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: