Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35571

Add support for pipeline to plot plugin

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: plot-plugin
    • Labels:
      None
    • Similar Issues:

      Description

      Add support for pipeline.
      I have been tasked with adding support for pipeline plugin to plot plugin. I'm completely new to Jenkins so any input on this would be greatly appreciated. I have come a great deal on the way, I now have a fully functional plugin, the only problem is that it only supports Pipeline. The good thing is that you can install it side by side with the original Plot plugin.

      A more experienced developer might be able to merge the two plugins two one, something I was not able to do.

      Feel free to have a look here:
      https://github.com/MarkusDNC/plot-plugin

        Attachments

          Activity

          Hide
          mtraynham Matt Traynham added a comment -

          Markus Axelsson are you able to make this work without any changes to the plugin itself? If so, can you provide an example? I'd be really interested in knowing how to do this.

          Show
          mtraynham Matt Traynham added a comment - Markus Axelsson are you able to make this work without any changes to the plugin itself? If so, can you provide an example? I'd be really interested in knowing how to do this.
          Hide
          max_hms Markus Axelsson added a comment -

          Matt Traynham, I've come quite a bit in the process of making it work but I have made a lot of modifications to the plugin source code. And I still have a long way to go, because I would like to be able to push it up to the main repo so users will get an update of the plugin but much of this is all new to me. This was certainly not the easiest plugin to modify.

          Show
          max_hms Markus Axelsson added a comment - Matt Traynham , I've come quite a bit in the process of making it work but I have made a lot of modifications to the plugin source code. And I still have a long way to go, because I would like to be able to push it up to the main repo so users will get an update of the plugin but much of this is all new to me. This was certainly not the easiest plugin to modify.
          Hide
          max_hms Markus Axelsson added a comment - - edited

          Matt Traynham I now have a fully functional plugin that support Pipeline. It only supports Pipeline so at the moment you install it side-by-side with the original one. The testing we have done at our company shows no issues with the plugin. If you also would like to try you can clone my repo at https://github.com/MarkusDNC/plot-plugin or if you would like I can e-mail the hpi for manual installation.

          Show
          max_hms Markus Axelsson added a comment - - edited Matt Traynham I now have a fully functional plugin that support Pipeline. It only supports Pipeline so at the moment you install it side-by-side with the original one. The testing we have done at our company shows no issues with the plugin. If you also would like to try you can clone my repo at https://github.com/MarkusDNC/plot-plugin or if you would like I can e-mail the hpi for manual installation.
          Hide
          batmat Baptiste Mathus added a comment -

          Markus Axelsson hi, it would be great if you could consider contributing this improvement upstream. Do you need help with how to do that?
          Looking at the history, I am not sure what you did. Did you copy the original source code without forking it actually?

          Show
          batmat Baptiste Mathus added a comment - Markus Axelsson hi, it would be great if you could consider contributing this improvement upstream. Do you need help with how to do that? Looking at the history, I am not sure what you did. Did you copy the original source code without forking it actually?
          Hide
          yuav Jon Skarpeteig added a comment -

          Any update on this issue?

          Show
          yuav Jon Skarpeteig added a comment - Any update on this issue?
          Hide
          tib Timmy Brolin added a comment -

          Markus did this as a student project at our company. He no longer works for us.
          To my knowledge, he copied the original source, and managed to make it work with pipeline. We have been using it for some time, and it works fairly well.

          But it ONLY supports pipeline. As I understand it, the changes needed to make pipeline work in this plugin were significant, and broke the GUI flow.

          We don't have anyone in our company with the Jenkins knowledge needed to make both flows work at the same time in this plugin. No one is currently working on this.

          Show
          tib Timmy Brolin added a comment - Markus did this as a student project at our company. He no longer works for us. To my knowledge, he copied the original source, and managed to make it work with pipeline. We have been using it for some time, and it works fairly well. But it ONLY supports pipeline. As I understand it, the changes needed to make pipeline work in this plugin were significant, and broke the GUI flow. We don't have anyone in our company with the Jenkins knowledge needed to make both flows work at the same time in this plugin. No one is currently working on this.
          Hide
          vgaidarji Veaceslav Gaidarji added a comment - - edited

          I've opened a PR to the original repository which includes changes from https://github.com/MarkusDNC/plot-plugin.
          Would be nice if someone can test it and provide feedback.

          Show
          vgaidarji Veaceslav Gaidarji added a comment - - edited I've opened a PR to the original repository which includes changes from https://github.com/MarkusDNC/plot-plugin . Would be nice if someone can test it and provide feedback.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Veaceslav Gaidarji
          Path:
          .gitignore
          pom.xml
          src/main/java/hudson/plugins/plot/CSVSeries.java
          src/main/java/hudson/plugins/plot/MatrixPlotAction.java
          src/main/java/hudson/plugins/plot/MatrixPlotPublisher.java
          src/main/java/hudson/plugins/plot/Plot.java
          src/main/java/hudson/plugins/plot/PlotAction.java
          src/main/java/hudson/plugins/plot/PlotBuildAction.java
          src/main/java/hudson/plugins/plot/PlotBuilder.java
          src/main/java/hudson/plugins/plot/PlotCategoryDataset.java
          src/main/java/hudson/plugins/plot/PlotDescriptor.java
          src/main/java/hudson/plugins/plot/PlotPublisher.java
          src/main/java/hudson/plugins/plot/PlotReport.java
          src/main/java/hudson/plugins/plot/PropertiesSeries.java
          src/main/java/hudson/plugins/plot/Series.java
          src/main/java/hudson/plugins/plot/SeriesFactory.java
          src/main/java/hudson/plugins/plot/XMLSeries.java
          src/main/resources/hudson/plugins/plot/AbstractPlotPublisher/config.jelly
          src/main/resources/hudson/plugins/plot/AbstractPlotPublisher/help.jelly
          src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly
          src/main/resources/hudson/plugins/plot/MatrixPlotAction/index.jelly
          src/main/resources/hudson/plugins/plot/Messages.properties
          src/main/resources/hudson/plugins/plot/PlotAction/index.jelly
          src/main/resources/hudson/plugins/plot/PlotBuilder/config.jelly
          src/main/resources/hudson/plugins/plot/PlotReport/index.jelly
          src/main/resources/hudson/plugins/plot/PlotReport/table_report.jelly
          src/main/resources/hudson/plugins/plot/PropertiesSeries/config.jelly
          src/main/resources/hudson/plugins/plot/XMLSeries/config.jelly
          src/main/resources/index.jelly
          src/test/java/hudson/plugins/plot/CSVReaderTest.java
          src/test/java/hudson/plugins/plot/CSVSeriesTest.java
          src/test/java/hudson/plugins/plot/PlotTest.java
          src/test/java/hudson/plugins/plot/PropertiesSeriesTest.java
          src/test/java/hudson/plugins/plot/SeriesFactoryTest.java
          src/test/java/hudson/plugins/plot/SeriesTestCase.java
          src/test/java/hudson/plugins/plot/XMLSeriesTest.java
          http://jenkins-ci.org/commit/plot-plugin/7141331f3e7c5e55638328ce519a1daefec9e038
          Log:
          Merge pull request #32 from jenkinsci/vgaidarji/make-compatible-with-pipeline

          JENKINS-35571 Make compatible with Pipeline

          Compare: https://github.com/jenkinsci/plot-plugin/compare/2995edb342bc...7141331f3e7c

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Veaceslav Gaidarji Path: .gitignore pom.xml src/main/java/hudson/plugins/plot/CSVSeries.java src/main/java/hudson/plugins/plot/MatrixPlotAction.java src/main/java/hudson/plugins/plot/MatrixPlotPublisher.java src/main/java/hudson/plugins/plot/Plot.java src/main/java/hudson/plugins/plot/PlotAction.java src/main/java/hudson/plugins/plot/PlotBuildAction.java src/main/java/hudson/plugins/plot/PlotBuilder.java src/main/java/hudson/plugins/plot/PlotCategoryDataset.java src/main/java/hudson/plugins/plot/PlotDescriptor.java src/main/java/hudson/plugins/plot/PlotPublisher.java src/main/java/hudson/plugins/plot/PlotReport.java src/main/java/hudson/plugins/plot/PropertiesSeries.java src/main/java/hudson/plugins/plot/Series.java src/main/java/hudson/plugins/plot/SeriesFactory.java src/main/java/hudson/plugins/plot/XMLSeries.java src/main/resources/hudson/plugins/plot/AbstractPlotPublisher/config.jelly src/main/resources/hudson/plugins/plot/AbstractPlotPublisher/help.jelly src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly src/main/resources/hudson/plugins/plot/MatrixPlotAction/index.jelly src/main/resources/hudson/plugins/plot/Messages.properties src/main/resources/hudson/plugins/plot/PlotAction/index.jelly src/main/resources/hudson/plugins/plot/PlotBuilder/config.jelly src/main/resources/hudson/plugins/plot/PlotReport/index.jelly src/main/resources/hudson/plugins/plot/PlotReport/table_report.jelly src/main/resources/hudson/plugins/plot/PropertiesSeries/config.jelly src/main/resources/hudson/plugins/plot/XMLSeries/config.jelly src/main/resources/index.jelly src/test/java/hudson/plugins/plot/CSVReaderTest.java src/test/java/hudson/plugins/plot/CSVSeriesTest.java src/test/java/hudson/plugins/plot/PlotTest.java src/test/java/hudson/plugins/plot/PropertiesSeriesTest.java src/test/java/hudson/plugins/plot/SeriesFactoryTest.java src/test/java/hudson/plugins/plot/SeriesTestCase.java src/test/java/hudson/plugins/plot/XMLSeriesTest.java http://jenkins-ci.org/commit/plot-plugin/7141331f3e7c5e55638328ce519a1daefec9e038 Log: Merge pull request #32 from jenkinsci/vgaidarji/make-compatible-with-pipeline JENKINS-35571 Make compatible with Pipeline Compare: https://github.com/jenkinsci/plot-plugin/compare/2995edb342bc...7141331f3e7c
          Hide
          vgaidarji Veaceslav Gaidarji added a comment - - edited

          2.0.0 version of the plugin should be available soon. It brings compatibility with Jenkins Pipeline plugin.

          Show
          vgaidarji Veaceslav Gaidarji added a comment - - edited 2.0.0 version of the plugin should be available soon. It brings compatibility with Jenkins Pipeline plugin.

            People

            • Assignee:
              vgaidarji Veaceslav Gaidarji
              Reporter:
              max_hms Markus Axelsson
            • Votes:
              15 Vote for this issue
              Watchers:
              22 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: