Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35774

ExtensionPoint wrapper element should have a class

    Details

    • Similar Issues:
    • Epic Link:

      Description

      Allowing it to styled e.g. making it inline-block be default.

        Attachments

          Activity

          Hide
          michaelneale Michael Neale added a comment -

          Tom FENNELLY is this still needed?

          Show
          michaelneale Michael Neale added a comment - Tom FENNELLY is this still needed?
          Hide
          sophistifunk Josh McDonald added a comment -

          This doesn't seem like a good idea to me. If your specific extensionpoint needs a className, give it one. IMO ExtensionPoint should be as un-opinionated as possible.

          Show
          sophistifunk Josh McDonald added a comment - This doesn't seem like a good idea to me. If your specific extensionpoint needs a className, give it one. IMO ExtensionPoint should be as un-opinionated as possible.
          Hide
          tfennelly Tom FENNELLY added a comment - - edited

          I was referring to the <div> that ExtensionPoint.jsx adds (see its render function) to wrap the content being rendered from those specific extension point impls. The render functions adds those <div> elements and then the __renderAllExtensions converts them into the react leaf nodes and the specific extension point impl content gets dropped inside that div (or at least that is how I interpret it).

          So if there's a way of getting rid of that wrapping div then that'd do the trick. As is, every extension point is a block displayed element.

          Show
          tfennelly Tom FENNELLY added a comment - - edited I was referring to the <div> that ExtensionPoint.jsx adds (see its render function) to wrap the content being rendered from those specific extension point impls. The render functions adds those <div> elements and then the __renderAllExtensions converts them into the react leaf nodes and the specific extension point impl content gets dropped inside that div (or at least that is how I interpret it). So if there's a way of getting rid of that wrapping div then that'd do the trick. As is, every extension point is a block displayed element.
          Hide
          sophistifunk Josh McDonald added a comment -

          Right, I got you now, that's definitely a good idea. I think we might want to look at parameterising the TagName as well.

          Show
          sophistifunk Josh McDonald added a comment - Right, I got you now, that's definitely a good idea. I think we might want to look at parameterising the TagName as well.

            People

            • Assignee:
              Unassigned
              Reporter:
              jamesdumay James Dumay
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: