Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35845

Internationalisation for Blue Ocean and JDL

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      pacific, atlantic, 1.0-b05/b-06, indian

      Description

      In Scope

      • All strings and formatting should be localisable
      • Short explanation on how we localise components and the app put in a README.md
      • Go through and extract all our current strings

      Notes

        Attachments

          Issue Links

            Activity

            Hide
            michaelneale Michael Neale added a comment - - edited

            Keith Zantow - you were taking a look at this? Thorsten Scherler might want to check with keith before opening a PR (if work hasn't started).

            Also Keith - should route localisation be part of the scope of this? (do we want to do that? )
            EDIT: I think route i18n should be another ticket (as it is likely a hairy beast)

            Show
            michaelneale Michael Neale added a comment - - edited Keith Zantow - you were taking a look at this? Thorsten Scherler might want to check with keith before opening a PR (if work hasn't started). Also Keith - should route localisation be part of the scope of this? (do we want to do that? ) EDIT: I think route i18n should be another ticket (as it is likely a hairy beast)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Thorsten Scherler
            Path:
            core/src/main/java/hudson/util/HttpResponses.java
            core/src/main/java/jenkins/util/ResourceBundleUtil.java
            test/src/test/java/jenkins/I18nTest.java
            http://jenkins-ci.org/commit/jenkins/ab16e52519260c0e9398f15256ed8061a4c00bf0
            Log:
            [FIX JENKINS-35845] Internationalisation for Blue Ocean and JDL (#2586)

            • Load i18n resource bundles from plugins if not found in jenkins core

            Signed-off-by: Thorsten Scherler <scherler@gmail.com>

            • Issue 404 response for missing i18n resource bundles

            Currently issues a 200 with an "error" response payload. This change still issues the error response payload, but also sets the HTTP response.

            Signed-off-by: Thorsten Scherler <scherler@gmail.com>

            • JENKINS-35845 add test for getting locale from plugin. fix comments from oleg.
            • eslint - formating changes and fix offences
            • eslint - formating changes and fix offences
            • JENKINS-35845 remove code concerning 404 response. Fix resourceBundle test by prevent NPE to happen
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: core/src/main/java/hudson/util/HttpResponses.java core/src/main/java/jenkins/util/ResourceBundleUtil.java test/src/test/java/jenkins/I18nTest.java http://jenkins-ci.org/commit/jenkins/ab16e52519260c0e9398f15256ed8061a4c00bf0 Log: [FIX JENKINS-35845] Internationalisation for Blue Ocean and JDL (#2586) Load i18n resource bundles from plugins if not found in jenkins core Signed-off-by: Thorsten Scherler <scherler@gmail.com> Issue 404 response for missing i18n resource bundles Currently issues a 200 with an "error" response payload. This change still issues the error response payload, but also sets the HTTP response. Signed-off-by: Thorsten Scherler <scherler@gmail.com> JENKINS-35845 Fix test since we return now a 404 JENKINS-35845 add test for getting locale from plugin. fix comments from oleg. JENKINS-35845 Fix description JENKINS-35845 Update PR with comments from Oleg JENKINS-35845 Add feedback from tom eslint - formating changes and fix offences eslint - formating changes and fix offences JENKINS-35845 remove code concerning 404 response. Fix resourceBundle test by prevent NPE to happen JENKINS-35845 Link to issue on which we introduced the test
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            The fix for the core is integrated towards 2.27.
            I consider the core fix as a bug, hence the patch is marked as lts-candidate

            Show
            oleg_nenashev Oleg Nenashev added a comment - The fix for the core is integrated towards 2.27. I consider the core fix as a bug, hence the patch is marked as lts-candidate
            Hide
            michaelneale Michael Neale added a comment -

            Not sure why this one was marked as closed when PR is still open...

            Show
            michaelneale Michael Neale added a comment - Not sure why this one was marked as closed when PR is still open...
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Michael Neale Because the core fix commit text contains the "FIX" text, hence Jenkins bot automatically closed it.
            You guys should not patch multiple components in a single task At least it complicates backporting of the fix to 2.19.3

            Show
            oleg_nenashev Oleg Nenashev added a comment - Michael Neale Because the core fix commit text contains the "FIX" text, hence Jenkins bot automatically closed it. You guys should not patch multiple components in a single task At least it complicates backporting of the fix to 2.19.3
            Hide
            jamesdumay James Dumay added a comment -

            Thorsten Scherler before closing this ticket out please write some documentation and a cool blog post

            (I can help write the post if you need it)

            Show
            jamesdumay James Dumay added a comment - Thorsten Scherler before closing this ticket out please write some documentation and a cool blog post (I can help write the post if you need it)
            Hide
            michaelneale Michael Neale added a comment -

            Oleg Nenashev is it ok to have this open or does it have to be closed to simplify the backporting? we can close this and open a ticket for the front end work side of things if that helps?

            Show
            michaelneale Michael Neale added a comment - Oleg Nenashev is it ok to have this open or does it have to be closed to simplify the backporting? we can close this and open a ticket for the front end work side of things if that helps?
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Michael Neale it would be helpful

            Show
            oleg_nenashev Oleg Nenashev added a comment - Michael Neale it would be helpful
            Hide
            michaelneale Michael Neale added a comment -

            Closing this as this tracks the core improvement

            Show
            michaelneale Michael Neale added a comment - Closing this as this tracks the core improvement
            Hide
            michaelneale Michael Neale added a comment -

            Oleg Nenashev ok I made https://issues.jenkins-ci.org/browse/JENKINS-39225 to track the blue ocean side - you can take over this ticket if you like.

            Show
            michaelneale Michael Neale added a comment - Oleg Nenashev ok I made https://issues.jenkins-ci.org/browse/JENKINS-39225 to track the blue ocean side - you can take over this ticket if you like.
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Converted it to the bug, since Internalization support is an expected behavior for resource logic in Jenkins

            Show
            oleg_nenashev Oleg Nenashev added a comment - Converted it to the bug, since Internalization support is an expected behavior for resource logic in Jenkins
            Hide
            jglick Jesse Glick added a comment -

            This seems like a feature (a kind of API), not a bug. There is nothing broken in 2.19.3 without this IIUC—just some stuff Blue Ocean is not able to do.

            Show
            jglick Jesse Glick added a comment - This seems like a feature (a kind of API), not a bug. There is nothing broken in 2.19.3 without this IIUC—just some stuff Blue Ocean is not able to do.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Thorsten Scherler
            Path:
            core/src/main/java/hudson/util/HttpResponses.java
            core/src/main/java/jenkins/util/ResourceBundleUtil.java
            test/src/test/java/jenkins/I18nTest.java
            http://jenkins-ci.org/commit/jenkins/288a66dfabac0a31ce799cc3eaf285dc801cd668
            Log:
            [FIX JENKINS-35845] Internationalisation for Blue Ocean and JDL (#2586)

            • Load i18n resource bundles from plugins if not found in jenkins core

            Signed-off-by: Thorsten Scherler <scherler@gmail.com>

            • Issue 404 response for missing i18n resource bundles

            Currently issues a 200 with an "error" response payload. This change still issues the error response payload, but also sets the HTTP response.

            Signed-off-by: Thorsten Scherler <scherler@gmail.com>

            • JENKINS-35845 add test for getting locale from plugin. fix comments from oleg.
            • eslint - formating changes and fix offences
            • eslint - formating changes and fix offences
            • JENKINS-35845 remove code concerning 404 response. Fix resourceBundle test by prevent NPE to happen

            (cherry picked from commit ab16e52519260c0e9398f15256ed8061a4c00bf0)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: core/src/main/java/hudson/util/HttpResponses.java core/src/main/java/jenkins/util/ResourceBundleUtil.java test/src/test/java/jenkins/I18nTest.java http://jenkins-ci.org/commit/jenkins/288a66dfabac0a31ce799cc3eaf285dc801cd668 Log: [FIX JENKINS-35845] Internationalisation for Blue Ocean and JDL (#2586) Load i18n resource bundles from plugins if not found in jenkins core Signed-off-by: Thorsten Scherler <scherler@gmail.com> Issue 404 response for missing i18n resource bundles Currently issues a 200 with an "error" response payload. This change still issues the error response payload, but also sets the HTTP response. Signed-off-by: Thorsten Scherler <scherler@gmail.com> JENKINS-35845 Fix test since we return now a 404 JENKINS-35845 add test for getting locale from plugin. fix comments from oleg. JENKINS-35845 Fix description JENKINS-35845 Update PR with comments from Oleg JENKINS-35845 Add feedback from tom eslint - formating changes and fix offences eslint - formating changes and fix offences JENKINS-35845 remove code concerning 404 response. Fix resourceBundle test by prevent NPE to happen JENKINS-35845 Link to issue on which we introduced the test (cherry picked from commit ab16e52519260c0e9398f15256ed8061a4c00bf0)

              People

              • Assignee:
                tscherler Thorsten Scherler
                Reporter:
                jamesdumay James Dumay
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: