Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35858

admin - the redux store expose currentX we should drop that and use a pointer to the runs array

    Details

    • Similar Issues:
    • Epic Link:

      Description

      logically ... the runs in "currentRuns" must also exist under "runs". The currentRuns is more a helper for the view, but we should just use a pointer in the array as currentRuns selector and not a state variable.

      https://github.com/reactjs/reselect#accessing-react-props-in-selectors

      [ACTION_TYPES.GET_CURRENT_RUN_DATA](state, props,

      { payload }

      ): State

      { const currentRuns = state.get('runs'); return currentRuns[props.pipeline]; }

      ,

        Attachments

          Activity

          jamesdumay James Dumay created issue -
          michaelneale Michael Neale made changes -
          Field Original Value New Value
          Epic Link UX-35 [ 24725 ]
          admin V R made changes -
          Project Import Tue Jun 14 12:50:41 JST 2016 [ 1465876241198 ]
          rtyler R. Tyler Croy made changes -
          Project Import Wed Jun 15 02:53:18 UTC 2016 [ 1465959198925 ]
          jamesdumay James Dumay made changes -
          Labels blueocean technical-debt blueocean blueocean-imported technical-debt
          jamesdumay James Dumay made changes -
          Project User Experience [ 10600 ] Jenkins [ 10172 ]
          Key UX-474 JENKINS-35858
          Workflow Product Backlog April 2016 V2 [ 172168 ] JNJira [ 172478 ]
          Status To Do [ 10003 ] Open [ 1 ]
          Component/s blueocean-plugin [ 21481 ]
          admin V R made changes -
          Assignee Thorsten Scherler [ tscherler ]
          admin V R made changes -
          Priority Medium [ 3 ] Major [ 10000 ]
          admin V R made changes -
          Reporter Thorsten Scherler [ tscherler ] James Dumay [ jamesdumay ]
          admin V R made changes -
          Reporter James Dumay [ jdumay ] James Dumay [ jdumay ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 172478 ] JNJira + In-Review [ 184593 ]
          jamesdumay James Dumay made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Won't Fix [ 2 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              jamesdumay James Dumay
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: