Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35866

Handle jobs that are stored within folders

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      1.0-japan-m9, 1.0-m10

      Description

      When items are shown on the main dashboard (/pipelines) they may include items that are from nested folders.
      When clicking on an item that is in a folder, it needs to be loaded with the URI reflecting what its folder path is.

      In Scope

      • When UX-276 is completed we need to handle nested folder jobs in the frontend
      • Always use the fullName as the display name
      • Browsing to a pipeline should work if its in a folder
      • Browsing to a folder should 404
        Browsing to a folder just show a list of the folder contents as if that folder was the "root" of the dashboard
        [1:24 PM] James Dumay: e.g if I browse to /org/my/sub/folder/
        [1:24 PM] James Dumay: show everything under /org/my/sub/folder/ as it is "/"

        Attachments

          Issue Links

            Activity

            jamesdumay James Dumay created issue -
            jamesdumay James Dumay made changes -
            Field Original Value New Value
            Epic Link UX-35 [ 24725 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Link This issue is blocked by UX-276 [ UX-276 ]
            michaelneale Michael Neale made changes -
            Comment [ This is unblocked now if anyone is interested in it ]
            michaelneale Michael Neale made changes -
            Link This issue is blocked by UX-196 [ UX-196 ]
            jamesdumay James Dumay made changes -
            Link This issue relates to UX-310 [ UX-310 ]
            Hide
            michaelneale Michael Neale added a comment -

            [~vpandey] Some clarification: in https://github.com/jenkinsci/blueocean-plugin/tree/master/blueocean-rest - I can see how folders are navigated, but it isn't clear to me how you know something is a folder to start with - is there something missing?

            Show
            michaelneale Michael Neale added a comment - [~vpandey] Some clarification: in https://github.com/jenkinsci/blueocean-plugin/tree/master/blueocean-rest - I can see how folders are navigated, but it isn't clear to me how you know something is a folder to start with - is there something missing?
            Hide
            michaelneale Michael Neale added a comment - - edited

            So if we look at the REST url:

            https://github.com/jenkinsci/blueocean-plugin/tree/master/blueocean-rest#get-nested-pipeline-inside-a-folder

            http://localhost:62054/jenkins/blue/rest/organizations/jenkins/pipelines/folder1/pipelines/folder2/test2/

            breaking it down:

            http://localhost:62054/jenkins/blue/rest/organizations/$orgname/pipelines/$folderA/pipelines/$folderB/$pipelineName/
            

            so "pipelines" acts as a separator

            Show
            michaelneale Michael Neale added a comment - - edited So if we look at the REST url: https://github.com/jenkinsci/blueocean-plugin/tree/master/blueocean-rest#get-nested-pipeline-inside-a-folder http://localhost:62054/jenkins/blue/rest/organizations/jenkins/pipelines/folder1/pipelines/folder2/test2/ breaking it down: http://localhost:62054/jenkins/blue/rest/organizations/$orgname/pipelines/$folderA/pipelines/$folderB/$pipelineName/ so "pipelines" acts as a separator
            Hide
            michaelneale Michael Neale added a comment -

            James Dumay this will involve the design as per the mockups in https://cloudbees.atlassian.net/browse/UX-196 right?

            Show
            michaelneale Michael Neale added a comment - James Dumay this will involve the design as per the mockups in https://cloudbees.atlassian.net/browse/UX-196 right?
            Hide
            vivek Vivek Pandey added a comment -

            [~mneale]As mentioned in comment in https://cloudbees.atlassian.net/browse/UX-196, "There is issue of how to detect folder vs pipeline, that gets addressed with data extensibility/capability work.", this is cross cutting concern and going to be addressed in UX-68/UX-350.

            Show
            vivek Vivek Pandey added a comment - [~mneale] As mentioned in comment in https://cloudbees.atlassian.net/browse/UX-196 , "There is issue of how to detect folder vs pipeline, that gets addressed with data extensibility/capability work.", this is cross cutting concern and going to be addressed in UX-68 / UX-350 .
            Hide
            michaelneale Michael Neale added a comment - - edited

            [~vpandey] actually can use the numOfFolders etc to know if something is a folder at least (so they can not be shown at top level).

            Show
            michaelneale Michael Neale added a comment - - edited [~vpandey] actually can use the numOfFolders etc to know if something is a folder at least (so they can not be shown at top level).
            Hide
            vivek Vivek Pandey added a comment -

            [~mneale] yes, thats works.

            Show
            vivek Vivek Pandey added a comment - [~mneale] yes, thats works.
            Hide
            michaelneale Michael Neale added a comment -

            Doesn't make sense to tackle this without fixing up the URIs

            Show
            michaelneale Michael Neale added a comment - Doesn't make sense to tackle this without fixing up the URIs
            michaelneale Michael Neale made changes -
            Link This issue is blocked by UX-310 [ UX-310 ]
            michaelneale Michael Neale made changes -
            Description In Scope
            * When UX-276 is completed we need to handle nested folder jobs in the frontend
            In Scope
            * When UX-276 is completed we need to handle nested folder jobs in the frontend
            * [1:22 PM] James Dumay: * Dashboard should NOT display folders
            * Always use the fullName as the display name
            * Browsing to a pipeline should work if its in a folder
            [1:23 PM] James Dumay: * Browsing to a folder should 404
            [1:23 PM] James Dumay: * Browsing to a folder just show a list of the folder contents as if that folder was the "root" of the dashboard
            [1:24 PM] James Dumay: e.g if I browse to /org/my/sub/folder/
            [1:24 PM] James Dumay: show everything under /org/my/sub/folder/ as it is "/"
            michaelneale Michael Neale made changes -
            Link This issue is blocked by UX-533 [ UX-533 ]
            michaelneale Michael Neale made changes -
            Description In Scope
            * When UX-276 is completed we need to handle nested folder jobs in the frontend
            * [1:22 PM] James Dumay: * Dashboard should NOT display folders
            * Always use the fullName as the display name
            * Browsing to a pipeline should work if its in a folder
            [1:23 PM] James Dumay: * Browsing to a folder should 404
            [1:23 PM] James Dumay: * Browsing to a folder just show a list of the folder contents as if that folder was the "root" of the dashboard
            [1:24 PM] James Dumay: e.g if I browse to /org/my/sub/folder/
            [1:24 PM] James Dumay: show everything under /org/my/sub/folder/ as it is "/"
            In Scope
            * When UX-276 is completed we need to handle nested folder jobs in the frontend
            * Always use the fullName as the display name
            * Browsing to a pipeline should work if its in a folder
            [1:23 PM] James Dumay: * Browsing to a folder should 404
            [1:23 PM] James Dumay: * Browsing to a folder just show a list of the folder contents as if that folder was the "root" of the dashboard
            [1:24 PM] James Dumay: e.g if I browse to /org/my/sub/folder/
            [1:24 PM] James Dumay: show everything under /org/my/sub/folder/ as it is "/"
            michaelneale Michael Neale made changes -
            Description In Scope
            * When UX-276 is completed we need to handle nested folder jobs in the frontend
            * Always use the fullName as the display name
            * Browsing to a pipeline should work if its in a folder
            [1:23 PM] James Dumay: * Browsing to a folder should 404
            [1:23 PM] James Dumay: * Browsing to a folder just show a list of the folder contents as if that folder was the "root" of the dashboard
            [1:24 PM] James Dumay: e.g if I browse to /org/my/sub/folder/
            [1:24 PM] James Dumay: show everything under /org/my/sub/folder/ as it is "/"
            In Scope
            * When UX-276 is completed we need to handle nested folder jobs in the frontend
            * Always use the fullName as the display name
            * Browsing to a pipeline should work if its in a folder
            * Browsing to a folder should 404
             Browsing to a folder just show a list of the folder contents as if that folder was the "root" of the dashboard
            [1:24 PM] James Dumay: e.g if I browse to /org/my/sub/folder/
            [1:24 PM] James Dumay: show everything under /org/my/sub/folder/ as it is "/"
            jamesdumay James Dumay made changes -
            Epic Link UX-35 [ 24725 ] UX-85 [ 25283 ]
            jamesdumay James Dumay made changes -
            Epic Link UX-85 [ 25283 ] UX-79 [ 25277 ]
            jamesdumay James Dumay made changes -
            Epic Link UX-79 [ 25277 ] UX-85 [ 25283 ]
            michaelneale Michael Neale made changes -
            Rank Ranked higher
            michaelneale Michael Neale made changes -
            Description In Scope
            * When UX-276 is completed we need to handle nested folder jobs in the frontend
            * Always use the fullName as the display name
            * Browsing to a pipeline should work if its in a folder
            * Browsing to a folder should 404
             Browsing to a folder just show a list of the folder contents as if that folder was the "root" of the dashboard
            [1:24 PM] James Dumay: e.g if I browse to /org/my/sub/folder/
            [1:24 PM] James Dumay: show everything under /org/my/sub/folder/ as it is "/"
            When items are shown on the main dashboard (/pipelines) they may include items that are from nested folders.
            When clicking on an item that is in a folder, it needs to be loaded with the URI reflecting what its folder path is.


            In Scope
            * When UX-276 is completed we need to handle nested folder jobs in the frontend
            * Always use the fullName as the display name
            * Browsing to a pipeline should work if its in a folder
            * Browsing to a folder should 404
             Browsing to a folder just show a list of the folder contents as if that folder was the "root" of the dashboard
            [1:24 PM] James Dumay: e.g if I browse to /org/my/sub/folder/
            [1:24 PM] James Dumay: show everything under /org/my/sub/folder/ as it is "/"
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Epic Link UX-85 [ 25283 ] UX-195 [ 26048 ]
            jamesdumay James Dumay made changes -
            Rank Ranked lower
            jamesdumay James Dumay made changes -
            Sprint 1.0-japan-m9 [ 41 ]
            jamesdumay James Dumay made changes -
            Rank Ranked lower
            jamesdumay James Dumay made changes -
            Sprint 1.0-japan-m9 [ 41 ] 1.0-m10 [ 56 ]
            Hide
            michaelneale Michael Neale added a comment -

            [~cmeyers] sorry I may have mislead this morning when talking through URIs.

            The aim is that the main dashboard does show (paginated) all pipelines from all folders (but not the folders themselves). This is a big long flat list. When we have that, we will need to be able to let the user click on something that is in a folder (even though it is flattened out on the main dashboard) and have it load, with the correct data URL for rest, and the URI in the browser set correctly - which is what this ticket is about.

            Show
            michaelneale Michael Neale added a comment - [~cmeyers] sorry I may have mislead this morning when talking through URIs. The aim is that the main dashboard does show (paginated) all pipelines from all folders (but not the folders themselves). This is a big long flat list. When we have that, we will need to be able to let the user click on something that is in a folder (even though it is flattened out on the main dashboard) and have it load, with the correct data URL for rest, and the URI in the browser set correctly - which is what this ticket is about.
            michaelneale Michael Neale made changes -
            Link This issue is blocked by UX-548 [ UX-548 ]
            admin V R made changes -
            Project Import Tue Jun 14 12:50:41 JST 2016 [ 1465876241198 ]
            rtyler R. Tyler Croy made changes -
            Project Import Wed Jun 15 02:53:18 UTC 2016 [ 1465959198925 ]
            jamesdumay James Dumay made changes -
            Labels blueocean-imported
            jamesdumay James Dumay made changes -
            Project User Experience [ 10600 ] Jenkins [ 10172 ]
            Key UX-348 JENKINS-35866
            Workflow Product Backlog April 2016 V2 [ 172228 ] JNJira [ 172486 ]
            Status To Do [ 10003 ] Open [ 1 ]
            Component/s blueocean-plugin [ 21481 ]
            admin V R made changes -
            Priority Medium [ 3 ] Major [ 10000 ]
            admin V R made changes -
            Reporter James Dumay [ jdumay ] James Dumay [ jamesdumay ]
            admin V R made changes -
            Reporter James Dumay [ jdumay ] James Dumay [ jdumay ]
            jamesdumay James Dumay made changes -
            Sprint 1.0-m10 [ 56 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            jamesdumay James Dumay made changes -
            Sprint 1.0-m10 [ 66 ]
            jamesdumay James Dumay made changes -
            Rank Ranked lower
            michaelneale Michael Neale made changes -
            Assignee Cliff Meyers [ cliffmeyers ]
            michaelneale Michael Neale made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            michaelneale Michael Neale made changes -
            Sprint 1.0-m10 [ 66 ] 1.0-m9 [ 46 ]
            michaelneale Michael Neale made changes -
            Rank Ranked lower
            jamesdumay James Dumay made changes -
            Sprint 1.0-japan-m9 [ 46 ] 1.0-japan-m9, 1.0-m10 [ 46, 66 ]
            cliffmeyers Cliff Meyers made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            michaelneale Michael Neale made changes -
            Attachment IMG_7668.JPG [ 33099 ]
            Hide
            michaelneale Michael Neale added a comment -

            Cliff Meyers here is the whiteboard where we talked about where to put the path:

            I am not sure if Thorsten Scherler was also attacking this - I don't think so.

            Show
            michaelneale Michael Neale added a comment - Cliff Meyers here is the whiteboard where we talked about where to put the path: I am not sure if Thorsten Scherler was also attacking this - I don't think so.
            Hide
            cliffmeyers Cliff Meyers added a comment -

            Yes, this is in-progress. I was in training on Wed, but had time to squash a few small bugs during breaks. I plan to focus on this on Thu.

            Show
            cliffmeyers Cliff Meyers added a comment - Yes, this is in-progress. I was in training on Wed, but had time to squash a few small bugs during breaks. I plan to focus on this on Thu.
            jamesdumay James Dumay made changes -
            Priority Critical [ 2 ] Blocker [ 1 ]
            jamesdumay James Dumay made changes -
            Priority Blocker [ 1 ] Major [ 3 ]
            jamesdumay James Dumay made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            Show
            cliffmeyers Cliff Meyers added a comment - PR: https://github.com/jenkinsci/blueocean-plugin/pull/299
            cliffmeyers Cliff Meyers made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 172486 ] JNJira + In-Review [ 199236 ]

              People

              • Assignee:
                cliffmeyers Cliff Meyers
                Reporter:
                jamesdumay James Dumay
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: