Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36157

recurisve group lookup is missing groups.

XMLWordPrintable

      AD 1.47

      The implementation for [recursive group lookup | https://github.com/jenkinsci/active-directory-plugin/blob/c04fc160d7cbf4f616109190ac3df7dcc1a02970/src/main/java/hudson/plugins/active_directory/ActiveDirectoryUnixAuthenticationProvider.java#L630-L632
      ] is buggy and does not return all groups that a user is a member of.

      The code will only add the group to the queue to do recursive lookup if it is not already in the granted authorities.

      However, the groups set is pre-populated with all group membership of "Security Groups" via the tokenGroups lookup.

      Thus if user "A" is a member of Security Group "SG1" and "SG1" is a member of Distribution Group "DG1" then A is granted "SG1" role but not "DG1"

      Fixing this is highly likely to have a performance impact - and many users may not even care about distribution group membership - so when fixing this I would also suggest a "SecurityGroups Only" recursive lookup method that does no recursion whatsoever and just uses whatever is returned by tokenGroups

            fbelzunc FĂ©lix Belzunce Arcos
            teilo James Nord
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: