Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36160

Credentials defined in the folder should be available to the folder

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      getCredentials(Class,Item,Authentication,List) has not been overridden so the default behaviour of redirecting to Item.getParent() means that the folder's own credentials are not available to the folder itself.

      This was an oversight in the implementation of the CredentialsProvider contract for folders.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            Antonio Muñiz Stephen Connolly did this fix the issue that the Add dropdown in, say, http://jenkins/job/some-multibranch/pipeline-syntax/ with, say, the git step selected, offered only Jenkins and not the (computed) folder itself?

            Show
            jglick Jesse Glick added a comment - Antonio Muñiz Stephen Connolly did this fix the issue that the Add dropdown in, say, http ://jenkins/job/some-multibranch/pipeline-syntax/ with, say, the git step selected, offered only Jenkins and not the (computed) folder itself?
            Hide
            amuniz Antonio Muñiz added a comment - - edited

            Jesse Glick I don't think so, this is about the list of credentials shown in the credentials select dropdown, not the Add dropdown.

            Show
            amuniz Antonio Muñiz added a comment - - edited Jesse Glick I don't think so, this is about the list of credentials shown in the credentials select dropdown, not the Add dropdown.
            Hide
            stephenconnolly Stephen Connolly added a comment -

            Jesse Glick nope that pipeline issue was the loss of it this was about some calls to lookupCredentials coming from the type `Item` and others coming from the type `ItemGroup` and the behaviour being inconsistent which lead to credentials in an Item that is also an ItemGroup (i.e. a Folder) not always being discoverable from the item itself (on code paths that treat the folder as an `Item`)

            Show
            stephenconnolly Stephen Connolly added a comment - Jesse Glick nope that pipeline issue was the loss of it this was about some calls to lookupCredentials coming from the type `Item` and others coming from the type `ItemGroup` and the behaviour being inconsistent which lead to credentials in an Item that is also an ItemGroup (i.e. a Folder) not always being discoverable from the item itself (on code paths that treat the folder as an `Item`)

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                stephenconnolly Stephen Connolly
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: