Details

    • Similar Issues:

      Description

      Allow to customize what to build in terms of branches and PRs:

      • Only branches
      • Branches and PRs
      • Only PRs

      And for PRs builds:

      • Merge status (PR head merged with destination branch)
      • Head status (PR head)
      • Allow (or not) PRs from origin repository

      It would be something similar to what github-branch-source is offering (included in this PR)

        Attachments

          Issue Links

            Activity

            amuniz Antonio Muñiz created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-33161 [ JENKINS-33161 ]
            Hide
            jglick Jesse Glick added a comment -

            To produce a self-contained, reproducible SCMRevision for a merge build it is necessary to encode the head of the destination branch as well as the head of the PR. Even for head builds, it is necessary to encode a deterministic destination branch head (such as the merge ancestor) in order to implement getTrustedRevision, which you should also do for this plugin.

            Show
            jglick Jesse Glick added a comment - To produce a self-contained, reproducible SCMRevision for a merge build it is necessary to encode the head of the destination branch as well as the head of the PR. Even for head builds, it is necessary to encode a deterministic destination branch head (such as the merge ancestor) in order to implement getTrustedRevision , which you should also do for this plugin.
            nickbrown Nicholas Brown made changes -
            Link This issue is duplicated by JENKINS-34931 [ JENKINS-34931 ]
            nickbrown Nicholas Brown made changes -
            Link This issue is duplicated by JENKINS-33865 [ JENKINS-33865 ]
            Hide
            jglick Jesse Glick added a comment -

            Seems there are several issues all saying basically the same thing here.

            Show
            jglick Jesse Glick added a comment - Seems there are several issues all saying basically the same thing here.
            jglick Jesse Glick made changes -
            Link This issue duplicates JENKINS-35991 [ JENKINS-35991 ]
            amuniz Antonio Muñiz made changes -
            Link This issue is duplicated by JENKINS-35991 [ JENKINS-35991 ]
            amuniz Antonio Muñiz made changes -
            Link This issue duplicates JENKINS-35991 [ JENKINS-35991 ]
            Hide
            amuniz Antonio Muñiz added a comment -

            All cleared up now.

            Show
            amuniz Antonio Muñiz added a comment - All cleared up now.
            jamesdumay James Dumay made changes -
            Labels blueocean
            Hide
            arminc Armin C added a comment -

            Not sure if this is the right place....

            This issue seems to assume that you don't want to see the 'branch/pr' that you don't want to build automatically. I also have a case where I want to show all the branches and the PR's but I only want to build the PR's automatically and the branches can if needed be triggered manually to build.
            I was looking at the code but I can't find a way to do this 'correctly', it seems like you can only show or not show a branch but you can't show it and the skip the build on an event? If somebody has a tip what to look for in the code, that would be great.

            Show
            arminc Armin C added a comment - Not sure if this is the right place.... This issue seems to assume that you don't want to see the 'branch/pr' that you don't want to build automatically. I also have a case where I want to show all the branches and the PR's but I only want to build the PR's automatically and the branches can if needed be triggered manually to build. I was looking at the code but I can't find a way to do this 'correctly', it seems like you can only show or not show a branch but you can't show it and the skip the build on an event? If somebody has a tip what to look for in the code, that would be great.
            amuniz Antonio Muñiz made changes -
            Link This issue is related to JENKINS-33739 [ JENKINS-33739 ]
            amuniz Antonio Muñiz made changes -
            Description Allow to customize what to build in terms of branches and PRs:

            * Only branches
            * Branches and PRs
            * Only PRs

            And for PRs builds:
            * Merge status (PR head merged with destination branch)
            * Head status (PR head)

            It would be something similar to what github-branch-source is offering (included in [this PR|https://github.com/jenkinsci/github-branch-source-plugin/pull/60])
            Allow to customize what to build in terms of branches and PRs:

            * Only branches
            * Branches and PRs
            * Only PRs

            And for PRs builds:
            * Merge status (PR head merged with destination branch)
            * Head status (PR head)
            * Allow (or not) PRs from origin repository

            It would be something similar to what github-branch-source is offering (included in [this PR|https://github.com/jenkinsci/github-branch-source-plugin/pull/60])
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 172981 ] JNJira + In-Review [ 184865 ]
            yakobe jake bishop made changes -
            Comment [ [~arminc] Did you find a solution in the end? I would like to do the same thing... ]
            Hide
            yakobe jake bishop added a comment -

            Armin C Did you find a solution in the end? I would like to do the same thing...

            Show
            yakobe jake bishop added a comment - Armin C Did you find a solution in the end? I would like to do the same thing...
            Hide
            arminc Armin C added a comment -

            jake bishop No and Yes.

            No because this plugin only scans and shows the branches but it does not decide if they are actually going to be build (automatically) or not, I haven't figured out exactly were it happens but I assume it's the GIT plugin that makes the decision based on if there are changes or not. I am stuck on how to proceed, maybe we can team up somehow to find a solution.

            Yes we created a workaround where it is possible to specify a regular expression that decides which branches you want to show, all pull requests are automatically showen. You can see the code changes here

            Show
            arminc Armin C added a comment - jake bishop No and Yes. No because this plugin only scans and shows the branches but it does not decide if they are actually going to be build (automatically) or not, I haven't figured out exactly were it happens but I assume it's the GIT plugin that makes the decision based on if there are changes or not. I am stuck on how to proceed, maybe we can team up somehow to find a solution. Yes we created a workaround where it is possible to specify a regular expression that decides which branches you want to show, all pull requests are automatically showen. You can see the code changes here
            Hide
            yakobe jake bishop added a comment -

            Armin C

            Thanks for your reply. Shame that there is no easy way to accomplish this at the moment. It would be great if the options suggested in this ticket were implemented as we cannot use the plugin without it (our build take a long time, so running the twice for each commit is not an option).

            I take it the suggested workaround is not something that we can use unless we fork the code and install our own version of the plugin? We would be very willing to help out in any way we can to accomplish the functionality we need, although our knowledge of programming jenkins plugins is limited at the moment.

            Show
            yakobe jake bishop added a comment - Armin C Thanks for your reply. Shame that there is no easy way to accomplish this at the moment. It would be great if the options suggested in this ticket were implemented as we cannot use the plugin without it (our build take a long time, so running the twice for each commit is not an option). I take it the suggested workaround is not something that we can use unless we fork the code and install our own version of the plugin? We would be very willing to help out in any way we can to accomplish the functionality we need, although our knowledge of programming jenkins plugins is limited at the moment.
            Hide
            arminc Armin C added a comment -

            jake bishop If you don't want to build the plugin your self you can use our build see here and to be specific this release contains fixes for the connections and possibility to select the branches you want to show.

            Show
            arminc Armin C added a comment - jake bishop If you don't want to build the plugin your self you can use our build see here and to be specific this release contains fixes for the connections and possibility to select the branches you want to show.
            Hide
            cosima_laube Cosima Laube added a comment -

            Are there any plans when the Bitbucket branch source plugin catches up with the GitHub plugin's features?
            We would especially be interested in the possibility to build a PR merged with current master.

            Show
            cosima_laube Cosima Laube added a comment - Are there any plans when the Bitbucket branch source plugin catches up with the GitHub plugin's features? We would especially be interested in the possibility to build a PR merged with current master.
            Hide
            jamesdumay James Dumay added a comment -

            Cosima Laube we at CloudBees need parity with Github for Blue Ocean so we are considering picking this up. Unfortunately I can't share an ETA with you but it is on our radar.

            Show
            jamesdumay James Dumay added a comment - Cosima Laube we at CloudBees need parity with Github for Blue Ocean so we are considering picking this up. Unfortunately I can't share an ETA with you but it is on our radar.
            Hide
            tknerr Torben Knerr added a comment -

            Is PR 25 going in a good direction for this?
            https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/25

            Show
            tknerr Torben Knerr added a comment - Is PR 25 going in a good direction for this? https://github.com/jenkinsci/bitbucket-branch-source-plugin/pull/25
            Hide
            jamesdumay James Dumay added a comment -

            I believe JENKINS-43507 contains this functionality and is due to be released in a few weeks.

            Show
            jamesdumay James Dumay added a comment - I believe JENKINS-43507 contains this functionality and is due to be released in a few weeks.
            jamesdumay James Dumay made changes -
            Link This issue duplicates JENKINS-43507 [ JENKINS-43507 ]
            jamesdumay James Dumay made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Duplicate [ 3 ]
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal OSS-1245 (Web Link)" [ 18754 ]

              People

              • Assignee:
                amuniz Antonio Muñiz
                Reporter:
                amuniz Antonio Muñiz
              • Votes:
                26 Vote for this issue
                Watchers:
                33 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: