Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36593

ItemCategory exposes public static MIN_TOSHOW field to API

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      In https://github.com/jenkinsci/jenkins/commit/25f9c99d8376667b2efaabe8cb6f5b4be6024618 Manuel Recena Soto introduced a new "public static int MIN_TOSHOW = 1" field. So we have a constant, which can be occasionally modified by any API user.

      This field is now a part of API, so we cannot easily convert it to final or make private. My proposal is to restrict it at least

        Attachments

          Issue Links

            Activity

            Hide
            recena Manuel Recena Soto added a comment -

            Oleg Nenashev I sent my comments to the PR.

            Show
            recena Manuel Recena Soto added a comment - Oleg Nenashev I sent my comments to the PR.
            Hide
            danielbeck Daniel Beck added a comment -

            Fixed in 2.14 (2016/07/17)

            Show
            danielbeck Daniel Beck added a comment - Fixed in 2.14 (2016/07/17)
            Hide
            danielbeck Daniel Beck added a comment -

            Oliver Gondža Should be expedited into 2.7.2 to prevent people from using it IMO.

            Show
            danielbeck Daniel Beck added a comment - Oliver Gondža Should be expedited into 2.7.2 to prevent people from using it IMO.

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: