Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36903

Development footer is missing on blueocean.io

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      1.0-m12

      Description

      Vivek Pandey I think you broke this when you did the cleanup in JENKINS-36481

        Attachments

          Issue Links

            Activity

            Hide
            vivek Vivek Pandey added a comment -

            James Dumay No. It surfaces another bug that was masked by the code (jenkins version) I removed during cleanup. See UX-327, this works but only in local. I guess revisionInfo needs to be bundled, exported and imported in DevelopmentFooter.jsx. At present it imports from local path thats of course missing in production/dogfood instance.

            import revisionInfo from '../../../target/classes/io/jenkins/blueocean/revisionInfo';
            

            Looks like Thorsten Scherler originally wrote it, it needs fixing so that it works in all cases.

            Show
            vivek Vivek Pandey added a comment - James Dumay No. It surfaces another bug that was masked by the code (jenkins version) I removed during cleanup. See UX-327, this works but only in local. I guess revisionInfo needs to be bundled, exported and imported in DevelopmentFooter.jsx. At present it imports from local path thats of course missing in production/dogfood instance. import revisionInfo from '../../../target/classes/io/jenkins/blueocean/revisionInfo' ; Looks like Thorsten Scherler originally wrote it, it needs fixing so that it works in all cases.
            Hide
            jamesdumay James Dumay added a comment -

            Vivek Pandey thanks for taking a look.

            Show
            jamesdumay James Dumay added a comment - Vivek Pandey thanks for taking a look.
            Hide
            tscherler Thorsten Scherler added a comment -

            Hmm, Vivek Pandey I understand what you are saying but I need to think on how we can to that. the best way. If we bundle it I would either copy the revisionInfo.js into the src folder and add an .gitignore for it, or create a "bundle" folder where I copy the src and additional files as ri.jsx then there is no need for the ignore.

            ...or somehow injecting it directly into the bundler. Will consult with Tom FENNELLY about the best way.

            Show
            tscherler Thorsten Scherler added a comment - Hmm, Vivek Pandey I understand what you are saying but I need to think on how we can to that. the best way. If we bundle it I would either copy the revisionInfo.js into the src folder and add an .gitignore for it, or create a "bundle" folder where I copy the src and additional files as ri.jsx then there is no need for the ignore. ...or somehow injecting it directly into the bundler. Will consult with Tom FENNELLY about the best way.
            Hide
            tfennelly Tom FENNELLY added a comment -

            import revisionInfo from '../../../target/classes/io/jenkins/blueocean/revisionInfo'; is not going to matter at runtime as it will be in the bundle i.e. it will still resolve.

            Show
            tfennelly Tom FENNELLY added a comment - import revisionInfo from '../../../target/classes/io/jenkins/blueocean/revisionInfo'; is not going to matter at runtime as it will be in the bundle i.e. it will still resolve.
            Hide
            vivek Vivek Pandey added a comment - - edited

            Tom FENNELLYThorsten Scherler Ah ok so it gets resolved at build time. However it doesn't work as condition in DevelopmentFooter.jsx fails as !revisionInfo.default.name returns true, this led me to believe its not getting resolved. See the attached image from debugging on blueocean.io.

            Show
            vivek Vivek Pandey added a comment - - edited Tom FENNELLY Thorsten Scherler Ah ok so it gets resolved at build time. However it doesn't work as condition in DevelopmentFooter.jsx fails as !revisionInfo.default.name returns true, this led me to believe its not getting resolved. See the attached image from debugging on blueocean.io.
            Hide
            tscherler Thorsten Scherler added a comment -

            That is weird.

            "name": "blueocean-plugin",

            should be there.

            We use

            name: '(basename $(git rev-parse --show-toplevel))',

            to generate it. Meaning the toplevel is not shown.

            Anyway we do not use the name anywhere in the component, I changed it to sha.

            https://github.com/jenkinsci/blueocean-plugin/pull/375

            Show
            tscherler Thorsten Scherler added a comment - That is weird. "name": "blueocean-plugin", should be there. We use name: '(basename $(git rev-parse --show-toplevel))', to generate it. Meaning the toplevel is not shown. Anyway we do not use the name anywhere in the component, I changed it to sha. https://github.com/jenkinsci/blueocean-plugin/pull/375

              People

              • Assignee:
                tscherler Thorsten Scherler
                Reporter:
                jamesdumay James Dumay
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: