Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37185

Checkout timeout is not honored when used with local branch parameter

    Details

    • Similar Issues:

      Description

      Expectation: When I set the checkout timeout, I'm expecting that Jenkins uses it when it comes to checkout a commit.

      Problem: However, it appears that when you select the "Check out to a specific local branch", the first checkout command does not set correctly the timeout.

      Why it's a problem: I'm using git lfs, and git lfs files are downloaded during the checkout option. For other reasons I can't use the git lfs pull command. Especially during the first checkout command.

      How to reproduce it: Use any version of git-plugin and git-client-plugin. Create a freestyle project, add the following parameters: Timeout=120 for Advanced checkout option, and Checkout to a specific local branch. Build the project. The first checkout will be displayed with a timeout of 10 instead of 120.

      Here is my proposition to fix this error: https://github.com/jenkinsci/git-client-plugin/pull/214

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Quentin Dufour
            Path:
            src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
            http://jenkins-ci.org/commit/git-client-plugin/f2c632c6a539d56ee2acf82161bd534e2d86733d
            Log:
            JENKINS-37185 Honor checkout timeout

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Quentin Dufour Path: src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java http://jenkins-ci.org/commit/git-client-plugin/f2c632c6a539d56ee2acf82161bd534e2d86733d Log: JENKINS-37185 Honor checkout timeout
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Quentin Dufour
            Path:
            src/test/java/org/jenkinsci/plugins/gitclient/GitAPITestCase.java
            http://jenkins-ci.org/commit/git-client-plugin/4187c8bb3e46e23c48260e524b0e53808da899ce
            Log:
            JENKINS-37185 Fix checkTimeout() and its associated tests

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Quentin Dufour Path: src/test/java/org/jenkinsci/plugins/gitclient/GitAPITestCase.java http://jenkins-ci.org/commit/git-client-plugin/4187c8bb3e46e23c48260e524b0e53808da899ce Log: JENKINS-37185 Fix checkTimeout() and its associated tests
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Quentin Dufour
            Path:
            src/test/java/org/jenkinsci/plugins/gitclient/GitAPITestCase.java
            http://jenkins-ci.org/commit/git-client-plugin/742861e9e83e5775d48f33c99c2827cbe37944ed
            Log:
            JENKINS-37185 Add a test to check timeouts on checkout

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Quentin Dufour Path: src/test/java/org/jenkinsci/plugins/gitclient/GitAPITestCase.java http://jenkins-ci.org/commit/git-client-plugin/742861e9e83e5775d48f33c99c2827cbe37944ed Log: JENKINS-37185 Add a test to check timeouts on checkout
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Mark Waite
            Path:
            src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
            src/test/java/org/jenkinsci/plugins/gitclient/GitAPITestCase.java
            http://jenkins-ci.org/commit/git-client-plugin/ea305aaa62389c98aeb14e3dd290cbf2f3d04aca
            Log:
            Merge pull request #214 from superboum/master

            JENKINS-37185 Honor checkout timeout

            Compare: https://github.com/jenkinsci/git-client-plugin/compare/00731f9e3d22...ea305aaa6238

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mark Waite Path: src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java src/test/java/org/jenkinsci/plugins/gitclient/GitAPITestCase.java http://jenkins-ci.org/commit/git-client-plugin/ea305aaa62389c98aeb14e3dd290cbf2f3d04aca Log: Merge pull request #214 from superboum/master JENKINS-37185 Honor checkout timeout Compare: https://github.com/jenkinsci/git-client-plugin/compare/00731f9e3d22...ea305aaa6238
            Hide
            markewaite Mark Waite added a comment -

            Included in git client plugin 1.20.0 released 20 Aug 2016

            Show
            markewaite Mark Waite added a comment - Included in git client plugin 1.20.0 released 20 Aug 2016

              People

              • Assignee:
                superboum Quentin Dufour
                Reporter:
                superboum Quentin Dufour
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: