Job-enabling API should reject GET requests

Details

  • Type: Patch Patch
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: current
  • Fix Version/s: None
  • Component/s: core
  • Labels:
    None
  • Environment:
    Platform: All, OS: All

Description

According to job API description, job-enabling/disabling APIs should be invoked
by POST requests.
But in doEnable in AbstractProject.java, the job-enabling API is invoked by a
GET request.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
OHTAKE Tomohiro added a comment -

Created an attachment (id=711)
add requirePOST to doEnable

Show
OHTAKE Tomohiro added a comment - Created an attachment (id=711) add requirePOST to doEnable
Hide
Permalink
SCM/JIRA link daemon added a comment -

Code changed in hudson
User: : kohsuke
Path:
trunk/hudson/main/core/src/main/java/hudson/model/AbstractModelObject.java
trunk/hudson/main/core/src/main/java/hudson/model/AbstractProject.java
trunk/www/changelog.html
http://fisheye4.cenqua.com/changelog/hudson/?cs=22207
Log:
[FIXED JENKINS-3721] Job-enabling API should reject GET requests.

Show
SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/core/src/main/java/hudson/model/AbstractModelObject.java trunk/hudson/main/core/src/main/java/hudson/model/AbstractProject.java trunk/www/changelog.html http://fisheye4.cenqua.com/changelog/hudson/?cs=22207 Log: [FIXED JENKINS-3721] Job-enabling API should reject GET requests.

People

  • Assignee:
    Unassigned
    Reporter:
    OHTAKE Tomohiro
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: