Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37223

Improve diagnosability of Agent protocol

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      When troubleshooting the connectivity of JNLP build agents, it'd be nice if the TcpSlaveAgentListener provides more diagnosability. Currently, a protocol is binary, so it prevents the standard diagnostic tools like 'nc' and 'telnet' to work.

      The situation where this gets frustrating is when you have network middle layers, such as port forwarder, iptables, and other such things. A basic "Ping? Pong!" would help users perform trouble-shooting quickly.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          core/src/main/java/hudson/TcpSlaveAgentListener.java
          test/src/test/java/hudson/TcpSlaveAgentListenerTest.java
          http://jenkins-ci.org/commit/jenkins/172df6a7dfca56477c471c381687599c80f5113b
          Log:
          [FIXED JENKINS-37223]

          Added a simple diagnostic HTTP response to the TcpSlaveAgentListener.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/TcpSlaveAgentListener.java test/src/test/java/hudson/TcpSlaveAgentListenerTest.java http://jenkins-ci.org/commit/jenkins/172df6a7dfca56477c471c381687599c80f5113b Log: [FIXED JENKINS-37223] Added a simple diagnostic HTTP response to the TcpSlaveAgentListener.
          Hide
          kohsuke Kohsuke Kawaguchi added a comment -

          Not yet merged to master

          Show
          kohsuke Kohsuke Kawaguchi added a comment - Not yet merged to master
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          core/src/main/java/hudson/TcpSlaveAgentListener.java
          http://jenkins-ci.org/commit/jenkins/ab57c02646ded9ebf921cddbf798890bc2a08805
          Log:
          JENKINS-37223

          report the server's address, too

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/TcpSlaveAgentListener.java http://jenkins-ci.org/commit/jenkins/ab57c02646ded9ebf921cddbf798890bc2a08805 Log: JENKINS-37223 report the server's address, too
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          core/src/main/java/hudson/TcpSlaveAgentListener.java
          http://jenkins-ci.org/commit/jenkins/57846475f7bd270ea9624144bbd54447ff47dedb
          Log:
          JENKINS-37223

          report the server's address, too

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/TcpSlaveAgentListener.java http://jenkins-ci.org/commit/jenkins/57846475f7bd270ea9624144bbd54447ff47dedb Log: JENKINS-37223 report the server's address, too
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          core/src/main/java/hudson/TcpSlaveAgentListener.java
          test/src/test/java/hudson/TcpSlaveAgentListenerTest.java
          http://jenkins-ci.org/commit/jenkins/fab0938ee43b05126fa390d021eeac1673badee5
          Log:
          Merge pull request #2496 from jenkinsci/JENKINS-37223

          [FIXED JENKINS-37223]

          Compare: https://github.com/jenkinsci/jenkins/compare/55203ebeed1b...fab0938ee43b

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/TcpSlaveAgentListener.java test/src/test/java/hudson/TcpSlaveAgentListenerTest.java http://jenkins-ci.org/commit/jenkins/fab0938ee43b05126fa390d021eeac1673badee5 Log: Merge pull request #2496 from jenkinsci/ JENKINS-37223 [FIXED JENKINS-37223] Compare: https://github.com/jenkinsci/jenkins/compare/55203ebeed1b...fab0938ee43b

            People

            • Assignee:
              kohsuke Kohsuke Kawaguchi
              Reporter:
              kohsuke Kohsuke Kawaguchi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: