Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37369

Multibranch Pipeline: Last build information is not propagated to Jenkins View

    Details

    • Similar Issues:

      Description

      The build information Last Success, Last Failure and Last Duration is not propagated to the Jenkins view. The Jenkins view showing the multibranch pipeline folder always shows N/A. The latest built branch should propagate this build information to the outside view.

        Attachments

          Issue Links

            Activity

            djviking Sverre Moe created issue -
            djviking Sverre Moe made changes -
            Field Original Value New Value
            Attachment jenkinspipeline1.png [ 33604 ]
            djviking Sverre Moe made changes -
            Attachment jenkinspipeline2.png [ 33605 ]
            jglick Jesse Glick made changes -
            Component/s core [ 15593 ]
            Component/s workflow-multibranch-plugin [ 21465 ]
            Hide
            jglick Jesse Glick added a comment -

            The view columns are defined in core, and do not handle folders.

            Show
            jglick Jesse Glick added a comment - The view columns are defined in core, and do not handle folders.
            jglick Jesse Glick made changes -
            Component/s branch-api-plugin [ 18621 ]
            jglick Jesse Glick made changes -
            Labels Pipeline folders multibranch
            Hide
            cbennett Colin Bennett added a comment -

            It is definitely unintuitive to have the last success/last failure value be N/A for multibranch pipeline jobs.

            One thing that I often do is sort all Jenkins jobs by last failure to see what the recently failing builds are on the server. I'm not sure how I can do this with multibranch pipeline jobs.

            Show
            cbennett Colin Bennett added a comment - It is definitely unintuitive to have the last success/last failure value be N/A for multibranch pipeline jobs. One thing that I often do is sort all Jenkins jobs by last failure to see what the recently failing builds are on the server. I'm not sure how I can do this with multibranch pipeline jobs.
            cbennett Colin Bennett made changes -
            Link This issue is related to JENKINS-32974 [ JENKINS-32974 ]
            Hide
            stephenconnolly Stephen Connolly added a comment -

            We could have ComputedFolder provide getLastFailedBuild() and getLastSuccessfulBuild() methods returning pseudo Build objects referring to the computation... so that at least those columns display relevant information w.r.t. the last time the organization was scanned.

            Show
            stephenconnolly Stephen Connolly added a comment - We could have ComputedFolder provide getLastFailedBuild() and getLastSuccessfulBuild() methods returning pseudo Build objects referring to the computation... so that at least those columns display relevant information w.r.t. the last time the organization was scanned.
            stephenconnolly Stephen Connolly made changes -
            Labels folders multibranch folders multibranch scm-api-tidy-scrub
            stephenconnolly Stephen Connolly made changes -
            Assignee Stephen Connolly [ stephenconnolly ] CloudBees Inc. [ cloudbees ]
            stephenconnolly Stephen Connolly made changes -
            Link This issue blocks JENKINS-41747 [ JENKINS-41747 ]
            stephenconnolly Stephen Connolly made changes -
            Labels folders multibranch scm-api-tidy-scrub folders multibranch scm-api-tidy
            Hide
            jglick Jesse Glick added a comment -

            Or any AbstractFolder.

            Better would be to have core define some kind of extension point for populating this view cell, or simply use ItemGroup.getAllJobs itself.

            Show
            jglick Jesse Glick added a comment - Or any AbstractFolder . Better would be to have core define some kind of extension point for populating this view cell, or simply use ItemGroup.getAllJobs itself.
            stephenconnolly Stephen Connolly made changes -
            Remote Link This issue links to "PR#87 (Web Link)" [ 15495 ]
            stephenconnolly Stephen Connolly made changes -
            Assignee CloudBees Inc. [ cloudbees ] Stephen Connolly [ stephenconnolly ]
            stephenconnolly Stephen Connolly made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            stephenconnolly Stephen Connolly made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            Hide
            stephenconnolly Stephen Connolly added a comment -

            Implementing as reporting the results of the last folder computation.

            Show
            stephenconnolly Stephen Connolly added a comment - Implementing as reporting the results of the last folder computation.
            Hide
            markewaite Mark Waite added a comment - - edited

            Is this also related to the recent regression described in JENKINS-41785 (Multi-branch pipeline status icon no longer shows worst status of jobs in that multi-branch 'folder'), or are those completely independent issues?

            Show
            markewaite Mark Waite added a comment - - edited Is this also related to the recent regression described in JENKINS-41785 (Multi-branch pipeline status icon no longer shows worst status of jobs in that multi-branch 'folder'), or are those completely independent issues?
            Hide
            stephenconnolly Stephen Connolly added a comment -

            Mark Waite These are completely separate issues. The original ask in this issue is to have the last success and last failure (which currently report N/A) return the last success and last failure for any job in the folder.

            More correct IMHO is to actually report the last success / last failure of the folder computation (otherwise you will not see the failed computations) This is what I am fixing here. The other issue is separate and AIUI is a result of the folder icon customization not respecting the custom status icon possibility

            Show
            stephenconnolly Stephen Connolly added a comment - Mark Waite These are completely separate issues. The original ask in this issue is to have the last success and last failure (which currently report N/A) return the last success and last failure for any job in the folder. More correct IMHO is to actually report the last success / last failure of the folder computation (otherwise you will not see the failed computations) This is what I am fixing here. The other issue is separate and AIUI is a result of the folder icon customization not respecting the custom status icon possibility
            Hide
            jglick Jesse Glick added a comment -

            It seems you are hijacking this reasonable RFE (which does, in fact, apply to any folder—not just multibranch) with a distinct RFE (to show some overview of indexing status) which should have been filed separately.

            Show
            jglick Jesse Glick added a comment - It seems you are hijacking this reasonable RFE (which does, in fact, apply to any folder—not just multibranch) with a distinct RFE (to show some overview of indexing status) which should have been filed separately.
            Hide
            stephenconnolly Stephen Connolly added a comment -

            Well I see reporting the last failure of a child job as being contradictory to reporting the last failure of the computation. And with computations, we need to be reporting those last failures

            Show
            stephenconnolly Stephen Connolly added a comment - Well I see reporting the last failure of a child job as being contradictory to reporting the last failure of the computation. And with computations, we need to be reporting those last failures
            Hide
            jglick Jesse Glick added a comment -

            I see reporting the last failure of a child job as being contradictory to reporting the last failure of the computation.

            Why? These seem orthogonal reports.

            Show
            jglick Jesse Glick added a comment - I see reporting the last failure of a child job as being contradictory to reporting the last failure of the computation. Why? These seem orthogonal reports.
            Hide
            stephenconnolly Stephen Connolly added a comment -

            Because they both belong in the same column. We cannot display the last scan success in the same column as the last child item success

            Show
            stephenconnolly Stephen Connolly added a comment - Because they both belong in the same column. We cannot display the last scan success in the same column as the last child item success
            Hide
            jglick Jesse Glick added a comment -

            I would expect a new ListViewColumn for last scan information. But CC Patrick Wolf.

            Show
            jglick Jesse Glick added a comment - I would expect a new ListViewColumn for last scan information. But CC Patrick Wolf .
            stephenconnolly Stephen Connolly made changes -
            Hide
            stephenconnolly Stephen Connolly added a comment - - edited

            As of Jenkins 2.50, the build now button will have the tool tip Schedule a Scan for ___

            To my mind the Lass Success, Last Failure and Last Duration columns logically refer to the action in the "Build" Now column.

            As such, I believe adding new columns would only confuse users... we'd have a `Last Success` and a `Last Computation Success`, a `Last Failure` and a `Last Computation Failure`, a `Last Duration` and a `Last Computation Duration`... plus what would we do for e.g. Compact Columns?

            I think if there is a use case for seeing the info for child builds, that should be a Last Child Build status column

            Show
            stephenconnolly Stephen Connolly added a comment - - edited As of Jenkins 2.50, the build now button will have the tool tip Schedule a Scan for ___ To my mind the Lass Success, Last Failure and Last Duration columns logically refer to the action in the "Build" Now column. As such, I believe adding new columns would only confuse users... we'd have a `Last Success` and a `Last Computation Success`, a `Last Failure` and a `Last Computation Failure`, a `Last Duration` and a `Last Computation Duration`... plus what would we do for e.g. Compact Columns? I think if there is a use case for seeing the info for child builds, that should be a Last Child Build status column
            stephenconnolly Stephen Connolly made changes -
            Hide
            stephenconnolly Stephen Connolly added a comment -

            Jesse Glick Is this really what you are suggesting to expose the computation status?

            Show
            stephenconnolly Stephen Connolly added a comment - Jesse Glick Is this really what you are suggesting to expose the computation status?
            Hide
            hrmpw Patrick Wolf added a comment -

            I really don't like adding more columns just for "Last Computation Success" etc. That will really confuse users that don't know what that means and it widens display for no reason.

            We should either show the last success of a successful indexing or we shouldn't show anything. Showing the last successful build of a branch nested 3 levels deep provides almost no meaningful information. The column title seems pretty generic and doesn't have to be a build.

            Show
            hrmpw Patrick Wolf added a comment - I really don't like adding more columns just for "Last Computation Success" etc. That will really confuse users that don't know what that means and it widens display for no reason. We should either show the last success of a successful indexing or we shouldn't show anything. Showing the last successful build of a branch nested 3 levels deep provides almost no meaningful information. The column title seems pretty generic and doesn't have to be a build.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/FolderComputation.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/PseudoRun.java
            src/main/resources/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder/tasks-top-extra.jelly
            src/main/resources/com/cloudbees/hudson/plugins/folder/computed/Messages.properties
            src/main/resources/com/cloudbees/hudson/plugins/folder/computed/PseudoRun/sidepanel.jelly
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/8eac7c15023886a86ce839dfb809c37736fff674
            Log:
            JENKINS-37369 Expose the last computation for computed folders

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/FolderComputation.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/PseudoRun.java src/main/resources/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder/tasks-top-extra.jelly src/main/resources/com/cloudbees/hudson/plugins/folder/computed/Messages.properties src/main/resources/com/cloudbees/hudson/plugins/folder/computed/PseudoRun/sidepanel.jelly http://jenkins-ci.org/commit/cloudbees-folder-plugin/8eac7c15023886a86ce839dfb809c37736fff674 Log: JENKINS-37369 Expose the last computation for computed folders
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/PseudoRun.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/695f4b651427dc683a6c08c96e8a750904c56d03
            Log:
            JENKINS-37369 Use HttpResponses.redirectViaContextPath

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/computed/PseudoRun.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/695f4b651427dc683a6c08c96e8a750904c56d03 Log: JENKINS-37369 Use HttpResponses.redirectViaContextPath
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/FolderComputation.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/PseudoRun.java
            src/main/resources/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder/tasks-top-extra.jelly
            src/main/resources/com/cloudbees/hudson/plugins/folder/computed/Messages.properties
            src/main/resources/com/cloudbees/hudson/plugins/folder/computed/PseudoRun/sidepanel.jelly
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/4dda5fcd52893c83dc9f6d0a4b4950f53d816fc9
            Log:
            Merge pull request #87 from stephenc/jenkins-37369

            JENKINS-37369 Expose the last computation for computed folders

            Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/9645813fbe71...4dda5fcd5289

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/FolderComputation.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/PseudoRun.java src/main/resources/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder/tasks-top-extra.jelly src/main/resources/com/cloudbees/hudson/plugins/folder/computed/Messages.properties src/main/resources/com/cloudbees/hudson/plugins/folder/computed/PseudoRun/sidepanel.jelly http://jenkins-ci.org/commit/cloudbees-folder-plugin/4dda5fcd52893c83dc9f6d0a4b4950f53d816fc9 Log: Merge pull request #87 from stephenc/jenkins-37369 JENKINS-37369 Expose the last computation for computed folders Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/9645813fbe71...4dda5fcd5289
            Hide
            jglick Jesse Glick added a comment -

            I suppose this should be Fixed? Or, more accurately, Will Not Fix and a separate issue marked as Fixed which reflects what was done instead?

            Show
            jglick Jesse Glick added a comment - I suppose this should be Fixed? Or, more accurately, Will Not Fix and a separate issue marked as Fixed which reflects what was done instead?
            stephenconnolly Stephen Connolly made changes -
            Status In Review [ 10005 ] Closed [ 6 ]
            Resolution Won't Fix [ 2 ]
            Hide
            lyda Kevin Lyda added a comment -

            Ugh. So when I see all my projects on the main view the last success and failure columns relate to some low-level implementation detail of Jenkins instead of the results of my builds?

            Let me just note that as a user this is, at best, a user-indifferent design decision.

            Disappointing.

            Show
            lyda Kevin Lyda added a comment - Ugh. So when I see all my projects on the main view the last success and failure columns relate to some low-level implementation detail of Jenkins instead of the results of my builds? Let me just note that as a user this is, at best, a user-indifferent design decision. Disappointing.
            Hide
            jglick Jesse Glick added a comment -

            Yes it seems weird, but pretty much all UI design work these days goes into Blue Ocean.

            Show
            jglick Jesse Glick added a comment - Yes it seems weird, but pretty much all UI design work these days goes into Blue Ocean.
            Hide
            djviking Sverre Moe added a comment -

            It seems this is halfway implemented. We get information on Last Success and Last Duration, but not Last Failure, that is still showing N/A.

            Show
            djviking Sverre Moe added a comment - It seems this is halfway implemented. We get information on Last Success and Last Duration, but not Last Failure, that is still showing N/A.

              People

              • Assignee:
                stephenconnolly Stephen Connolly
                Reporter:
                djviking Sverre Moe
              • Votes:
                2 Vote for this issue
                Watchers:
                11 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: