Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37397

Allow tool step to use Symbol names instead of classes for tool types

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: pipeline
    • Labels:
      None
    • Similar Issues:

      Description

      Related to JENKINS-37386 - now that we're getting @Symbol on ToolDescriptor, it makes sense to change the tool step to take either the descriptor ID (i.e., the class name) or the relevant symbol.

        Attachments

          Issue Links

            Activity

            Show
            abayer Andrew Bayer added a comment - PR up at https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/16
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/steps/ToolStep.java
            src/test/java/org/jenkinsci/plugins/workflow/steps/ToolStepRunTest.java
            http://jenkins-ci.org/commit/workflow-basic-steps-plugin/20f2223d2d51f5ed3a6114a3064bf1ebca67e4dc
            Log:
            [FIXED JENKINS-37397] Allow use of @Symbols from tools as tool types.

            Fall back to allowing descriptor IDs as well.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: src/main/java/org/jenkinsci/plugins/workflow/steps/ToolStep.java src/test/java/org/jenkinsci/plugins/workflow/steps/ToolStepRunTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/20f2223d2d51f5ed3a6114a3064bf1ebca67e4dc Log: [FIXED JENKINS-37397] Allow use of @Symbols from tools as tool types. Fall back to allowing descriptor IDs as well.

              People

              • Assignee:
                abayer Andrew Bayer
                Reporter:
                abayer Andrew Bayer
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: