Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37516

js-extensions tests failing and not run as part of prepublish

    Details

    • Epic Link:
    • Sprint:
      atlantic, indian, arctic
    • Similar Issues:

      Attachments

        Activity

        Hide
        tfennelly Tom FENNELLY added a comment -

        I did look at the tests to try figure out what was wrong but after seeing that they were also failing on master and were not hooked into the prepublish (to ensure that they would at least be run as part of publishing), I just assumed they were broken for ages. I can't remember if I went back many commit on master, but master was def broken at the time too. But you're obviously right ... disabling tests is a bad idea and a last resort, but when they're obviously broken to begin with and you can't make sense of them, then frustration sets in etc etc.

        I'll reassign this to me and I'll have another look again to see can I figure out what's wrong with it. I have a feeling it might end up back on you though

        Show
        tfennelly Tom FENNELLY added a comment - I did look at the tests to try figure out what was wrong but after seeing that they were also failing on master and were not hooked into the prepublish (to ensure that they would at least be run as part of publishing), I just assumed they were broken for ages. I can't remember if I went back many commit on master, but master was def broken at the time too. But you're obviously right ... disabling tests is a bad idea and a last resort, but when they're obviously broken to begin with and you can't make sense of them, then frustration sets in etc etc. I'll reassign this to me and I'll have another look again to see can I figure out what's wrong with it. I have a feeling it might end up back on you though
        Hide
        michaelneale Michael Neale added a comment -

        Closing as I believe Josh fixed a bunch of these as part of a recent refactoring

        Show
        michaelneale Michael Neale added a comment - Closing as I believe Josh fixed a bunch of these as part of a recent refactoring
        Hide
        tfennelly Tom FENNELLY added a comment -

        Hmmm .... I thought Keith was looking at this actually ... I remember he had a PR for it.

        Show
        tfennelly Tom FENNELLY added a comment - Hmmm .... I thought Keith was looking at this actually ... I remember he had a PR for it.
        Hide
        tfennelly Tom FENNELLY added a comment -
        Show
        tfennelly Tom FENNELLY added a comment - Keith Zantow ^^^
        Show
        tfennelly Tom FENNELLY added a comment - Yeah ... https://github.com/jenkinsci/blueocean-plugin/pull/549

          People

          • Assignee:
            kzantow Keith Zantow
            Reporter:
            tfennelly Tom FENNELLY
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: