Details

    • Type: Bug
    • Status: In Progress (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Component/s: core
    • Labels:
    • Similar Issues:

      Description

      Under some conditions (that I'm failing to diagnose) Converter.canConvert(Class type) is being called with null as argument on a converter which is not NullConverter, those calls lead to {{NullPointerException}}s.

        Attachments

          Issue Links

            Activity

            Hide
            danielbeck Daniel Beck added a comment -

            Do you at least have stack traces?

            Show
            danielbeck Daniel Beck added a comment - Do you at least have stack traces?
            Hide
            amuniz Antonio Muñiz added a comment -

            Yes:

            java.lang.NullPointerException
              at java.lang.Class.isAssignableFrom(Native Method)
              at com.thoughtworks.xstream.converters.reflection.ExternalizableConverter.canConvert(ExternalizableConverter.java:73)
              at com.thoughtworks.xstream.core.DefaultConverterLookup.registerConverter(DefaultConverterLookup.java:74)
              at com.thoughtworks.xstream.XStream$2.registerConverter(XStream.java:502)
              ...
            

            This is after a XStream constructor call, in one of the registerConverter call in the construction chain.

            Show
            amuniz Antonio Muñiz added a comment - Yes: java.lang.NullPointerException at java.lang.Class.isAssignableFrom(Native Method) at com.thoughtworks.xstream.converters.reflection.ExternalizableConverter.canConvert(ExternalizableConverter.java:73) at com.thoughtworks.xstream.core.DefaultConverterLookup.registerConverter(DefaultConverterLookup.java:74) at com.thoughtworks.xstream.XStream$2.registerConverter(XStream.java:502) ... This is after a XStream constructor call, in one of the registerConverter call in the construction chain.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            xstream/src/java/com/thoughtworks/xstream/core/DefaultConverterLookup.java
            http://jenkins-ci.org/commit/xstream/8b101d44c69a1fc46d8020930502e22544ffbc2a
            Log:
            Merge pull request #5 from amuniz/fix-npe

            JENKINS-37757 Protection against NullPointerException

            Compare: https://github.com/jenkinsci/xstream/compare/d3a5bd430863...8b101d44c69a

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: xstream/src/java/com/thoughtworks/xstream/core/DefaultConverterLookup.java http://jenkins-ci.org/commit/xstream/8b101d44c69a1fc46d8020930502e22544ffbc2a Log: Merge pull request #5 from amuniz/fix-npe JENKINS-37757 Protection against NullPointerException Compare: https://github.com/jenkinsci/xstream/compare/d3a5bd430863...8b101d44c69a
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Antonio Muñiz any plans to get the fix released?

            Show
            oleg_nenashev Oleg Nenashev added a comment - Antonio Muñiz any plans to get the fix released?

              People

              • Assignee:
                amuniz Antonio Muñiz
                Reporter:
                amuniz Antonio Muñiz
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: