Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37834

Spacing and alignment of "action" icons is inconsistent

    Details

    • Similar Issues:
    • Sprint:
      1.0-beta-1, 1.0-b05/b-06, frank

      Description

      The "action" icons on the right side of various tables are often improperly aligned (should be right-aligned) and have inconsistent spacing between the icons. The columns are often much wider than they need to be.

      Areas to look at:

      • Pipeline List
      • Activity tab listing
      • Branches tab listing
      • PR's tab listing

      Impl Notes

      • Some icons are placed directly into the td element within the Dashboard code.
      • Other icons (Favorites) are added via an Extensions.Render element
      • Both containers need to ultimately have the same height and apply some consistent horizontal spacing between the elements
      • Probably requires some small tweaks to Extensions.Render itself (perhaps just adding support for a className prop)
      • Column width will be problematic since each is driven by an absolute width set on TH irrespective of the number of child elements. Ideally this should be flexible, although it may require some rejiggering of the table layouts to be more flexible.

        Attachments

        1. Activity.png
          Activity.png
          71 kB
        2. Branches.png
          Branches.png
          77 kB
        3. Input Needed Teal.png
          Input Needed Teal.png
          94 kB

          Issue Links

            Activity

            Hide
            cliffmeyers Cliff Meyers added a comment -

            Perhaps the Extension Point should be in its own td and we can just prevent wrapping of the content. Any "standard icons" should perhaps be in their own td.

            Show
            cliffmeyers Cliff Meyers added a comment - Perhaps the Extension Point should be in its own td and we can just prevent wrapping of the content. Any "standard icons" should perhaps be in their own td.
            Hide
            jamesdumay James Dumay added a comment -

            Cliff Meyers I know Brody Maclean might have some opinions on this (he had a few tweaks in mind for the actions on the cards)

            Show
            jamesdumay James Dumay added a comment - Cliff Meyers I know Brody Maclean might have some opinions on this (he had a few tweaks in mind for the actions on the cards)
            Hide
            michaelneale Michael Neale added a comment - - edited

            Brody will soon have some screen/design input for this BTW (we got sidetracked on colours, but no change there for now)

            Show
            michaelneale Michael Neale added a comment - - edited Brody will soon have some screen/design input for this BTW (we got sidetracked on colours, but no change there for now)
            Hide
            brody Brody Maclean added a comment -

            Cliff Meyers I've attached mockups with adjusted action button alignments

            Show
            brody Brody Maclean added a comment - Cliff Meyers I've attached mockups with adjusted action button alignments
            Hide
            jamesdumay James Dumay added a comment -

            Will do the table overhaul instead

            Show
            jamesdumay James Dumay added a comment - Will do the table overhaul instead

              People

              • Assignee:
                sophistifunk Josh McDonald
                Reporter:
                cliffmeyers Cliff Meyers
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: