Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38166

Changes link in mail is upper case, but should lower

    Details

    • Similar Issues:

      Description

      Since Jenkins 2.22 or near of this version is the link in mail on job fail wrong
      wrong link:
      http://jenkinssrv/job/Dev_Build/526/Changes

      correct link:
      http://jenkinssrv/job/Dev_Build/526/changes

        Attachments

          Activity

          Hide
          arbeita Ronny Borchert added a comment -

          I guess the link is returned by line:

          buf.append(DisplayURLProvider.get().getRunURL(build));

          https://github.com/jenkinsci/mailer-plugin/blob/master/src/main/java/hudson/tasks/MailSender.java#L252

          But I annot find the implementation for the "changes" url ,except in blue ocean code, where it looks right.

          Show
          arbeita Ronny Borchert added a comment - I guess the link is returned by line: buf.append(DisplayURLProvider.get().getRunURL(build)); https://github.com/jenkinsci/mailer-plugin/blob/master/src/main/java/hudson/tasks/MailSender.java#L252 But I annot find the implementation for the "changes" url ,except in blue ocean code, where it looks right.
          Hide
          b_brueckmann Benedikt Brückmann added a comment -

          I suspect the changes for i18n in version 1.18 of the mailer-plugin.
          I noticed, that the link in my mails ends with /Änderungen: (german localization).

          So I think it is the MailSender.FailureMail.Changes property from mailer-plugin/src/main/resources/jenkins/plugins/mailer/tasks/i18n/Messages<locale>.properties which is appended to the job URL.

          Ronny Borchert: do you have a colon appended to your link, which wasn't there in older mails?

          Show
          b_brueckmann Benedikt Brückmann added a comment - I suspect the changes for i18n in version 1.18 of the mailer-plugin. I noticed, that the link in my mails ends with /Änderungen: (german localization). So I think it is the MailSender.FailureMail.Changes property from mailer-plugin/src/main/resources/jenkins/plugins/mailer/tasks/i18n/Messages<locale>.properties which is appended to the job URL. Ronny Borchert : do you have a colon appended to your link, which wasn't there in older mails?
          Hide
          arbeita Ronny Borchert added a comment -

          Yes, in my mail is a colon after word "Changes". So it is the possible fault.

          Show
          arbeita Ronny Borchert added a comment - Yes, in my mail is a colon after word "Changes". So it is the possible fault.
          Hide
          egutierrez Evaristo Gutierrez added a comment -

          This is probably resolved after changes in https://issues.jenkins-ci.org/browse/JENKINS-40224

          Could you evaluate against mailer-1.19?

          Show
          egutierrez Evaristo Gutierrez added a comment - This is probably resolved after changes in https://issues.jenkins-ci.org/browse/JENKINS-40224 Could you evaluate against mailer-1.19?
          Hide
          arbeita Ronny Borchert added a comment -

          Yes it works now. It use a complete different link with redirect in it, but it works.

          Show
          arbeita Ronny Borchert added a comment - Yes it works now. It use a complete different link with redirect in it, but it works.
          Hide
          egutierrez Evaristo Gutierrez added a comment - - edited

          Can you mark this as resolved then?

          Show
          egutierrez Evaristo Gutierrez added a comment - - edited Can you mark this as resolved then?
          Hide
          arbeita Ronny Borchert added a comment -

          since update to mail plugin 1.19 it works

          Show
          arbeita Ronny Borchert added a comment - since update to mail plugin 1.19 it works

            People

            • Assignee:
              Unassigned
              Reporter:
              arbeita Ronny Borchert
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: