Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38458

Mandate consistent iteration order for DepthFirstScanner

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      DepthFirstScanner in the graphanalysis APIs works, but the API mandates that it visit the first node then the branches after (but in reverse order).

      Instead we should visit the branches in order for drop-in compatibility with FlowGraphWalker

      This will, incidentally, fix JENKINS-38457.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            JENKINS-38457 did you mean?

            Show
            jglick Jesse Glick added a comment - JENKINS-38457 did you mean?
            Hide
            jglick Jesse Glick added a comment -

            Does not fix JENKINS-38457, since that requires FlowGraphTable to also reverse its parallel branches.

            Show
            jglick Jesse Glick added a comment - Does not fix JENKINS-38457 , since that requires FlowGraphTable to also reverse its parallel branches.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Sam Van Oort
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/DepthFirstScanner.java
            http://jenkins-ci.org/commit/workflow-api-plugin/3baae43984b507100343473c61c6c7615085d02e
            Log:
            Make DepthFirstScanner obey last->first parallel branch ordering per JENKINS-38458

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/DepthFirstScanner.java http://jenkins-ci.org/commit/workflow-api-plugin/3baae43984b507100343473c61c6c7615085d02e Log: Make DepthFirstScanner obey last->first parallel branch ordering per JENKINS-38458
            Hide
            svanoort Sam Van Oort added a comment -

            Addressed with https://github.com/jenkinsci/workflow-api-plugin/pull/16 (enforcing the same semi-loony iteration order as FlowGraphWalker, but at least that makes it fully compatible).

            Show
            svanoort Sam Van Oort added a comment - Addressed with https://github.com/jenkinsci/workflow-api-plugin/pull/16 (enforcing the same semi-loony iteration order as FlowGraphWalker, but at least that makes it fully compatible).
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Sam Van Oort
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/DepthFirstScanner.java
            src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/package-info.java
            src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/FlowScannerTest.java
            http://jenkins-ci.org/commit/workflow-api-plugin/bcd2e30a9a3e3c9a9364c47ffec04cfe715f41fc
            Log:
            Merge pull request #16 from jenkinsci/make-depthfirstscanner-obey-ordering-JENKINS-38458

            Make DepthFirstScanner obey first-last parallel branch ordering JENKINS-38458

            Compare: https://github.com/jenkinsci/workflow-api-plugin/compare/85d91e8e2e09...bcd2e30a9a3e

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/DepthFirstScanner.java src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/package-info.java src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/FlowScannerTest.java http://jenkins-ci.org/commit/workflow-api-plugin/bcd2e30a9a3e3c9a9364c47ffec04cfe715f41fc Log: Merge pull request #16 from jenkinsci/make-depthfirstscanner-obey-ordering- JENKINS-38458 Make DepthFirstScanner obey first-last parallel branch ordering JENKINS-38458 Compare: https://github.com/jenkinsci/workflow-api-plugin/compare/85d91e8e2e09...bcd2e30a9a3e
            Hide
            svanoort Sam Van Oort added a comment -

            Released as v2.4

            Show
            svanoort Sam Van Oort added a comment - Released as v2.4

              People

              • Assignee:
                svanoort Sam Van Oort
                Reporter:
                svanoort Sam Van Oort
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: